From what I deciphered reading the line https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/macdeployqtplus#L390 is that qt translations are optional to have hence we should be able to build without it but the case where the flag translations_dir falls back to its default Null value it raises this error. I have moved the code which adds language files under the if statement that first checks if the value of the flag is not Null before referencing it. This PR assumes that having Qt translations is optional however this statement requires a second opinion. Build completes successfully post this change with default value of the flag.
contrib: fix for macOS deployment build failing on Qt translations even though it is optional. #33482
pull amishhaa wants to merge 1 commits into bitcoin:master from amishhaa:macOS-build-fix changing 1 files +8 −8-
amishhaa commented at 5:35 am on September 26, 2025: none
-
contrib: fix using macdploy script without translations.
QT translations are optional, but the script would error when 'translations_dir' falls back to its default value NULL. This PR fixes it by moving the set-up of QT translations under the check for 'translations_dir' presence.
-
DrahtBot added the label Scripts and tools on Sep 26, 2025
-
DrahtBot commented at 5:35 am on September 26, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33482.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
Labels
Scripts and tools
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-26 15:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-26 15:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me