ci: use latest versions of lint deps #33487

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:ci_bump_deps changing 1 files +4 −4
  1. fanquake commented at 10:14 pm on September 28, 2025: member

    Some of the versions used here are > 2 years old. i.e mypy. Use the latest avilable versions, except for LIEF, which is generally changed with Guix.

    Side note. I can’t remember the last time one of these tools (mypy, ruff, vulture) actually caught an issue in the lint job.

  2. DrahtBot added the label Tests on Sep 28, 2025
  3. DrahtBot commented at 10:14 pm on September 28, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33487.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, janb84, hebasto
    Stale ACK stickies-v

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko commented at 7:33 am on September 29, 2025: member

    Side note. I can’t remember the last time one of these tools (mypy, ruff, vulture) actually caught an issue in the lint job.

    The last thing mypy found was a false positive: #33201 (comment) and #33201 (review)

    Ruff is doing basically all python checks and finds stuff frequently: E.g. #33270 (comment)

    vulture is only doing small checks, so I am not sure either.

  5. maflcko commented at 7:34 am on September 29, 2025: member
    lgtm ACK aeab2c7f1d151beda3eff94fb4effc85a4d4a344
  6. in ci/lint/01_install.sh:46 in aeab2c7f1d
    45-  pyzmq==25.1.0 \
    46-  ruff==0.5.5 \
    47-  vulture==2.6
    48+  mypy==1.18.2 \
    49+  pyzmq==27.1.0 \
    50+  ruff==0.13.1 \
    


    janb84 commented at 8:33 am on September 29, 2025:
    Why ruff 0.13.1 and not 0.13.2 ? or was it updated between PR creation and now ?

    fanquake commented at 6:48 pm on September 29, 2025:
    Yea. Using 0.13.2 now.
  7. janb84 commented at 8:34 am on September 29, 2025: contributor

    Concept ACK aeab2c7f1d151beda3eff94fb4effc85a4d4a344

    This PR updates lint dependency packages to the latests versions.

    Small NIT / question about ruff version.

  8. stickies-v approved
  9. stickies-v commented at 3:16 pm on September 29, 2025: contributor
    utACK aeab2c7f1d151beda3eff94fb4effc85a4d4a344
  10. DrahtBot requested review from janb84 on Sep 29, 2025
  11. ci: use latest versions of lint deps
    Some of the versions used here are > 2 years old. i.e mypy. Use the
    latest avilable versions, except for LIEF, which is generally changed
    with Guix.
    d4f47f9771
  12. fanquake force-pushed on Sep 29, 2025
  13. maflcko commented at 6:51 am on September 30, 2025: member
    lgtm ACK d4f47f97715c7b6a2879e99c62f09ccead8cc4cd
  14. DrahtBot requested review from stickies-v on Sep 30, 2025
  15. janb84 commented at 6:53 am on September 30, 2025: contributor

    lgtm ACK d4f47f97715c7b6a2879e99c62f09ccead8cc4cd

    checked versions, all are on their latests versions ✅

    (thanks for updating ruff)

  16. hebasto approved
  17. hebasto commented at 7:16 am on September 30, 2025: member
    ACK d4f47f97715c7b6a2879e99c62f09ccead8cc4cd, I have reviewed the code and it looks OK.
  18. hebasto merged this on Sep 30, 2025
  19. hebasto closed this on Sep 30, 2025

  20. fanquake deleted the branch on Sep 30, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-10 12:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me