depends: Update URL for qrencode package source tarball #33494

pull hebasto wants to merge 4 commits into bitcoin:master from hebasto:250929-qrencode changing 2 files +5 −6
  1. hebasto commented at 1:36 pm on September 29, 2025: member

    The https://fukuchi.org/ homepage no longer links to the source tarball, and previously available files appear to have been removed. The homepage now instructs users to download source tarballs from the GitHub releases page instead.

    The diff between the source trees is immaterial:

     0--- old
 1+++ new
 2@@ -1,19 +1,16 @@
 3 27e7deccd2925c94e4190ee64794a051199f215f145f76fd664cdebedbbf8a35  acinclude.m4
 4-e1e35b1309482f699a9700a2065a0bce09c2108dd1f78ba7bfbe0f7f0bdcd2e6  aclocal.m4
 5 a9308eec78790720dbcd5452ab8f241b5f1c6939ccf3389917b8e78cb2b58c9e  autogen.sh
 6 aa36725d577048f0370dc7415a1acb578fbdfb531c1b384a836d9360a81f6f5c  bitstream.c
 7 3feaacd7d096834fc5956215598564ec287ad443185c4433c3f8007cc53ceaa6  bitstream.h
 8 21bd5a34c90d3d6ee540ceb48c3d5aea5f21bd6b829ef3112db832af0bd423d8  ChangeLog
 9 f8a7a94c9622fab721df47e8121533ebfcb79885aca01ecec2fff00dfb84caef  cmake/FindIconv.cmake
10 6345e7eecb92473f361a8eb98dd373aa09cae79a43408cf4b42b00b411c9c197  CMakeLists.txt
11-031d560570eab2eda57c2f9ee9952445002f8bf4a23965fcaf43bbc2c61590e2  config.h.in
12-d2f42cc5771b69f2d2ecd4b31509864ae2b18b25c823986390bb372ee07030fa  configure
13 02867a8ea08206c84d5f4c05f41a15c639291091e3dfac27f3a9029d8f5d3028  configure.ac
14 a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861  COPYING
15 76c41754bccbf69a60fb7833776637c60b86f59104705c0a5cea9ee3a2968f3d  Doxyfile
16 36d84f714cf28397b02d6c44860106a7cb858fc6d25239a2698a72fa5136e5c3  libqrencode.pc.in
17 f0ce93a7e1b1f0fab87dd071ec3c8dd80a567d778dfc5930d9f375d676ecb9a0  Makefile.am
18-507c2385fb49c5724e8e3dfca97feb24cbdd4e651f3f0bfa62524e60088091a0  Makefile.in
19+dcb782b1b382328c0bce9194944bdcc65a6035d8e9f89e39436ed2e55ae8b969  makeREADME.sh
20 6046d347c6c564fc13a24dc0a15a09a83023e00a4e0d0f23029a81f86ac4d024  mask.c
21 9f853cee7d72191a8dbf018b7a86c0f0b6ca661e27a51fab677af911f2ff9e7e  mask.h
22 a4e17b68d8db573e152132ebcbdc837b55415c12027f81232662db645faf79f0  mmask.c
23@@ -30,7 +27,7 @@
24 6e9ff66002b4a839c6e78bcd6a55342d9eb8b289273fa838441b27ee9969e293  qrinput.h
25 68831e02ee1ba602b1937328abec000e616c4472d9dc40067dd45ab7072df172  qrspec.c
26 a2a9a5af4d62015e82b48b8316aea2b70031dcdc1ed2b829c0102ea5dc02aca2  qrspec.h
27-8730d006f1d45b90dc0ef9a20e4119420f15b37a09483c929baa4225e21f7900  README
28+a56773b55989ea5cae8a43f2d845ce0afa9576a26170937fbe36a69fee953cd4  README.md
29 ace480f2e16001e276c73a5e965c282915ad81e2c28cce3ef574b5a8db7210e8  rsecc.c
30 c731ebe26d58d5e5df3b2d694de0fb1c4ae80a36cf0559c49b04e989dee8b182  rsecc.h
31 8ed1af4414b5628845519581c82bf51ba2b4dee1f8352c1fd01b50afcd0a0ed7  split.c
32@@ -46,7 +43,6 @@
33 e26b20198a7393b3c060891876fa45edb81488aef9df6d6cf45893a605e5e5e4  tests/decoder.h
34 adabfbddb0f25de2e2cae970195fcfdf11ad1fa66ce64e237d83f821346f64c4  tests/frame
35 23c283a3d3b5f1bbb3108603ebf05d7a95951ba86a288e09140eab612a5eb258  tests/Makefile.am
36-c8b819bf7f00c979ab0b6f0d0fb10289d2006bc6acda1737d2f1c383a60e1e66  tests/Makefile.in
37 ebd71b937d4d39f382f8c57f362a01f11fd617b66dbdf6f1a3c4897c8c42e235  tests/prof_qrencode.c
38 d4adcb234d4c31473cd9ffedd1bfa9645ba336d426640ba5893dfe6e75db171d  tests/pthread_qrencode.c
39 62298641504b0a2c1d199cd7f656cb376959200169042de76f7c5950d2d42395  tests/rscode.c
40@@ -63,6 +59,7 @@
41 cf5792cbfb92ba46f7f5f14b98f00813b0e7e4f5e7c790c6a28793774474bf26  tests/test_monkey.c
42 3a2c58346d57f6bb2a634d6febf3c65ac524259a2d789657f8d60c678bf8d658  tests/test_mqrspec.c
43 b9d8c569ba36a2258cb1ad0d1f85ce4fb2935fad519e902bade59aa9772321aa  tests/test_qrencode.c
44+785fe14a6f8bc096b20ec271771fb09f22f29eb4f9d729f5b40d6b4cc824ce36  tests/test_qrenc.sh
45 d0eee6eddf98ee4595c07f7da40c7de548651bf839b26995756e94db2599451f  tests/test_qrinput.c
46 ace7885e435ef77cc127da0ac23c724498aaa8d80d53b908063f79c9f0b7acce  tests/test_qrspec.c
47 fde9c2735ce94be51e1b0bbffe65415aa3afd2da5bd4c0e2c5e50e1a2f1ea3f7  tests/test_rs.c
48@@ -71,12 +68,4 @@
49 6f35c0e1235b31d0068c4ab175d8110c736e60df0309d4be7b3e57dd62d316f6  tests/URI_testset.inc
50 6be3983fc397cd5dade1dd219ad6cbe7977f416410b1509984006ecec51605b5  tests/view_qrcode.c
51 92b5be1ca2239399232d51503715c848dae9bf3db71b1f03157bfa9779826910  TODO
52-c8af04e62bad4ab75dafd22119026e5e3943f385bdcbe7731a4938102453754c  use/compile
53-1d9048b0ac9d4d1dfce7aa4e3a0b59ccfd32db2f7693814aa6f4c778560f5669  use/config.guess
54 b522487f9c47661d321367d133f3d41247dd16d435f2d4b9c643dee95bf65eee  use/config.rpath
55-5bf0da2576ebb21ab60a9d9291a85b40af0e956a9eafb709ca8b20dcb105f4ee  use/config.sub
56-732bcd6b9e23f241e015d71b0a3a862104053aba20718c1f56b292cee7e29371  use/depcomp
57-608b76d735bb2ec2bcb1271644c3d5e7a428fb8d2338e114e8a48ebf91ccfd23  use/install-sh
58-2304d53af1f63b76a11651efdd18578adf2bda1ffc2c257100cba374b55f284b  use/ltmain.sh
59-f038345dab184e538098d22a8edc423762da66a90ebe269f23bfef85287cd30c  use/missing
60-7c1ae35455771ae32050c2ed109e3d297160b6d1a2f70b0278cf6968e5e7e98c  use/test-driver

    UPDATE 2025-09-30

    A few commits have been added:

    1. The first commit fixes the $(package)_fetched target, which erroneously succeeds on the second run after a failure on the master branch:
    0$ gmake -C depends clean-all
1$ gmake -C depends qrencode_fetched FALLBACK_DOWNLOAD_PATH="https://fallback.invalid"
2$ gmake -C depends qrencode_fetched FALLBACK_DOWNLOAD_PATH="https://fallback.invalid"
3$ echo $?
40

    With the first commit applied:

    0$ gmake -C depends clean-all
1$ gmake -C depends qrencode_fetched FALLBACK_DOWNLOAD_PATH="https://fallback.invalid"
2$ gmake -C depends qrencode_fetched FALLBACK_DOWNLOAD_PATH="https://fallback.invalid"
3$ echo $?
42
    1. The second and third commits allow the depends build subsystem to detect when the source tarball content has been modified and needs to be re-downloaded, even if the file name remains the same.
  2. hebasto added the label Build system on Sep 29, 2025
  3. DrahtBot commented at 1:36 pm on September 29, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33494.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK m3dwards, vasild, janb84, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. vasild commented at 1:58 pm on September 29, 2025: contributor

    For me, the checksum is the same as in the PR:

    0$ wget -q -O - https://github.com/fukuchi/libqrencode/archive/refs/tags/v4.1.1.tar.gz |sha256
15385bc1b8c2f20f3b91d258bf8ccc8cf62023935df2d2676b5b67049f31a049c
2$

    but CI:

    0sha256sum: WARNING: 1 computed checksum did NOT match
1/home/admin/actions-runner/_work/_temp/depends/sources/qrencode-4.1.1.tar.gz: FAILED
  5. hebasto commented at 2:30 pm on September 29, 2025: member

    For me, the checksum is the same as in the PR:

    0$ wget -q -O - https://github.com/fukuchi/libqrencode/archive/refs/tags/v4.1.1.tar.gz |sha256
15385bc1b8c2f20f3b91d258bf8ccc8cf62023935df2d2676b5b67049f31a049c
2$

    but CI:

    0sha256sum: WARNING: 1 computed checksum did NOT match
1/home/admin/actions-runner/_work/_temp/depends/sources/qrencode-4.1.1.tar.gz: FAILED

    I believe it’s a cache issue. @willcl-ark @m3dwards @maflcko

    Can the depends CI cache be invalidated: (1) for this PR; (2) globally?

  6. hebasto force-pushed on Sep 29, 2025
  7. maflcko commented at 2:37 pm on September 29, 2025: member

    Can the dependency CI cache be invalidated: (1) for this PR; (2) globally?

    I wouldn’t know how, other than by changing the cache key value (both for restore and save): https://github.com/bitcoin/bitcoin/blob/d8fe258cd6105704bf4427eda048dd7085ca516d/.github/actions/restore-caches/action.yml#L21

  8. hebasto commented at 2:46 pm on September 29, 2025: member

    I believe it’s a cache issue.

    Resolved by using the new $(package)_file_name value.

  9. maflcko added the label DrahtBot Guix build requested on Sep 29, 2025
  10. m3dwards commented at 2:54 pm on September 29, 2025: contributor

    Can the depends CI cache be invalidated: (1) for this PR; (2) globally?

    I would have thought the cache should have been invalidated automatically, looking into it.

  11. DrahtBot commented at 6:03 am on September 30, 2025: contributor

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit d8fe258cd6105704bf4427eda048dd7085ca516d(master) commit 3cabcc8810eb184a91953a782cedc4b85fdebf68(pull/33494/merge)
    *-aarch64-linux-gnu-debug.tar.gz 0985b325d97702b9... d341290d68248c2b...
    *-aarch64-linux-gnu.tar.gz 431d9be2d5e32f3d... 1a8cdcdd18da28fd...
    *-arm-linux-gnueabihf-debug.tar.gz 83ee579fd8c6304d... f2b8037832d7adee...
    *-arm-linux-gnueabihf.tar.gz 94f2845bb6e1c641... 37fb6fe5a5bcf2e8...
    *-arm64-apple-darwin-codesigning.tar.gz 272d4c5be534f44b... 21f315b229195cec...
    *-arm64-apple-darwin-unsigned.tar.gz 62cfd0c34ba733a0... 6104df0d320c2c80...
    *-arm64-apple-darwin-unsigned.zip 698e87b786bac0f8... 29443af60ba4793e...
    *-powerpc64-linux-gnu-debug.tar.gz eb9b7dfcef76c322... 58e0149d3a8cea1c...
    *-powerpc64-linux-gnu.tar.gz c5ddc030cf2c34ec... 4b45e6fb6178aba6...
    *-riscv64-linux-gnu-debug.tar.gz edbf66060dcbbbcb... b34350b745925364...
    *-riscv64-linux-gnu.tar.gz 47f49ffcbad10364... 6bde066e9618bb8b...
    *-x86_64-apple-darwin-codesigning.tar.gz 524991e986700934... ec1081faf0dcfd74...
    *-x86_64-apple-darwin-unsigned.tar.gz bff5373f963b4361... e547202a057cb46d...
    *-x86_64-apple-darwin-unsigned.zip 0cff8cca5b88ca6a... 8df7131ef60f25dd...
    *-x86_64-linux-gnu-debug.tar.gz 0a1ab1c92f38a3e1... b39dfa13a59d5b84...
    *-x86_64-linux-gnu.tar.gz 49d3ee674d092a81... 2ac874da409d62c2...
    *.tar.gz 88a49c4afbd2f6f6... 0dff998dca9c936d...
    SHA256SUMS.part c9fc112c03cf3404... bfdd7d9a15f36d31...
    guix_build.log 187a2c868dd0108d... 26d3ee4f60e33bcc...
    guix_build.log.diff 732204f7c05f4d6c...
  12. DrahtBot removed the label DrahtBot Guix build requested on Sep 30, 2025
  13. hebasto commented at 6:44 am on September 30, 2025: member

    My Guix build:

     0aarch64
 1b286e83a69f60494b86be866ce3b4aaa7c58aeb2e9410a38b898c2afe6946f59  guix-build-980e4987db04/output/aarch64-linux-gnu/SHA256SUMS.part
 2c9bcfe3c18dd5a7130c3ccbb17f8f51f7486a9bbfdb57c9ee59164003013de39  guix-build-980e4987db04/output/aarch64-linux-gnu/bitcoin-980e4987db04-aarch64-linux-gnu-debug.tar.gz
 3f72be7de9bb5d037e9e27db645d8578f031e6a7b6b9096c573dfba56cbcb8a0c  guix-build-980e4987db04/output/aarch64-linux-gnu/bitcoin-980e4987db04-aarch64-linux-gnu.tar.gz
 4ff9ff073f6ac17e8bf1bf3c6101d0bd3df4221a61695e977299b12b724a5533d  guix-build-980e4987db04/output/arm-linux-gnueabihf/SHA256SUMS.part
 5de7e5a7258374d04a183613e4fcdfdcd01cff13c14f6b18f20442163882f5dfb  guix-build-980e4987db04/output/arm-linux-gnueabihf/bitcoin-980e4987db04-arm-linux-gnueabihf-debug.tar.gz
 6bdbfd394674325adc4982ca5452499f61ec75f75bb2cf6d737d373e5d208408b  guix-build-980e4987db04/output/arm-linux-gnueabihf/bitcoin-980e4987db04-arm-linux-gnueabihf.tar.gz
 7a80f1d0b539c53166c5bb28377dfe198424bcc91393efd55a8d10a35f1ef2f89  guix-build-980e4987db04/output/arm64-apple-darwin/SHA256SUMS.part
 8b91a9c185d538e3baa07ae3fa43a041a96404d70b0705a0accc3ecbfd2e0a408  guix-build-980e4987db04/output/arm64-apple-darwin/bitcoin-980e4987db04-arm64-apple-darwin-codesigning.tar.gz
 906a988612611fff458db729feb04f35486d2ecc6995e932d8fa09ddd3f4bd26c  guix-build-980e4987db04/output/arm64-apple-darwin/bitcoin-980e4987db04-arm64-apple-darwin-unsigned.tar.gz
10582b6c78ff750d73d1e6295d4b1528169403ac0bdd97288e44ec2e8589ef110d  guix-build-980e4987db04/output/arm64-apple-darwin/bitcoin-980e4987db04-arm64-apple-darwin-unsigned.zip
11dfb856d3239129eb13f5322da45327da405e34880e61f5432e577183672d3ec8  guix-build-980e4987db04/output/dist-archive/bitcoin-980e4987db04.tar.gz
124d14acd7896c395e9b81f015f5713195f7c09f11916f3efaf8fce796a3cbad5e  guix-build-980e4987db04/output/powerpc64-linux-gnu/SHA256SUMS.part
137dd302884b8b6a75353815cb96370ecd3c17c87b626c3078b3c28a615dbc8ff5  guix-build-980e4987db04/output/powerpc64-linux-gnu/bitcoin-980e4987db04-powerpc64-linux-gnu-debug.tar.gz
14bdd8f3f1cbddbecac8b950b87df91f8194e9943e8743ee7655320f769c4b7830  guix-build-980e4987db04/output/powerpc64-linux-gnu/bitcoin-980e4987db04-powerpc64-linux-gnu.tar.gz
153c17db120a654174c077ae525d038879d1d33ee03ca1b1c7a0f19c02b2f3e9b0  guix-build-980e4987db04/output/riscv64-linux-gnu/SHA256SUMS.part
16ebd042b3a957f76094d8e97d0aee0a55e9b1b7b8a771218b69925b1961a21bbc  guix-build-980e4987db04/output/riscv64-linux-gnu/bitcoin-980e4987db04-riscv64-linux-gnu-debug.tar.gz
17e9c4868fc02ae82694163213927396208856ffb1a9dbbd44178f8f2676379caf  guix-build-980e4987db04/output/riscv64-linux-gnu/bitcoin-980e4987db04-riscv64-linux-gnu.tar.gz
18838908adec9780dd9a85882c4035f204e6b9e21d5481c42410b10691e546e51b  guix-build-980e4987db04/output/x86_64-apple-darwin/SHA256SUMS.part
19ee297e38b255485ccd6e20af3c5364bd2b23e1bf508575e21f7ed2313eb201a6  guix-build-980e4987db04/output/x86_64-apple-darwin/bitcoin-980e4987db04-x86_64-apple-darwin-codesigning.tar.gz
2008027a0440bdc5f2bd849bf372d6c510a5fd501f4f226ba630483e9715d6b616  guix-build-980e4987db04/output/x86_64-apple-darwin/bitcoin-980e4987db04-x86_64-apple-darwin-unsigned.tar.gz
215c64977fbd91422c06337c06d8596380cb3b139fbd96cf19019f07ef8dde6918  guix-build-980e4987db04/output/x86_64-apple-darwin/bitcoin-980e4987db04-x86_64-apple-darwin-unsigned.zip
22163e6d8ac8811c116d5dc82f6c9131190750d2e6a3a29afa6ab5e10c07a2567f  guix-build-980e4987db04/output/x86_64-linux-gnu/SHA256SUMS.part
2311c6be60d64428a6e5b57e9eec3dcdc7f4673cb92c61cfa80a7dbbd58cbf6814  guix-build-980e4987db04/output/x86_64-linux-gnu/bitcoin-980e4987db04-x86_64-linux-gnu-debug.tar.gz
24880d0cdf99b74034e374185da8dbd75d2b56c8ae3847d61ca1c5bf09e6ebccfc  guix-build-980e4987db04/output/x86_64-linux-gnu/bitcoin-980e4987db04-x86_64-linux-gnu.tar.gz
2536643fb96c83baaa1e2f012de84a3cfd3d5ade81d6e033a34f02676826ac55aa  guix-build-980e4987db04/output/x86_64-w64-mingw32/SHA256SUMS.part
26c1a233a69240ecb8bcd4362ecbda8cf2c3af58c2be82ee45fc12888a2450a671  guix-build-980e4987db04/output/x86_64-w64-mingw32/bitcoin-980e4987db04-win64-codesigning.tar.gz
2736dd8fb2fe205755d062cdb7ea2199412486b86f7b18fce1a3cd358aa0f91992  guix-build-980e4987db04/output/x86_64-w64-mingw32/bitcoin-980e4987db04-win64-debug.zip
28f66bb27aa81ed972a4ce11b1c27c2a07de732e5ae1ccde120de686aaf8fe529e  guix-build-980e4987db04/output/x86_64-w64-mingw32/bitcoin-980e4987db04-win64-setup-unsigned.exe
29f5e1927c9519b19fbc9d93fdf6e5dcf970973299f4da58a4f1be97aa05ba7d0d  guix-build-980e4987db04/output/x86_64-w64-mingw32/bitcoin-980e4987db04-win64-unsigned.zip
  14. vasild approved
  15. vasild commented at 7:26 am on September 30, 2025: contributor

    ACK 980e4987db0450cabb8761433001841f7e9f4c73

    I confirm the diff from the OP. The old archive is not available anymore at https://fukuchi.org/works/qrencode/qrencode-4.1.1.tar.gz, so I downloaded it from https://bitcoincore.org/depends-sources/qrencode-4.1.1.tar.gz instead. The new one is at https://github.com/fukuchi/libqrencode/archive/refs/tags/v4.1.1.tar.gz.

    Then I extracted each archive, did

    0for f in $(find ./ -type f |sort) ; do sha256sum "$f" ; done

    and compared the resulting diff to the OP. It is the same, except some more dot-files in the new archive:

    0+a11819fcd7107f6b45336207762a362dbd83ce46c06b5c126d38c98860b0f5a3 ./.github/workflows/cmake-windows.yml
1+e8e213ffe4d032685b3215feb6c1cb821442f0bc5a2d00f147a4f474bb5de2d2 ./.github/workflows/cmake.yml
2+8db8a290dbcb99d04ec021f107e50c0da7f84f461b251955869f7d69174b54e4 ./.github/workflows/configure.yml
3+a1f246edb6aedbc908987bd04e0743f4ebf415858b10bf81b6a7969dd6bf2409 ./.gitignore
4+4eff4a00c6a9f09c9fb39751dc6666b8a6d845de0a4fc6b38522740b6a262e41 ./.travis.yml
  16. in depends/packages/qrencode.mk:4 in 980e4987db 
    0@@ -1,8 +1,8 @@
1 package=qrencode
2 $(package)_version=4.1.1
3-$(package)_download_path=https://fukuchi.org/works/qrencode/
4-$(package)_file_name=$(package)-$($(package)_version).tar.gz
5-$(package)_sha256_hash=da448ed4f52aba6bcb0cd48cac0dd51b8692bccc4cd127431402fca6f8171e8e
6+$(package)_download_path=https://github.com/fukuchi/libqrencode/archive/refs/tags/
7+$(package)_file_name=v$($(package)_version).tar.gz
    luke-jr commented at 8:09 am on September 30, 2025:
    Seems kind of ugly to lose the package name in the filename. How about $(package)-$($(package)_version)-github.tar.gz or something?
    hebasto commented at 11:00 am on September 30, 2025:
    Reworked.
  17. luke-jr referenced this in commit 7a77b2a948 on Sep 30, 2025
  18. depends: Fix `$(package)_fetched` target 
    Ensure the download timestamp is created only after a successful
download.
    771978952a
  19. depends: Drop redundant check for downloaded file 
    The `fetch_file` commands are invoked for the `$($(package)_fetched)`
target, so the existence of the download stamp has already been tested.
    46135d90ea
  20. depends: Use hash instead of file name for package download stamp 
    The package version is still included for convenience.
    6de8051263
  21. depends: Update URL for `qrencode` package source tarball 
    The https://fukuchi.org/ homepage no longer links to the source tarball,
and previously available files appear to have been removed. The homepage
now instructs users to download source tarballs from the GitHub releases
page instead.

The diff between the source trees is immaterial.
    93a70a42d3
  22. hebasto force-pushed on Sep 30, 2025
  23. willcl-ark commented at 10:39 am on September 30, 2025: member

    Can the depends CI cache be invalidated: (1) for this PR; (2) globally?

    I would have thought the cache should have been invalidated automatically, looking into it.

    So what has happened here is that the depends caches have missed on an exact cache hit, but restored the latest backup hit via:

    https://github.com/bitcoin/bitcoin/blob/25212dfdb4cd7291392b6a94130f658c5bfa0a48/.github/actions/restore-caches/action.yml#L29-L31

    It was my understanding that make -C depends was able to detect changes to the *.mk files and rebuild (changed) packages, but it seems that this is not the case when a cached .tar.gz is detected; make does not check if the recipe has changed.

    Two possible fixes:

    1. Update the makefile recipe to always calculate and use package definition hashes, even when a cached .tar.gz is detected
    2. Neuter the CI cache restore logic to only restore exact cache matches (never fallback to “another hash”

    IMO it would be more useful to attempt 1. as we could restore an old hit, and then only rebuild changed packages. This also feels useful for developers locally?

  24. hebasto commented at 10:50 am on September 30, 2025: member

    Feedback from @luke-jr and @willcl-ark has been addressed.

    The PR description has been updated.

  25. luke-jr referenced this in commit 66ad7250ee on Sep 30, 2025
  26. luke-jr referenced this in commit 629ec2d731 on Sep 30, 2025
  27. m3dwards commented at 7:25 pm on September 30, 2025: contributor

    ACK 93a70a42d30fa2f9404b76d5bbdb5ea316fc1032

    Also checked archive contents are the same as OP:

     0Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.g0dIABqWhw/libqrencode-4.1.1: .github
 1Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.g0dIABqWhw/libqrencode-4.1.1: .gitignore
 2Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.g0dIABqWhw/libqrencode-4.1.1: .travis.yml
 3Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1: Makefile.in
 4Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1: README
 5Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.g0dIABqWhw/libqrencode-4.1.1: README.md
 6Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1: aclocal.m4
 7Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1: config.h.in
 8Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1: configure
 9Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.g0dIABqWhw/libqrencode-4.1.1: makeREADME.sh
10Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/tests: Makefile.in
11Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.g0dIABqWhw/libqrencode-4.1.1/tests: test_qrenc.sh
12Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: compile
13Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: config.guess
14Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: config.sub
15Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: depcomp
16Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: install-sh
17Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: ltmain.sh
18Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: missing
19Only in /var/folders/q9/65c9dvyj3lbdsv5zrhp_8qk80000gn/T/tmp.Svne8lCFDT/qrencode-4.1.1/use: test-driver

     0ff3ab842fd36d8c51e76fa87d80e460e3a26fca8641543f01be1b7b62eea99d8  guix-build-93a70a42d30f/output/aarch64-linux-gnu/SHA256SUMS.part
 1d8e022a8f8794df818cf682e75da7ca2f633e5954cd306cf14cd06f62bc3405d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu-debug.tar.gz
 2c7ade0382153220a35b2d59a04f4c6578e40957898c468e0040555c49508039d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu.tar.gz
 39855573d20deb3346937bb56a8b494ed367c5bb56b53ca457b3997c06118c3b8  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/SHA256SUMS.part
 437645ca723b121a6e10d51d00be0d20bb39e1aeeac88dcd183eaf354b3b0bf44  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf-debug.tar.gz
 5aeb643212e09e5e0fa3e35732ecac097ad2cb9b0f47365ce813ffeac1a04a2dc  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf.tar.gz
 6a7d8ba23a581c99efc7879dfb1e9a297be11bfd3f5591ea76bb5df4d4579356e  guix-build-93a70a42d30f/output/arm64-apple-darwin/SHA256SUMS.part
 7ae1b89bd8c10386d925ce049b9fb0c7678f164cdeb083b3829e70986c15a08d6  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-codesigning.tar.gz
 8dba540db96670e74a83d6ab3958b1bdb50722cba3c1062f462a40c031aa2dd88  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.tar.gz
 99709ebf4cfa017b51a6f9bd7b1cba0b869b69a3d3c9ea3559a83f4b2409ed5ef  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.zip
10dfdc1f25e2231702b591c9ae52b86023c942ccb660d059ed9db1b71f182e601e  guix-build-93a70a42d30f/output/dist-archive/bitcoin-93a70a42d30f.tar.gz
11a7e38f598992df0b8bd3ebb1199a412c3537a4552f788d69a7b12eefce124386  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/SHA256SUMS.part
12a61961871a1a66c0a895c4d88db7f48904aefca5a1f0d8d824456bd44894c870  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu-debug.tar.gz
13229212eeb5965c1e654c3750ad057644c7116b03d4d7632efa62d6947b58dc66  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu.tar.gz
14a1df64b48c5e28d69f27341039d33a33998315a0a921b79556d29925f52a4ead  guix-build-93a70a42d30f/output/riscv64-linux-gnu/SHA256SUMS.part
1565f8a7b4a04c2b179df92151b1ae3e96cd2b66ca0418a8718278647bafa11d91  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu-debug.tar.gz
16971c05d110febfe8ecfebef066cf2f86bc40ec4e96cef317f04f847803d04082  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu.tar.gz
17bfa7418c67a02ed744d22db867b15231369ed471b1a2b2b1d442491d352f68a2  guix-build-93a70a42d30f/output/x86_64-apple-darwin/SHA256SUMS.part
181471fcdaedc0ca978e22e48111fd8f3688d0ebb13ca681e0b4ee48334ff66262  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-codesigning.tar.gz
19aeb3f3bb1ac7b25a24445db7230892842c0f697910dfc5c0ba07cdca18f00f7d  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.tar.gz
2041621033e0249b25cf976189d9dee2c790b1c30a1f6e372887c41fbcc04a44da  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.zip
214b1399bfddfaa8db0cdcd30edaeab0f8580071f4cf370f630825e52048b35cc7  guix-build-93a70a42d30f/output/x86_64-linux-gnu/SHA256SUMS.part
22a687a433494cd31f1b1bec0427570154debf9664484e72d37c0ac39ef068af36  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu-debug.tar.gz
235baf6fa9cdd41cc4e07445b615085c4d7a86522be35e80efa5fa4a49557fe90a  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu.tar.gz
243308bda82c0064fb8a39819cf9e81008d22825936c0f5e39a483c166e76bded7  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/SHA256SUMS.part
2513313b0acd9c597bef8e9eefeeaeb99e90345f1b2e6a6a88dd8c5c61c4592c78  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-codesigning.tar.gz
26cb89ce2e732ac1b67c999176a599b3ab07e63bd3e878cfdf39d791cadd08c307  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-debug.zip
2777dff472f4e87eb31b82857315360c92692350235707587fcaf8ecbed56a0e6d  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-setup-unsigned.exe
283fc3e9ca55bc656418f8b81c128c2c4f10c01ae9ee4b0fda619a6f1e3fe42f41  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-unsigned.zip

    Correctly got failure when trying to fetch invalid URL twice

  28. DrahtBot requested review from vasild on Sep 30, 2025
  29. hebasto commented at 9:41 pm on October 1, 2025: member

    My Guix build:

     0aarch64
 1ff3ab842fd36d8c51e76fa87d80e460e3a26fca8641543f01be1b7b62eea99d8  guix-build-93a70a42d30f/output/aarch64-linux-gnu/SHA256SUMS.part
 2d8e022a8f8794df818cf682e75da7ca2f633e5954cd306cf14cd06f62bc3405d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu-debug.tar.gz
 3c7ade0382153220a35b2d59a04f4c6578e40957898c468e0040555c49508039d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu.tar.gz
 49855573d20deb3346937bb56a8b494ed367c5bb56b53ca457b3997c06118c3b8  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/SHA256SUMS.part
 537645ca723b121a6e10d51d00be0d20bb39e1aeeac88dcd183eaf354b3b0bf44  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf-debug.tar.gz
 6aeb643212e09e5e0fa3e35732ecac097ad2cb9b0f47365ce813ffeac1a04a2dc  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf.tar.gz
 7a7d8ba23a581c99efc7879dfb1e9a297be11bfd3f5591ea76bb5df4d4579356e  guix-build-93a70a42d30f/output/arm64-apple-darwin/SHA256SUMS.part
 8ae1b89bd8c10386d925ce049b9fb0c7678f164cdeb083b3829e70986c15a08d6  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-codesigning.tar.gz
 9dba540db96670e74a83d6ab3958b1bdb50722cba3c1062f462a40c031aa2dd88  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.tar.gz
109709ebf4cfa017b51a6f9bd7b1cba0b869b69a3d3c9ea3559a83f4b2409ed5ef  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.zip
11dfdc1f25e2231702b591c9ae52b86023c942ccb660d059ed9db1b71f182e601e  guix-build-93a70a42d30f/output/dist-archive/bitcoin-93a70a42d30f.tar.gz
12a7e38f598992df0b8bd3ebb1199a412c3537a4552f788d69a7b12eefce124386  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/SHA256SUMS.part
13a61961871a1a66c0a895c4d88db7f48904aefca5a1f0d8d824456bd44894c870  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu-debug.tar.gz
14229212eeb5965c1e654c3750ad057644c7116b03d4d7632efa62d6947b58dc66  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu.tar.gz
15a1df64b48c5e28d69f27341039d33a33998315a0a921b79556d29925f52a4ead  guix-build-93a70a42d30f/output/riscv64-linux-gnu/SHA256SUMS.part
1665f8a7b4a04c2b179df92151b1ae3e96cd2b66ca0418a8718278647bafa11d91  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu-debug.tar.gz
17971c05d110febfe8ecfebef066cf2f86bc40ec4e96cef317f04f847803d04082  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu.tar.gz
18bfa7418c67a02ed744d22db867b15231369ed471b1a2b2b1d442491d352f68a2  guix-build-93a70a42d30f/output/x86_64-apple-darwin/SHA256SUMS.part
191471fcdaedc0ca978e22e48111fd8f3688d0ebb13ca681e0b4ee48334ff66262  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-codesigning.tar.gz
20aeb3f3bb1ac7b25a24445db7230892842c0f697910dfc5c0ba07cdca18f00f7d  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.tar.gz
2141621033e0249b25cf976189d9dee2c790b1c30a1f6e372887c41fbcc04a44da  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.zip
224b1399bfddfaa8db0cdcd30edaeab0f8580071f4cf370f630825e52048b35cc7  guix-build-93a70a42d30f/output/x86_64-linux-gnu/SHA256SUMS.part
23a687a433494cd31f1b1bec0427570154debf9664484e72d37c0ac39ef068af36  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu-debug.tar.gz
245baf6fa9cdd41cc4e07445b615085c4d7a86522be35e80efa5fa4a49557fe90a  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu.tar.gz
253308bda82c0064fb8a39819cf9e81008d22825936c0f5e39a483c166e76bded7  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/SHA256SUMS.part
2613313b0acd9c597bef8e9eefeeaeb99e90345f1b2e6a6a88dd8c5c61c4592c78  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-codesigning.tar.gz
27cb89ce2e732ac1b67c999176a599b3ab07e63bd3e878cfdf39d791cadd08c307  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-debug.zip
2877dff472f4e87eb31b82857315360c92692350235707587fcaf8ecbed56a0e6d  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-setup-unsigned.exe
293fc3e9ca55bc656418f8b81c128c2c4f10c01ae9ee4b0fda619a6f1e3fe42f41  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-unsigned.zip
  30. vasild approved
  31. vasild commented at 9:55 am on October 3, 2025: contributor
    ACK 93a70a42d30fa2f9404b76d5bbdb5ea316fc1032
  32. janb84 commented at 11:11 am on October 4, 2025: contributor

    ACK 93a70a42d30fa2f9404b76d5bbdb5ea316fc1032

    PR Updates URL where the package can be downloaded for qrencode for depends. Because the package slightly differs from the original a new Hash has been added plus some changes to make sure the CI builds do not use the cache version.

    • Code review on the “added” shell scripts in the package to make sure that there has not been added some obvious malicious stuff. (yes package is from gh is from 2020 but still). ✅
    • code review ✅

    Host architecture: aarch64 Commit: 93a70a42d30f

     0 ff3ab842fd36d8c51e76fa87d80e460e3a26fca8641543f01be1b7b62eea99d8  guix-build-93a70a42d30f/output/aarch64-linux-gnu/SHA256SUMS.part
 1 d8e022a8f8794df818cf682e75da7ca2f633e5954cd306cf14cd06f62bc3405d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu-debug.tar.gz
 2 c7ade0382153220a35b2d59a04f4c6578e40957898c468e0040555c49508039d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu.tar.gz
 3 9855573d20deb3346937bb56a8b494ed367c5bb56b53ca457b3997c06118c3b8  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/SHA256SUMS.part
 4 37645ca723b121a6e10d51d00be0d20bb39e1aeeac88dcd183eaf354b3b0bf44  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf-debug.tar.gz
 5 aeb643212e09e5e0fa3e35732ecac097ad2cb9b0f47365ce813ffeac1a04a2dc  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf.tar.gz
 6 a7d8ba23a581c99efc7879dfb1e9a297be11bfd3f5591ea76bb5df4d4579356e  guix-build-93a70a42d30f/output/arm64-apple-darwin/SHA256SUMS.part
 7 ae1b89bd8c10386d925ce049b9fb0c7678f164cdeb083b3829e70986c15a08d6  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-codesigning.tar.gz
 8 dba540db96670e74a83d6ab3958b1bdb50722cba3c1062f462a40c031aa2dd88  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.tar.gz
 9 9709ebf4cfa017b51a6f9bd7b1cba0b869b69a3d3c9ea3559a83f4b2409ed5ef  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.zip
10 dfdc1f25e2231702b591c9ae52b86023c942ccb660d059ed9db1b71f182e601e  guix-build-93a70a42d30f/output/dist-archive/bitcoin-93a70a42d30f.tar.gz
11 a7e38f598992df0b8bd3ebb1199a412c3537a4552f788d69a7b12eefce124386  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/SHA256SUMS.part
12 a61961871a1a66c0a895c4d88db7f48904aefca5a1f0d8d824456bd44894c870  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu-debug.tar.gz
13 229212eeb5965c1e654c3750ad057644c7116b03d4d7632efa62d6947b58dc66  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu.tar.gz
14 a1df64b48c5e28d69f27341039d33a33998315a0a921b79556d29925f52a4ead  guix-build-93a70a42d30f/output/riscv64-linux-gnu/SHA256SUMS.part
15 65f8a7b4a04c2b179df92151b1ae3e96cd2b66ca0418a8718278647bafa11d91  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu-debug.tar.gz
16 971c05d110febfe8ecfebef066cf2f86bc40ec4e96cef317f04f847803d04082  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu.tar.gz
17 bfa7418c67a02ed744d22db867b15231369ed471b1a2b2b1d442491d352f68a2  guix-build-93a70a42d30f/output/x86_64-apple-darwin/SHA256SUMS.part
18 1471fcdaedc0ca978e22e48111fd8f3688d0ebb13ca681e0b4ee48334ff66262  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-codesigning.tar.gz
19 aeb3f3bb1ac7b25a24445db7230892842c0f697910dfc5c0ba07cdca18f00f7d  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.tar.gz
20 41621033e0249b25cf976189d9dee2c790b1c30a1f6e372887c41fbcc04a44da  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.zip
21 4b1399bfddfaa8db0cdcd30edaeab0f8580071f4cf370f630825e52048b35cc7  guix-build-93a70a42d30f/output/x86_64-linux-gnu/SHA256SUMS.part
22 a687a433494cd31f1b1bec0427570154debf9664484e72d37c0ac39ef068af36  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu-debug.tar.gz
23 5baf6fa9cdd41cc4e07445b615085c4d7a86522be35e80efa5fa4a49557fe90a  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu.tar.gz
24 3308bda82c0064fb8a39819cf9e81008d22825936c0f5e39a483c166e76bded7  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/SHA256SUMS.part
25 13313b0acd9c597bef8e9eefeeaeb99e90345f1b2e6a6a88dd8c5c61c4592c78  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-codesigning.tar.gz
26 cb89ce2e732ac1b67c999176a599b3ab07e63bd3e878cfdf39d791cadd08c307  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-debug.zip
27 77dff472f4e87eb31b82857315360c92692350235707587fcaf8ecbed56a0e6d  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-setup-unsigned.exe
28 3fc3e9ca55bc656418f8b81c128c2c4f10c01ae9ee4b0fda619a6f1e3fe42f41  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-unsigned.zip
  33. achow101 commented at 11:54 pm on October 7, 2025: member

    ACK 93a70a42d30fa2f9404b76d5bbdb5ea316fc1032

     0ff3ab842fd36d8c51e76fa87d80e460e3a26fca8641543f01be1b7b62eea99d8  guix-build-93a70a42d30f/output/aarch64-linux-gnu/SHA256SUMS.part
 1d8e022a8f8794df818cf682e75da7ca2f633e5954cd306cf14cd06f62bc3405d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu-debug.tar.gz
 2c7ade0382153220a35b2d59a04f4c6578e40957898c468e0040555c49508039d  guix-build-93a70a42d30f/output/aarch64-linux-gnu/bitcoin-93a70a42d30f-aarch64-linux-gnu.tar.gz
 39855573d20deb3346937bb56a8b494ed367c5bb56b53ca457b3997c06118c3b8  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/SHA256SUMS.part
 437645ca723b121a6e10d51d00be0d20bb39e1aeeac88dcd183eaf354b3b0bf44  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf-debug.tar.gz
 5aeb643212e09e5e0fa3e35732ecac097ad2cb9b0f47365ce813ffeac1a04a2dc  guix-build-93a70a42d30f/output/arm-linux-gnueabihf/bitcoin-93a70a42d30f-arm-linux-gnueabihf.tar.gz
 6a7d8ba23a581c99efc7879dfb1e9a297be11bfd3f5591ea76bb5df4d4579356e  guix-build-93a70a42d30f/output/arm64-apple-darwin/SHA256SUMS.part
 7ae1b89bd8c10386d925ce049b9fb0c7678f164cdeb083b3829e70986c15a08d6  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-codesigning.tar.gz
 8dba540db96670e74a83d6ab3958b1bdb50722cba3c1062f462a40c031aa2dd88  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.tar.gz
 99709ebf4cfa017b51a6f9bd7b1cba0b869b69a3d3c9ea3559a83f4b2409ed5ef  guix-build-93a70a42d30f/output/arm64-apple-darwin/bitcoin-93a70a42d30f-arm64-apple-darwin-unsigned.zip
10dfdc1f25e2231702b591c9ae52b86023c942ccb660d059ed9db1b71f182e601e  guix-build-93a70a42d30f/output/dist-archive/bitcoin-93a70a42d30f.tar.gz
11a7e38f598992df0b8bd3ebb1199a412c3537a4552f788d69a7b12eefce124386  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/SHA256SUMS.part
12a61961871a1a66c0a895c4d88db7f48904aefca5a1f0d8d824456bd44894c870  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu-debug.tar.gz
13229212eeb5965c1e654c3750ad057644c7116b03d4d7632efa62d6947b58dc66  guix-build-93a70a42d30f/output/powerpc64-linux-gnu/bitcoin-93a70a42d30f-powerpc64-linux-gnu.tar.gz
14a1df64b48c5e28d69f27341039d33a33998315a0a921b79556d29925f52a4ead  guix-build-93a70a42d30f/output/riscv64-linux-gnu/SHA256SUMS.part
1565f8a7b4a04c2b179df92151b1ae3e96cd2b66ca0418a8718278647bafa11d91  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu-debug.tar.gz
16971c05d110febfe8ecfebef066cf2f86bc40ec4e96cef317f04f847803d04082  guix-build-93a70a42d30f/output/riscv64-linux-gnu/bitcoin-93a70a42d30f-riscv64-linux-gnu.tar.gz
17bfa7418c67a02ed744d22db867b15231369ed471b1a2b2b1d442491d352f68a2  guix-build-93a70a42d30f/output/x86_64-apple-darwin/SHA256SUMS.part
181471fcdaedc0ca978e22e48111fd8f3688d0ebb13ca681e0b4ee48334ff66262  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-codesigning.tar.gz
19aeb3f3bb1ac7b25a24445db7230892842c0f697910dfc5c0ba07cdca18f00f7d  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.tar.gz
2041621033e0249b25cf976189d9dee2c790b1c30a1f6e372887c41fbcc04a44da  guix-build-93a70a42d30f/output/x86_64-apple-darwin/bitcoin-93a70a42d30f-x86_64-apple-darwin-unsigned.zip
214b1399bfddfaa8db0cdcd30edaeab0f8580071f4cf370f630825e52048b35cc7  guix-build-93a70a42d30f/output/x86_64-linux-gnu/SHA256SUMS.part
22a687a433494cd31f1b1bec0427570154debf9664484e72d37c0ac39ef068af36  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu-debug.tar.gz
235baf6fa9cdd41cc4e07445b615085c4d7a86522be35e80efa5fa4a49557fe90a  guix-build-93a70a42d30f/output/x86_64-linux-gnu/bitcoin-93a70a42d30f-x86_64-linux-gnu.tar.gz
243308bda82c0064fb8a39819cf9e81008d22825936c0f5e39a483c166e76bded7  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/SHA256SUMS.part
2513313b0acd9c597bef8e9eefeeaeb99e90345f1b2e6a6a88dd8c5c61c4592c78  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-codesigning.tar.gz
26cb89ce2e732ac1b67c999176a599b3ab07e63bd3e878cfdf39d791cadd08c307  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-debug.zip
2777dff472f4e87eb31b82857315360c92692350235707587fcaf8ecbed56a0e6d  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-setup-unsigned.exe
283fc3e9ca55bc656418f8b81c128c2c4f10c01ae9ee4b0fda619a6f1e3fe42f41  guix-build-93a70a42d30f/output/x86_64-w64-mingw32/bitcoin-93a70a42d30f-win64-unsigned.zip
  34. achow101 merged this on Oct 7, 2025
  35. achow101 closed this on Oct 7, 2025
  36. hebasto deleted the branch on Oct 8, 2025
  37. willcl-ark commented at 10:12 am on October 8, 2025: member

    Unfortunately this looks like it has inadvertently clobbered all non-master branches (e.g. https://github.com/bitcoin/bitcoin/actions/runs/18340048986/job/52233153574?pr=33559) which don’t have the required depends Makefile changes from the first 3 commits here.

    The issue is that when we load a depends cache (which will come from master) we now load the (new) qrencode package using filename only in the v30 branch (without the changes here), but the hash doesn’t match.

  38. fanquake commented at 10:33 am on October 8, 2025: member
    This change is causing the CI to fail on all the branches (#33559, #33551) we are about to cut releases from. I’d really prefer to not have to do another round of rcs, just to backport this.
  39. maflcko commented at 10:43 am on October 8, 2025: member

    Would it help to set a new filename for the cached file, like gh_$(package)-$($(package)_version).tar.gz?

    Edit: I guess this doesn’t ensure the file is cleared from the depends cache. So maybe:

    • Revert commit 93a70a42d30fa2f9404b76d5bbdb5ea316fc1032 temporarily for now
    • Merge the revert
    • Re-run CI on the old branches
    • Re-apply commit 93a70a42d30fa2f9404b76d5bbdb5ea316fc1032 in a pull to master and use a new cached file name, or backport the other commits here.
  40. willcl-ark commented at 10:47 am on October 8, 2025: member

    Other workarounds may include (from least to most hacky):

    • Revert this change on master and wait for a run to complete (and a new depends cache entry to be generated, to be picked up in 33559 and 33551)
    • Acquire ability to delete caches from Cirrus (I have emailed @fkorotkov to ask if he can help us with this), after which we could do “uncached runs” on those branches
  41. TheCharlatan referenced this in commit 5f9d179b8d on Oct 8, 2025
  42. TheCharlatan referenced this in commit 845b93d99e on Oct 8, 2025
  43. yuvicc referenced this in commit ccce70c31a on Oct 8, 2025
  44. fanquake commented at 6:18 pm on October 8, 2025: member

    It’s also been pointed out that this has also (effectively) broken the Guix build on the release branches. Prior to this change, any download of the qrencode tarball, was falling back to https://bitcoincore.org/depends-sources. However now that the tarball has been changed (and overwritten on the server), any build for a branch that doesn’t have these changes, when it falls back to the server for the download, will fail with a checksum mismatch.

    Meaning anyone that tries to do a from scratch guix build for 30.x or 29.x, now, will fail with a checksum mismatch:

     0time BASE_CACHE="/root/base_cache" SOURCES_PATH="/root/sources" SDK_PATH="/root/SDKs" ./contrib/guix/guix-build
 1Found macOS SDK at '/root/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers', using...
 2Checking that we can connect to the guix-daemon...
 3
 4Hint: If this hangs, you may want to try turning your guix-daemon off and on
 5      again.
 6
 7make: Entering directory '/root/bitcoin/depends'
 8Checksum missing or mismatched for qrencode source. Forcing re-download.
 9Fetching qrencode-4.1.1.tar.gz from https://fukuchi.org/works/qrencode/
10  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
11                                 Dload  Upload   Total   Spent    Left  Speed
12  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
13curl: (22) The requested URL returned error: 404
14Fetching qrencode-4.1.1.tar.gz from https://bitcoincore.org/depends-sources
15  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
16                                 Dload  Upload   Total   Spent    Left  Speed
17100  185k  100  185k    0     0  13498      0  0:00:14  0:00:14 --:--:-- 17027
18/root/bitcoin/depends/work/download/qrencode-4.1.1/qrencode-4.1.1.tar.gz.temp: FAILED
19sha256sum: WARNING: 1 computed checksum did NOT match
20make[1]: *** [funcs.mk:304: /root/sources/download-stamps/.stamp_fetched-qrencode-qrencode-4.1.1.tar.gz.hash] Error 1
21make: *** [Makefile:282: download-linux] Error 2
22make: Leaving directory '/root/bitcoin/depends'
  45. achow101 commented at 6:20 pm on October 8, 2025: member
    #33577 for the revert
  46. theuni commented at 7:23 pm on October 8, 2025: member

    I don’t understand how this was ever intended to work. A depends source has a single hash.. that’s pretty fundamental to the way it was designed. And a filename with a new hash is exactly the kind of thing it was intended to catch and disallow.

    The filename was changed upstream, and rightly so. Why did we not just adopt the new filename/hash and let that be the end of it?

    Edit: Or, to prettify the filename:

    0$(package)_download_file=v$($(package)_version).tar.gz
1$(package)_file_name=$(package)-$($(package)_version)-v2.tar.gz
  47. hebasto commented at 7:29 pm on October 8, 2025: member

    I don’t understand how this was ever intended to work. A depends source has a single hash.. that’s pretty fundamental to the way it was designed. And a filename with a new hash is exactly the kind of thing it was intended to catch and disallow.

    The filename was changed upstream, and rightly so. Why did we not just adopt the new filename/hash and let that be the end of it?

    That was the initial approach in https://github.com/bitcoin/bitcoin/commit/980e4987db0450cabb8761433001841f7e9f4c73.

  48. glozow commented at 3:10 pm on October 9, 2025: member

    It’s also been pointed out that this has also (effectively) broken the Guix build on the release branches.

    I’ve been testing for 29.2 and hitting this problem. After the old tarball was restored yesterday I was able to do a fresh guix build, but it’s now failing again (the fukuchi.org one doesn’t exist and the fallback depends-source has re-pulled the new tarball with a different hash, as described above).

     0Fetching qrencode-4.1.1.tar.gz from https://fukuchi.org/works/qrencode/
 1  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
 2                                 Dload  Upload   Total   Spent    Left  Speed
 3  0   274    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 4curl: (22) The requested URL returned error: 404
 5Fetching qrencode-4.1.1.tar.gz from https://bitcoincore.org/depends-sources
 6  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
 7                                 Dload  Upload   Total   Spent    Left  Speed
 8100  185k  100  185k    0     0   517k      0 --:--:-- --:--:-- --:--:--  517k
 9///bitcoin/depends/work/download/qrencode-4.1.1/qrencode-4.1.1.tar.gz.temp: FAILED
10sha256sum: WARNING: 1 computed checksum did NOT match
11make[1]: *** [funcs.mk:304: ////bitcoin/depends/sources/download-stamps/.stamp_fetched-qrencode-qrencode-4.1.1.tar.gz.hash] Error 1
12make: *** [Makefile:280: download-osx] Error 2

    I’m not familiar with how the CI caching works so I’m mostly just nagging, but could reviewers here take a look at #33577 so that the fallback depends-source can be fixed? Or if there is an alternate solution I can help review, please let me know.

    This issue is blocking v29.2 and v28.3 so I think it should be high priority.

  49. maflcko commented at 6:58 pm on October 9, 2025: member

    If someone wants to locally restore it manually, drahtbot happens to have the old version as well:

    0$ curl -LOf 'https://drahtbot.space/depends_download_fallback/qrencode-4.1.1.tar.gz'
1  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2                                 Dload  Upload   Total   Spent    Left  Speed
3100  530k  100  530k    0     0   363k      0  0:00:01  0:00:01 --:--:--  362k
4
5$ sha256sum ./qrencode-4.1.1.tar.gz 
6da448ed4f52aba6bcb0cd48cac0dd51b8692bccc4cd127431402fca6f8171e8e  ./qrencode-4.1.1.tar.gz
  50. glozow commented at 7:19 pm on October 9, 2025: member
    fwiw @achow101 has already done so
  51. glozow referenced this in commit cd1b7fa1ff on Oct 9, 2025


hebasto DrahtBot vasild maflcko m3dwards luke-jr willcl-ark janb84 achow101 fanquake theuni glozow

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-10 15:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me