guix: use LIEF 0.17.3 #33522

fanquake commented at 3:57 PM on October 2, 2025: member

Update LIEF in Guix & the CI to 0.17.3: https://lief.re/doc/stable/changelog.html#january-24th-2026

DrahtBot added the label Build system on Oct 2, 2025

DrahtBot commented at 3:58 PM on October 2, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33522.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

No conflicts as of last run.

fanquake added the label DrahtBot Guix build requested on Oct 3, 2025

janb84 commented at 11:36 AM on October 3, 2025: contributor

This works for my guix build

<details><summary>Guix Build Output</summary>

Host architecture: aarch64 Commit: 0123c5f56c20

 f83387eefc9384d17a6986dc5390f2f45cc30391af559dbb0dfa7975e3bab6c1  guix-build-0123c5f56c20/output/aarch64-linux-gnu/SHA256SUMS.part
 336c4f647e5318d34119580377f7bb957fe4cc2009160712f14b04f5d6876386  guix-build-0123c5f56c20/output/aarch64-linux-gnu/bitcoin-0123c5f56c20-aarch64-linux-gnu-debug.tar.gz
 8f6d8197eec76f8bf20ad936dde15e06cfa5b6911092637982ae9f8c5dd93730  guix-build-0123c5f56c20/output/aarch64-linux-gnu/bitcoin-0123c5f56c20-aarch64-linux-gnu.tar.gz
 5605c92e1346948f63ef0ecc09508b58ac89b57b661ff58aa0f6962817ab3e6d  guix-build-0123c5f56c20/output/arm-linux-gnueabihf/SHA256SUMS.part
 c86d9258a2519868899dbf75bbbc5d4336a12dadeed9f79e1948e8a0d6e68dcd  guix-build-0123c5f56c20/output/arm-linux-gnueabihf/bitcoin-0123c5f56c20-arm-linux-gnueabihf-debug.tar.gz
 2369b55f28fd3c9db990796c1540afd2acd3f5a157b12153bcc896432028b212  guix-build-0123c5f56c20/output/arm-linux-gnueabihf/bitcoin-0123c5f56c20-arm-linux-gnueabihf.tar.gz
 0a4de960ad114661bdc71faaacfc0e7bfb594465b5904c1ab4aba4354331776e  guix-build-0123c5f56c20/output/arm64-apple-darwin/SHA256SUMS.part
 76dabdc770be5ae0b75344202dd781c26cf9115ed4abc69abf816f31de10e593  guix-build-0123c5f56c20/output/arm64-apple-darwin/bitcoin-0123c5f56c20-arm64-apple-darwin-codesigning.tar.gz
 b0776606da2d4a75a6533709cfb1c23dc502cc90cf92763136284461816daeda  guix-build-0123c5f56c20/output/arm64-apple-darwin/bitcoin-0123c5f56c20-arm64-apple-darwin-unsigned.tar.gz
 a5530924ac5e25172fa55b4f2467d43d0fc5b84306eef29344817164ab759dc5  guix-build-0123c5f56c20/output/arm64-apple-darwin/bitcoin-0123c5f56c20-arm64-apple-darwin-unsigned.zip
 43bb29d4abaa8f167cbbebe10ed035f3aaf90438cfd177e581d17b4cb402e29f  guix-build-0123c5f56c20/output/dist-archive/bitcoin-0123c5f56c20.tar.gz
 6e1401fac4062a9ff90634fdbae0f895ee1f8f87a779122a1f4a079e59de8ef7  guix-build-0123c5f56c20/output/powerpc64-linux-gnu/SHA256SUMS.part
 d0a81e59ed9020075d530332c8ec274fd0c03dc5e0259b32c82ff69e989aef5c  guix-build-0123c5f56c20/output/powerpc64-linux-gnu/bitcoin-0123c5f56c20-powerpc64-linux-gnu-debug.tar.gz
 1524d9a971a039abcb23b4d85a6b2bf9156307825f7bf3d22ed974915d7c4a8a  guix-build-0123c5f56c20/output/powerpc64-linux-gnu/bitcoin-0123c5f56c20-powerpc64-linux-gnu.tar.gz
 e42a87d62ed0bd70e8349e2e393e49ef8482bd783899ce6e2bfd1d07f5b42ebf  guix-build-0123c5f56c20/output/riscv64-linux-gnu/SHA256SUMS.part
 265d2d38885a0e9f81843359cd20dd77f06fe0b1195ace26e5cc3e99e5f96d7b  guix-build-0123c5f56c20/output/riscv64-linux-gnu/bitcoin-0123c5f56c20-riscv64-linux-gnu-debug.tar.gz
 e521c214f294b48623eac64b2b741e0a8f0e13bad8427e4e7dfae6983763872d  guix-build-0123c5f56c20/output/riscv64-linux-gnu/bitcoin-0123c5f56c20-riscv64-linux-gnu.tar.gz
 ea2ef9859ef3f195ae75470e8dd891f92277efafce51b2fd39ac7f3394baf50a  guix-build-0123c5f56c20/output/x86_64-apple-darwin/SHA256SUMS.part
 2a5c3121570160c83c5d73278714b966cd5259bbb87e0202f11347b01757de4c  guix-build-0123c5f56c20/output/x86_64-apple-darwin/bitcoin-0123c5f56c20-x86_64-apple-darwin-codesigning.tar.gz
 dbff6ceb495f8a0d57e852036bb61dded7bf9923664b1947c4ca3e786b6bd655  guix-build-0123c5f56c20/output/x86_64-apple-darwin/bitcoin-0123c5f56c20-x86_64-apple-darwin-unsigned.tar.gz
 d607087f3a2dbe36e69e64389c1032fd848f1d78c90ee614c2fa18080edf1eda  guix-build-0123c5f56c20/output/x86_64-apple-darwin/bitcoin-0123c5f56c20-x86_64-apple-darwin-unsigned.zip
 1a9eb49e09ff105f8aeb5d660aa7e93585c305527ffc382bc5a5820a02c80e4b  guix-build-0123c5f56c20/output/x86_64-linux-gnu/SHA256SUMS.part
 2e75b3573fb0e3f93a972fc62ac2a8e783aeee3ab0358f63abd371280b180be1  guix-build-0123c5f56c20/output/x86_64-linux-gnu/bitcoin-0123c5f56c20-x86_64-linux-gnu-debug.tar.gz
 cd5dce2de56f9739019d04ff2361c3fc52ddd2ca13f020cc50e23fcc7b3ebe92  guix-build-0123c5f56c20/output/x86_64-linux-gnu/bitcoin-0123c5f56c20-x86_64-linux-gnu.tar.gz
 a47d2033156be5ff1e1aeba1406685a2f82ea5b10ea085e66667ac7db5e87a0a  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/SHA256SUMS.part
 851a7e608507c5c0db7d9d9a7189aae62624eb7e65c3b0de60cccdbe1e422a40  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-codesigning.tar.gz
 e0e922ac6f6d62e9622e2e8241d487c370e3587177dbfa442e8231075c66659d  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-debug.zip
 eaadc3fafd5fee285063ec7ef2eb35acdef51c5340120cf05909b1339829b59b  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-setup-unsigned.exe
 015914432fbafda4852591948fc08a018aebcd81c7f01325128b7adeaad6956b  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-unsigned.zip

</details>

hebasto commented at 1:11 PM on October 3, 2025: member

If no bugs are fixed and no new features are needed, perhaps we should do the opposite and wait until the Guix commit used for release builds is updated to include 0.16.6 as a package?

DrahtBot commented at 2:32 PM on October 4, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 1ed00a0d39d5190d8ad88a0dd705a09b56d987aa<br>(master)	commit 618d962b66afb9d4965d5b2585656bcd57f0fb30<br>(pull/33522/merge)
*-aarch64-linux-gnu-debug.tar.gz	`f652d2b4a99c10fb...`	`92e2aa3c5c718127...`
*-aarch64-linux-gnu.tar.gz	`7253b1b45c4bf927...`	`819cb2e6f9d680f4...`
*-arm-linux-gnueabihf-debug.tar.gz	`b08d65cf393432fb...`	`77bdf855b8dacf39...`
*-arm-linux-gnueabihf.tar.gz	`cfa2f37406a6c21b...`	`5a86f7a1cde00caf...`
*-arm64-apple-darwin-codesigning.tar.gz	`b6c460fff7359f92...`	`e322123457d87064...`
*-arm64-apple-darwin-unsigned.tar.gz	`fa81438a0c0cabc7...`	`b09553d0160e6cc9...`
*-arm64-apple-darwin-unsigned.zip	`97cc6c32dbf0c773...`	`7d8de19798e8879a...`
*-powerpc64-linux-gnu-debug.tar.gz	`e16d19a46cb63056...`	`995ac7709d4523dc...`
*-powerpc64-linux-gnu.tar.gz	`2e3ed0f5ab2668ae...`	`b15d591236fd4dde...`
*-riscv64-linux-gnu-debug.tar.gz	`3d7ff75c715f9615...`	`53e0f598bf4a004f...`
*-riscv64-linux-gnu.tar.gz	`f62f501d74e3c1a7...`	`b3626eb225b7b371...`
*-x86_64-apple-darwin-codesigning.tar.gz	`aa36886ca35c784d...`	`04674cda6d163c64...`
*-x86_64-apple-darwin-unsigned.tar.gz	`5f45d902ade8dc16...`	`e41eb24f91076221...`
*-x86_64-apple-darwin-unsigned.zip	`440b818e04a2473f...`	`01c3cfbcfc7e3331...`
*-x86_64-linux-gnu-debug.tar.gz	`f985717d80ea092f...`	`88b9b4ba2fae0955...`
*-x86_64-linux-gnu.tar.gz	`dd12f58006398e14...`	`f59541d57cdcd38c...`
*.tar.gz	`8b784dc973055ded...`	`8f88f881fcb8e471...`
SHA256SUMS.part	`81b44c26d551a6b9...`	`48d0718c003c3a27...`
guix_build.log	`fb9c62457b4c62fd...`	`3095d0700ccb5de3...`
guix_build.log.diff		`4d264aa5b71bf334...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 4, 2025

fanquake renamed this:
~~guix: use LIEF 0.17.0~~
guix: use LIEF 0.17.1
on Oct 28, 2025

fanquake force-pushed on Oct 28, 2025

fanquake force-pushed on Dec 8, 2025

DrahtBot added the label CI failed on Dec 8, 2025

DrahtBot removed the label CI failed on Dec 8, 2025

DrahtBot added the label Needs rebase on Dec 17, 2025

fanquake force-pushed on Dec 18, 2025

DrahtBot removed the label Needs rebase on Dec 18, 2025

fanquake force-pushed on Jan 14, 2026

fanquake force-pushed on Jan 26, 2026

fanquake renamed this:
~~guix: use LIEF 0.17.1~~
guix: use LIEF 0.17.3
on Feb 2, 2026

fanquake commented at 6:46 PM on February 2, 2026: member

I've updated this to 0.17.3, and added a (symbol-check related) commit from #25573 that'd be nice to land.

fanquake marked this as ready for review on Feb 2, 2026

ci: use LIEF 0.17.3 in lint job a0467b9cb2

guix: use LIEF 0.17.3 68c4c9cfd0

guix: check for fortified functions in all symbols

-static-pie bins will not have any imported functions.

3027677aa8

fanquake force-pushed on Feb 3, 2026

fanquake commented at 1:43 PM on February 3, 2026: member

Guix Build (x86_64):

af84cc14431487c155513b7766b46e59d3b14e566c418aabeeaa77e1895372d1  guix-build-3027677aa81c/output/aarch64-linux-gnu/SHA256SUMS.part
bf01e9b19b5ae2ab171551485bdba53e4aceecdd20f3ca3b675c6e4533985259  guix-build-3027677aa81c/output/aarch64-linux-gnu/bitcoin-3027677aa81c-aarch64-linux-gnu-debug.tar.gz
392402661de3be96815b57623891447ceea8be76c0c3519a4cd94ee6d0e4006e  guix-build-3027677aa81c/output/aarch64-linux-gnu/bitcoin-3027677aa81c-aarch64-linux-gnu.tar.gz
a74ef2fdc36b08fbc177c220cfa014a5e55ba91da99e22a126b4c78e6c04782f  guix-build-3027677aa81c/output/arm-linux-gnueabihf/SHA256SUMS.part
f0e81eb8957dbecf0299b20a4e310f3d4e70cfd8f124db52af1643799661798c  guix-build-3027677aa81c/output/arm-linux-gnueabihf/bitcoin-3027677aa81c-arm-linux-gnueabihf-debug.tar.gz
f76a4bfa9f580b0315eae0529746bbfba5ae8ea1b5a39d652cbe29f7cf2cd04f  guix-build-3027677aa81c/output/arm-linux-gnueabihf/bitcoin-3027677aa81c-arm-linux-gnueabihf.tar.gz
88c924a17acd02486bfe19e5af7dc8f94c11b36ce23db2f1dcfbeec063f30b60  guix-build-3027677aa81c/output/arm64-apple-darwin/SHA256SUMS.part
2f848e477ab7e0d9990ee41bb9b7205e91e079b4f639a3742aac62f9592799af  guix-build-3027677aa81c/output/arm64-apple-darwin/bitcoin-3027677aa81c-arm64-apple-darwin-codesigning.tar.gz
94ca3b70fa5fa87a6dd7b74dc30ebc058eae6d9aafa961b45005f27635f81f8a  guix-build-3027677aa81c/output/arm64-apple-darwin/bitcoin-3027677aa81c-arm64-apple-darwin-unsigned.tar.gz
a385983359e3216639562eb4efd4d7663db20e41c9818691fdc09bcfa3285f89  guix-build-3027677aa81c/output/arm64-apple-darwin/bitcoin-3027677aa81c-arm64-apple-darwin-unsigned.zip
281139ede1c470abb422dd70fe9d690cd53f04eeab61720d2948a62c9422d1f4  guix-build-3027677aa81c/output/dist-archive/bitcoin-3027677aa81c.tar.gz
1e98140f1e62262ef8e0026907de9faff954197f8bd6121a7916387e1903d79b  guix-build-3027677aa81c/output/powerpc64-linux-gnu/SHA256SUMS.part
4db8403dfddb4379227ae55acf3a572fed8d4c202a092ecbdd8eebdda3098704  guix-build-3027677aa81c/output/powerpc64-linux-gnu/bitcoin-3027677aa81c-powerpc64-linux-gnu-debug.tar.gz
1af94554f17410004ab258f57f2b673986ed2caec8eb1866c53c2dc94abc0dd7  guix-build-3027677aa81c/output/powerpc64-linux-gnu/bitcoin-3027677aa81c-powerpc64-linux-gnu.tar.gz
b7b5bf96dfdf8f2deebfd37ecdb8f346fa1d951d5e0241d288bc88c47a2deeb2  guix-build-3027677aa81c/output/riscv64-linux-gnu/SHA256SUMS.part
febb8b633ea397b983643b1ee17594ab02510e36f08bd79228bf97b91010c2d7  guix-build-3027677aa81c/output/riscv64-linux-gnu/bitcoin-3027677aa81c-riscv64-linux-gnu-debug.tar.gz
3736427a0d1072c5d78c24e0c4e62ee67a8bd292caa5723cb47cc6447714bf24  guix-build-3027677aa81c/output/riscv64-linux-gnu/bitcoin-3027677aa81c-riscv64-linux-gnu.tar.gz
4aa7530ab74234555d5cbdd82ac7bb1b35487b8afce3512ac67f1d5322d3d375  guix-build-3027677aa81c/output/x86_64-apple-darwin/SHA256SUMS.part
d30aeb44e3369b8f6f7edc7668e2383edb5b028a98e9977709babd36b92895ff  guix-build-3027677aa81c/output/x86_64-apple-darwin/bitcoin-3027677aa81c-x86_64-apple-darwin-codesigning.tar.gz
66b726aaae2fa77d4d7d4b601567d59e73044bcf042db436ba968123eb381143  guix-build-3027677aa81c/output/x86_64-apple-darwin/bitcoin-3027677aa81c-x86_64-apple-darwin-unsigned.tar.gz
107b5bff467a9366bff20fb658f06b926844005f7cef58af6142f3063e77e418  guix-build-3027677aa81c/output/x86_64-apple-darwin/bitcoin-3027677aa81c-x86_64-apple-darwin-unsigned.zip
52582422722428bbda231bfea2dca6d2aff2957b0d0210cc2238311d61c0dee0  guix-build-3027677aa81c/output/x86_64-linux-gnu/SHA256SUMS.part
6a789aa5a6025380b73a97117f39b7840cb0a065686eb5b1fa6d22534f3e8d5e  guix-build-3027677aa81c/output/x86_64-linux-gnu/bitcoin-3027677aa81c-x86_64-linux-gnu-debug.tar.gz
f1881d815f91af6aebb7e024b266e1671768a57e2f0b37c7ded0233509cc37b6  guix-build-3027677aa81c/output/x86_64-linux-gnu/bitcoin-3027677aa81c-x86_64-linux-gnu.tar.gz
7d2e113accc5164403ddc5e2e2fb7d34a575230dfc3ef6e9425740b7c283fc84  guix-build-3027677aa81c/output/x86_64-w64-mingw32/SHA256SUMS.part
5f48aa406ed17151144a7229751cd7cbd6202d3acbe21e213285740529171749  guix-build-3027677aa81c/output/x86_64-w64-mingw32/bitcoin-3027677aa81c-win64-codesigning.tar.gz
047786c5453982b053d5805093695a9c976b5a6835456a65269d00b9ebf33331  guix-build-3027677aa81c/output/x86_64-w64-mingw32/bitcoin-3027677aa81c-win64-debug.zip
04c484324a2328763ae617262e69711f19098527a6b5ed58f331a445b0851d7b  guix-build-3027677aa81c/output/x86_64-w64-mingw32/bitcoin-3027677aa81c-win64-setup-unsigned.exe
eea4404b6020e988e7de9b8c34ecff7065e78c9df5c7ddd50789f61e78bd2aa7  guix-build-3027677aa81c/output/x86_64-w64-mingw32/bitcoin-3027677aa81c-win64-unsigned.zip

fanquake commented at 5:22 PM on February 10, 2026: member

Rolled into #34550.

fanquake closed this on Feb 10, 2026

fanquake deleted the branch on Feb 10, 2026