Cross compiling to Intel macOS seems fine, but it would be good to cross compile to arm64-apple-darwin as well.
Further reading:
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33549.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | Sjors |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
The title is a bit confusing: “Use ARM instead of Intel in macOS cross task”
Maybe say “Build for” instead of “use”, since the job uses Ubuntu to build.
It might be better to test cross compilation for both x86 and arm, though if that takes too much CI resources then arm is probably the more important target.
Briefly running the cross-compiled x86 binary on a native x86 CI machine would be useful, but it looks like Rosetta is the best we’ll get from Github.
It might be better to test cross compilation for both x86 and arm, though if that takes too much CI resources then arm is probably the more important target.
Briefly running the cross-compiled x86 binary on a native x86 CI machine would be useful, but it looks like Rosetta is the best we’ll get from Github.
Happy to add this to my nightly CI repo, but it doesn’t seem like a good use of CI resources here. Though, best I can do is the Rosetta 2 from GitHub.
but it doesn’t seem like a good use of CI resources here.
Having at least compilation coverage of every target we are shipping a release binary for seems like something we should have? Post switchover we are much less constrained on the CI resources front.
This refactor does not change behavior, but allows the step to be
re-used in other tasks, such as a mac-test-cross task
Having at least compilation coverage of every target we are shipping a release binary for seems like something we should have? Post switchover we are much less constrained on the CI resources front.
Thx, done. Also, agree that cross-compilation is cheap and fast.
utACK fad5a7101cc3dccbb525cfe9afc105aace8da88e
CI log suggests it worked.