DRAFT: add a freebsd job using systemlibs

willcl-ark commented at 11:35 am on October 7, 2025: member

Test a basic freebsd job in this repo using cirrus runners to get some info on how long a run will take on Cirrus Runners.

A run on GHA (free) runners is clocking in at around 50 - 60 minutes: https://github.com/willcl-ark/bitcoin/actions/runs/18309856374/job/52135663056

This will need permitting of the vmactions/freebsd-vm@v1 action in this repo. This action seems well-maintained/used, including by rustup, python psutil and a few other notable repos.

This job could alternatively be run as a nightly job (but in this repo, rather than elsewhere), but that does not seem to address:

BSDs are being tested in nightly repos, but merging code here, just to have it reported as broken after the fact, which then requires more changes to fix, isn’t ideal. Issues should be caught in this repo, before merging.

Inspiration taken from https://github.com/hebasto/bitcoin-core-nightly/blob/main/.github/workflows/freebsd.yml

DrahtBot commented at 11:35 am on October 7, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33562.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#bitcoin-core/gui/896 (rpcconsole: display signet challenge by RandyMcMillan)
#33620 (ci: Build ci_native_base image layer by maflcko)
#33549 (ci: Add macOS cross task for arm64-apple-darwin by maflcko)
#33514 (Clear out space on GHA jobs by willcl-ark)
#33480 (ci: Turn CentOS config into Alpine musl config by maflcko)
#33461 (ci: add Valgrind fuzz by fanquake)
#33411 (ci: re-add Valgrind job to the CI by fanquake)
#33142 (test: Run bench sanity checks in parallel with functional tests by maflcko)
#31507 (build: Use clang-cl to build on Windows natively by hebasto)
#31425 (RFC: Riscv bare metal CI job by TheCharlatan)
#31410 (qa: Fix wallet_multiwallet.py by hebasto)
#30595 (kernel: Introduce C header API by TheCharlatan)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Needs rebase on Oct 8, 2025

willcl-ark force-pushed on Oct 8, 2025

in .github/workflows/ci.yml:490 in dd7001ca27 outdated

485+      - name: Generate buildsystem
486+        env:
487+          CMAKE_GENERATOR: 'Ninja'
488+        run: |
489+          cd ${{ github.workspace }}
490+          cmake -B build -DWITH_ZMQ=ON -DBUILD_BENCH=ON -DWERROR=ON -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache

maflcko commented at 9:10 am on October 8, 2025:

no strong opinion, but is there a rationale about the scope here? why disable the fuzz binary?

willcl-ark commented at 9:16 am on October 8, 2025:

No opinion from me either, this is just a tranlation mistake from https://github.com/hebasto/bitcoin-core-nightly/blob/36cc3ef2703d6f662e9a96c21db5d83d80e7efb9/.github/workflows/freebsd.yml#L58 where it is indeed enabled.

I will re-enable it in next push.

DrahtBot removed the label Needs rebase on Oct 8, 2025

DrahtBot added the label Needs rebase on Oct 9, 2025

ci: add freebsd systemlibs job 636687583c

NOMERGE: disable a few tests b749876a55

NOMERGE: freebsd, save a cache dadceeb3df

willcl-ark force-pushed on Oct 10, 2025

DrahtBot removed the label Needs rebase on Oct 10, 2025

hebasto commented at 12:46 pm on October 10, 2025: member

This will need permitting of the vmactions/freebsd-vm@v1 action in this repo.

A few comments for historical context:

#30164 (comment):

Not sure. What was the conclusion when GHA was added to the repo about enabling third party actions? IIRC it was unclear whether malicious or backdoored actions could compromise the repo, so the conclusion was to refrain from enabling them?

No objection to merging this, but I’d say unless it is clear that the repo can not be compromised, the action should not be enabled in this repo.

#30164 (comment):

Albeit this seems fine (https://github.com/bitcoin/bitcoin/pull/30164#issuecomment-2130109577), I think adding third-party actions should be limited as well.

The third-party action has limited usage and exposure, so it may break from down under us, marking all CI runs red.

And just recently, bitcoin/bitcoin#32513 has resolved #32508.

maflcko commented at 1:57 pm on October 10, 2025: member

Yeah, this would be adding FreeBSD to add coverage for a single short-term compile time issue encountered there. Though, we’d still be missing OpenBSD/NetBSD coverage for stuff that is different on those platforms: #33128 (which seems like a long-standing issue that has existed since ever and no one bothered to report?)

DrahtBot added the label Needs rebase on Oct 15, 2025

DrahtBot commented at 11:53 am on October 15, 2025: contributor

🐙 This pull request conflicts with the target branch and needs rebase.

DRAFT: add a freebsd job using systemlibs #33562

Code Coverage & Benchmarks

Reviews

Conflicts