contrib: remove deprecated –deep signing from macdeployqtplus #33592

pull amishhaa wants to merge 1 commits into bitcoin:master from amishhaa:fix-deep-arg changing 1 files +50 −1
  1. amishhaa commented at 9:11 pm on October 9, 2025: contributor

    Description Removed the deprecated –deep flag from codesign in macdeployqtplus and replaced it with an explicit recursive signing process for all binaries, frameworks, and plugins. Fixes #32486

    Steps To Reproduce N/A since not a bug only deprecating an arg

    Steps To Test

    • Set up the app normally.
    • Signing would be logged
  2. Contrib: Updated macdeployqtplus to remove deprecated --deep signing
    Removed the deprecated --deep flag from codesign in macdeployqtplus and replaced it with an explicit recrusive signing process for all binaries, frameworks, and plugins.
    3ef0103393
  3. DrahtBot added the label Scripts and tools on Oct 9, 2025
  4. DrahtBot commented at 9:11 pm on October 9, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33592.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. hebasto commented at 7:26 am on October 10, 2025: member
    Concept ACK.
  6. fanquake renamed this:
    Contrib: Updated macdeployqtplus to remove deprecated --deep signing
    contrib: remove deprecated --deep signing from macdeployqtplus
    on Oct 10, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-31 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me