test: Use unassigned p2p_port instead of hardcoded 60000 in p2p_i2p_ports.py #33670

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2510-test-i2p-proxy changing 1 files +6 −5
  1. maflcko commented at 4:32 PM on October 21, 2025: member

    The goal is to fix #30030.

    The root cause it unclear. However, hard-coding the port to 60000 does not seem ideal anyway. This could break in an unlikely setting where so many functional tests are run, such that the port is occupied. Also, it could fail when TEST_RUNNER_PORT_MIN is set sufficiently high. (This is purely theoretical, as I don't think anyone would run a command like this, but on current master it fails, and on this pull it passes: TEST_RUNNER_PORT_MIN=60000 ./bld-cmake/test/functional/p2p_i2p_ports.py --portseed=0)

    So fix those issues (and hopefully also 30030) by using an unoccupied p2p_port.

    The logic is similar to the extra_port() logic in the feature_bind_extra.py test.

  2. test: Use unassigned p2p_port instead of hardcoded 60000 in p2p_i2p_ports.py fa20275db3
  3. DrahtBot added the label Tests on Oct 21, 2025
  4. DrahtBot commented at 4:32 PM on October 21, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33670.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK laanwj, mzumsande

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. laanwj commented at 6:45 AM on October 22, 2025: member

    Code review ACK fa20275db32c5b9b0fe35effe2d1cf3d958e7310

  6. mzumsande commented at 7:48 AM on October 22, 2025: contributor

    ACK fa20275db32c5b9b0fe35effe2d1cf3d958e7310

    LGTM, I also took a look recently trying to find the root cause but didn't come up with a better idea than just changing the port and hoping for the best.

  7. fanquake merged this on Oct 22, 2025
  8. fanquake closed this on Oct 22, 2025

  9. maflcko deleted the branch on Oct 22, 2025
  10. sedited referenced this in commit f50d90fcbb on Oct 29, 2025
  11. stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
  12. stringintech referenced this in commit b82132c4d1 on Nov 6, 2025
  13. yuvicc referenced this in commit f620a2206b on Nov 16, 2025
  14. Kino1994 referenced this in commit c4dfd01a2b on Jun 28, 2026
  15. BigcoinBGC referenced this in commit 092b649547 on Jun 30, 2026
  16. Kino1994 referenced this in commit 22243b3004 on Aug 19, 2026
  17. bitcoin locked this on Oct 22, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-29 06:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me