test: Update BIP324 test vectors #33688

1. 
   real-or-random commented at 12:32 pm on October 23, 2025: contributor

   This updates the hardcoded test vectors from BIP324. The test vectors had to be regenerated (in the aux files of the BIP) because there was a bug in the script used for generating them (https://github.com/bitcoin/bips/pull/2016).
2. test: Update BIP324 test vectors

   based on https://github.com/bitcoin/bips/pull/2016

   51877f2fc5
3. DrahtBot added the label Tests on Oct 23, 2025
4. 
   DrahtBot commented at 12:32 pm on October 23, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33688.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	jonatack, theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   spboy777 commented at 8:21 pm on October 23, 2025: none

   1
6. 
   real-or-random commented at 5:11 pm on October 24, 2025: contributor

   Ready for review.

   I think what is necessary to review this PR is to run the Python script in the code comment on the updated packet_encoding_test_vectors.csv file from the BIP and check that its output matches the changes here.

   https://github.com/bitcoin/bitcoin/blob/f6ba97cea1d36683fa8c1ebde78af3772d00ec12/src/test/bip324_tests.cpp#L171-L195

7. real-or-random marked this as ready for review on Oct 24, 2025
8. 
   jonatack commented at 5:44 pm on October 24, 2025: member

   ACK 51877f2fc5eb02b4229258b4b43731c4da843793

   This is a draft because https://github.com/bitcoin/bips/pull/2016 has not been merged.

   Can now remove from the PR description.

9. 
   AndricoSean commented at 11:31 pm on October 24, 2025: none

   lgtm
10. theStack approved
11. 
    theStack commented at 8:40 am on October 27, 2025: contributor

    ACK 51877f2fc5eb02b4229258b4b43731c4da843793
12. fanquake merged this on Oct 27, 2025
13. fanquake closed this on Oct 27, 2025

    ---

Contributors
real-or-random DrahtBot spboy777 jonatack AndricoSean theStack

Labels
Tests