This updates the hardcoded test vectors from BIP324. The test vectors had to be regenerated (in the aux files of the BIP) because there was a bug in the script used for generating them (https://github.com/bitcoin/bips/pull/2016).
test: Update BIP324 test vectors #33688
pull real-or-random wants to merge 1 commits into bitcoin:master from real-or-random:202510-bip324-vectors changing 1 files +36 −36-
real-or-random commented at 12:32 PM on October 23, 2025: contributor
-
51877f2fc5
test: Update BIP324 test vectors
based on https://github.com/bitcoin/bips/pull/2016
- DrahtBot added the label Tests on Oct 23, 2025
-
DrahtBot commented at 12:32 PM on October 23, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33688.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
spboy777 commented at 8:21 PM on October 23, 2025: none
1
-
real-or-random commented at 5:11 PM on October 24, 2025: contributor
Ready for review.
I think what is necessary to review this PR is to run the Python script in the code comment on the updated
packet_encoding_test_vectors.csvfile from the BIP and check that its output matches the changes here. - real-or-random marked this as ready for review on Oct 24, 2025
-
jonatack commented at 5:44 PM on October 24, 2025: member
ACK 51877f2fc5eb02b4229258b4b43731c4da843793
This is a draft because https://github.com/bitcoin/bips/pull/2016 has not been merged.
Can now remove from the PR description.
-
AndricoSean commented at 11:31 PM on October 24, 2025: none
lgtm
- theStack approved
-
theStack commented at 8:40 AM on October 27, 2025: contributor
ACK 51877f2fc5eb02b4229258b4b43731c4da843793
- fanquake merged this on Oct 27, 2025
- fanquake closed this on Oct 27, 2025
Labels