Datacarrier backwards compatibility and improved test coverage #33690

1. 
   jotapea commented at 3:36 pm on October 23, 2025: none

   This PR addresses the “misalignments” of #33682.

   Summing up: The change which was brought with v30 was broadly discussed and deliberately chosen. I think that reverting the defaults now would be a bad idea. And even if, the path to do this should not be this PR and changing defaults should not be bundled with introducing a new knob. @cedwies, this new PR keeps v30 defaults AND also removes the “public knob”. It must definitely keep the new count default constant, as that is the main new concept introduced. Specifically for:

   1. Custom client’s policy, including ones that wish full pre-v30 policy compatibility
   2. More exhaustive testing
   3. Consistency and specificity @achow101, this new PR should not be “re-litigating” anything, but if there is, I’ll be glad to discover how.

   Constructive feedback is welcomed.

2. Fix datacarrier policy backwards compatibility improving test coverage 019ad7be4f
3. DrahtBot added the label Backport on Oct 23, 2025
4. 
   DrahtBot commented at 3:36 pm on October 23, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33690.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • “whose any data-carrying raw scriptPubKey output is of this size or less.” -> “where any data-carrying raw scriptPubKey output is this size or less” [“whose any” is ungrammatical; use “where any” (or “for which any”) to make the clause grammatical and clear]

   drahtbot_id_5_m

5. fanquake closed this on Oct 23, 2025

   ---

6. 
   jotapea commented at 10:56 pm on October 23, 2025: none

   @fanquake Why are you closing this PR without any comment?
7. 
   00w1 commented at 4:29 am on October 24, 2025: none

   @jotapea Some users might be interested in this patch and #33682. I would suggest that you share the links along with a summary on delvingbitcoin, mailing list, bitcointalk and stacker.news. They would be a better place to look for constructive feedback.

   You can also add that v30 relase notes are misleading: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-30.0.md#policy

   It can be overridden with -datacarriersize=83 to revert to the limit enforced in previous versions. (#32406)

8. 
   jotapea commented at 5:10 am on October 24, 2025: none

   @00w1 Replied on X. I have no account on the other suggestions, would greatly appreciate if you can help spread the word.

   I am enjoying getting involved and learning the codebase, so I see no issue at all in maintaining these patches.

Contributors
jotapea DrahtBot 00w1

Labels
Backport