ci: use pycapnp 2.2.1 #33693
pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:pycapnp_2_2_0 changing 3 files +3 −10-
fanquake commented at 2:40 am on October 24, 2025: memberSwitch to using v2.2.1 in the mac native job. Remove the git clone & install step.
-
DrahtBot added the label Tests on Oct 24, 2025
-
DrahtBot commented at 2:40 am on October 24, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33693.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
maflcko commented at 7:37 am on October 24, 2025: member
unrelated nit: I think you can also remove this comment:
0# Homebrew's python@3.12 is marked as externally managed (PEP 668). 1# Therefore, `--break-system-packages` is needed.Since, homebrew has updated the python version number, and the comment isn’t added to any of the other
--break-system-packagesoptions where set. -
fanquake commented at 7:44 am on October 24, 2025: member
I think you can also remove this comment:
Added a removal.
-
maflcko commented at 7:49 am on October 24, 2025: memberlgtm ACK 8088643a616355b941fabbd584013c5969c0d1dc
-
hebasto commented at 11:36 am on October 25, 2025: member
The following diff also seems to work, unless I’ve missed minor issues or pitfalls already discussed in in #33201:
0diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml 1index a05e8f9648..1c69cc5437 100644 2--- a/.github/workflows/ci.yml 3+++ b/.github/workflows/ci.yml 4@@ -157,11 +157,6 @@ jobs: 5 brew install --quiet python@3 || brew link --overwrite python@3 6 brew install --quiet coreutils ninja pkgconf gnu-getopt ccache boost libevent zeromq qt@6 qrencode capnp 7 8- - name: Install Python packages 9- run: | 10- git clone -b v2.1.0 https://github.com/capnproto/pycapnp 11- pip3 install ./pycapnp -C force-bundled-libcapnp=True --break-system-packages 12- 13 - name: Set Ccache directory 14 run: echo "CCACHE_DIR=${RUNNER_TEMP}/ccache_dir" >> "$GITHUB_ENV" 15 16diff --git a/ci/test/00_setup_env_mac_native.sh b/ci/test/00_setup_env_mac_native.sh 17index 41a3bc4587..3cab6555b0 100755 18--- a/ci/test/00_setup_env_mac_native.sh 19+++ b/ci/test/00_setup_env_mac_native.sh 20@@ -9,7 +9,7 @@ export LC_ALL=C.UTF-8 21 # Homebrew's python@3.12 is marked as externally managed (PEP 668). 22 # Therefore, `--break-system-packages` is needed. 23 export CONTAINER_NAME="ci_mac_native" # macos does not use a container, but the env var is needed for logging 24-export PIP_PACKAGES="--break-system-packages zmq" 25+export PIP_PACKAGES="--break-system-packages zmq pycapnp" 26 export GOAL="install deploy" 27 export CMAKE_GENERATOR="Ninja" 28 export BITCOIN_CONFIG="-DBUILD_GUI=ON -DWITH_ZMQ=ON -DREDUCE_EXPORTS=ON -DCMAKE_EXE_LINKER_FLAGS='-Wl,-stack_size -Wl,0x80000'" -
ci: remove Python version comment from mac config 865432869c
-
53b34c80c6
ci: use pycapnp 2.2.1 in mac native job
Drop using the git clone & install.
-
fanquake force-pushed on Oct 27, 2025
-
fanquake requested review from maflcko on Oct 28, 2025
-
maflcko commented at 9:39 pm on October 28, 2025: memberlgtm ACK 53b34c80c631ee3f5ae652315592924f6935e0f1
-
hebasto approved
-
hebasto commented at 10:58 pm on October 28, 2025: memberACK 53b34c80c631ee3f5ae652315592924f6935e0f1.
-
l0rinc commented at 11:04 pm on October 28, 2025: contributorcrACK 53b34c80c631ee3f5ae652315592924f6935e0f1
-
fanquake merged this on Oct 29, 2025
-
fanquake closed this on Oct 29, 2025
-
fanquake deleted the branch on Oct 29, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-02 18:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-02 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me