ci: Fix lint runner selection (and docker cache) #33744

1. 
   willcl-ark commented at 10:38 am on October 30, 2025: member

   Fixes: #33735

   Correct runner type selection for the lint job.

   This was erroneously left-out during refactor of the runner selection mechanism in #33302 causing the lint job to run on GH hosts (and therefore not be able to acces local cirrus caches).

2. ci: fix lint docker caching

   Fixes: 33735
   
   Correct runner type selection for the lint job.
   
   This was erroneously left-out during refactor of the runner selection
   mechanism in #33302 causing the lint job to run on GH hosts (and
   therefore not be able to acces local cirrus caches).

   0b3b8a3be1
3. 
   DrahtBot commented at 10:39 am on October 30, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33744.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. fanquake renamed this:
   Fix lint runner selection (and docker cache)
   ci: Fix lint runner selection (and docker cache)
   on Oct 30, 2025
5. DrahtBot added the label Tests on Oct 30, 2025
6. fanquake added the label Needs backport (30.x) on Oct 30, 2025
7. fanquake requested review from maflcko on Oct 30, 2025
8. 
   maflcko commented at 11:23 am on October 30, 2025: member

   lgtm ACK 0b3b8a3be1a0db0dfc634acca1d9305dc0fbfae6

   This is now selecting the correct provider.

   Some follow-up ideas:

   I ran codex -c model=gpt-5-mini --dangerously-bypass-approvals-and-sandbox exec 'Review the top commit' on ff18b6bbaf322739fe98fd51b0d89d65a5775ab5 for fun, and it printed:

   0**Potential issue I found**
   1- In `action.yml` the `cache-provider` `options` list contains `gh`:
   2  - `.github/actions/configure-docker/action.yml:4`
   3  - But the workflow sets `provider=gha` in `ci.yml` (`echo "provider=gha" >> "$GITHUB_OUTPUT"`).
   

   Which looks real. I guess given that GitHub seems to ignore if wrong options are passed and doesn’t do any validation anyway, it seems fine to remove them?

   Also, could use a yaml anchor to re-use the snippet and specify the runners verbosely for the lint as well:

   0            cirrus-runner: 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-xs'
   1            fallback-runner: 'ubuntu-24.04'
   

   But those are just nits. Feel free to ignore them.

9. 
   willcl-ark commented at 1:05 pm on October 30, 2025: member

   I think it would make sense to include here.

Contributors
willcl-ark DrahtBot maflcko

Review Requested
maflcko

Labels
Tests Needs backport (30.x)