guix: disable libsanitizer in Linux GCC build #33780

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:gcc_disable_libsanitizer changing 1 files +1 −0
  1. fanquake commented at 5:33 pm on November 4, 2025: member

    This causes issues when building against newer glibcs (i.e 2.42), and isn’t needed in any case.

    0../../../../gcc-14.3.0/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:483:31: error: invalid application of ‘sizeof’ to incomplete type ‘__sanitizer::termio’
    1  483 |   unsigned struct_termio_sz = sizeof(struct termio);
    2      |                               ^~~~~~~~~~~~~~~~~~~~~
    

    Extracted from #25573.

  2. guix: disable libsanitizer in Linux GCC build
    This causes issues when building against newer glibcs (i.e 2.42), and isn't needed
    in any case.
    
    ```bash
    ../../../../gcc-14.3.0/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:483:31: error: invalid application of ‘sizeof’ to incomplete type ‘__sanitizer::termio’
      483 |   unsigned struct_termio_sz = sizeof(struct termio);
          |                               ^~~~~~~~~~~~~~~~~~~~~
    ```
    
    Extracted from #25573.
    5c41fa2918
  3. DrahtBot added the label Build system on Nov 4, 2025
  4. DrahtBot commented at 5:33 pm on November 4, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33780.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, hebasto, willcl-ark

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. maflcko commented at 5:38 pm on November 4, 2025: member
    lgtm ACK 5c41fa2918c8fee36d0e0375e753249f1efa7c07
  6. hebasto approved
  7. hebasto commented at 0:16 am on November 5, 2025: member

    ACK 5c41fa2918c8fee36d0e0375e753249f1efa7c07.

    My Guix build:

     0x86_64
     1db958b4fc80e95686eca42fdba140aa3e150c003d5bdef6e3ea34872cd674c8a  guix-build-5c41fa2918c8/output/aarch64-linux-gnu/SHA256SUMS.part
     21f70bdae06dc815d12821b2d7ebb17bdb0b1ca84e775ce7c1bafdbb89d745d59  guix-build-5c41fa2918c8/output/aarch64-linux-gnu/bitcoin-5c41fa2918c8-aarch64-linux-gnu-debug.tar.gz
     3f0cb17846e91bef73901a0f9de4614f31b9881ac445370aa5183ff8a5caa1a35  guix-build-5c41fa2918c8/output/aarch64-linux-gnu/bitcoin-5c41fa2918c8-aarch64-linux-gnu.tar.gz
     4cc7a6e836e09c980cfbd107f4b32ef60ac7cadbad8aa6dd06007302617ce3b7d  guix-build-5c41fa2918c8/output/arm-linux-gnueabihf/SHA256SUMS.part
     532013598051b5ec21ea63bc057409c5e6ce1f2a6ff069ffa928fbce27f17e07d  guix-build-5c41fa2918c8/output/arm-linux-gnueabihf/bitcoin-5c41fa2918c8-arm-linux-gnueabihf-debug.tar.gz
     6fc5f9fccaeb2965dac66ce2ccba920030e6ceac03f9fe7e7caaa793277b8bbe0  guix-build-5c41fa2918c8/output/arm-linux-gnueabihf/bitcoin-5c41fa2918c8-arm-linux-gnueabihf.tar.gz
     7391394ca3c301411dbdf333e097262809661b9b1de0fb179c9a6dd6012747308  guix-build-5c41fa2918c8/output/arm64-apple-darwin/SHA256SUMS.part
     81ddda2f80c8f70d2f93c1f1cdaa904fd73c92d9a1bc11ff96504dde60b4a083f  guix-build-5c41fa2918c8/output/arm64-apple-darwin/bitcoin-5c41fa2918c8-arm64-apple-darwin-codesigning.tar.gz
     91bc5d50a2caedd1f75cbbe354385fbec9d2f562e464c2b0ff954315d188be7d5  guix-build-5c41fa2918c8/output/arm64-apple-darwin/bitcoin-5c41fa2918c8-arm64-apple-darwin-unsigned.tar.gz
    10a21da601a13c25be22aab7b21d0578c10bc3a713d1447bfe381fcf3b505abfa7  guix-build-5c41fa2918c8/output/arm64-apple-darwin/bitcoin-5c41fa2918c8-arm64-apple-darwin-unsigned.zip
    1150e63394dd7d338290bc02085e3c3fbd0d4217a1781552b9444fc15895cc40b0  guix-build-5c41fa2918c8/output/dist-archive/bitcoin-5c41fa2918c8.tar.gz
    129dcafcf212638b1f558df01dec08d3591eb6ceeba099662837834ad6a3d65e38  guix-build-5c41fa2918c8/output/powerpc64-linux-gnu/SHA256SUMS.part
    13ae998a89db2775a8f4d45a52e1f1e22c73044ac7af6f8427749a21d4e0e2ff35  guix-build-5c41fa2918c8/output/powerpc64-linux-gnu/bitcoin-5c41fa2918c8-powerpc64-linux-gnu-debug.tar.gz
    1499af59ae99697aa1c82289c4cc91a25d4b4b6f1e1cb8f1b7348e4355e15ba261  guix-build-5c41fa2918c8/output/powerpc64-linux-gnu/bitcoin-5c41fa2918c8-powerpc64-linux-gnu.tar.gz
    158ecaa9b008197234983326d8988841a90a9b84c61501cd2e7f9f915ab042dcef  guix-build-5c41fa2918c8/output/riscv64-linux-gnu/SHA256SUMS.part
    164c88cfef60904d7ddcc6e04b9261c4db41970ec141add9535ad75e79bb793dfa  guix-build-5c41fa2918c8/output/riscv64-linux-gnu/bitcoin-5c41fa2918c8-riscv64-linux-gnu-debug.tar.gz
    17cb73fe32f9bd99b37c57ad3f755e38f575ac664398f4335886a97d3d04914e85  guix-build-5c41fa2918c8/output/riscv64-linux-gnu/bitcoin-5c41fa2918c8-riscv64-linux-gnu.tar.gz
    1811ddf1a0680b2ccb30364bb815753c2d9988812433d32600792bebffaa877bd0  guix-build-5c41fa2918c8/output/x86_64-apple-darwin/SHA256SUMS.part
    195198d83a0a0b5fc4233c08b10ea510912e224e4350f1ca24f04415b5f20672dc  guix-build-5c41fa2918c8/output/x86_64-apple-darwin/bitcoin-5c41fa2918c8-x86_64-apple-darwin-codesigning.tar.gz
    205ad4ae4657eb97dfcd5f05ca8a074b7159980359dad0f875db2bfd34446df6b4  guix-build-5c41fa2918c8/output/x86_64-apple-darwin/bitcoin-5c41fa2918c8-x86_64-apple-darwin-unsigned.tar.gz
    212594051399b4101973cfe35157302c0f062a3d9a3b241df82fc6ce9b4331c919  guix-build-5c41fa2918c8/output/x86_64-apple-darwin/bitcoin-5c41fa2918c8-x86_64-apple-darwin-unsigned.zip
    2216cfb422442159f27d4d62cc259e416897a041a882dfde3ff6b0abfd21464116  guix-build-5c41fa2918c8/output/x86_64-linux-gnu/SHA256SUMS.part
    2342edd653f7df18ffd85f5f21198ddf1263427ad711206ee430b21be3fae8cb02  guix-build-5c41fa2918c8/output/x86_64-linux-gnu/bitcoin-5c41fa2918c8-x86_64-linux-gnu-debug.tar.gz
    24ebeee40d0bc9df2971e9d4d788f796a79de52b328594a741da15116b8d721568  guix-build-5c41fa2918c8/output/x86_64-linux-gnu/bitcoin-5c41fa2918c8-x86_64-linux-gnu.tar.gz
    255599a9df4b5daf0f5dfbd9941be2d86da1ab4c099d6fd465cbff096fcfb36715  guix-build-5c41fa2918c8/output/x86_64-w64-mingw32/SHA256SUMS.part
    265cb42ae491a53699ab12423bf3a073f37444d51fc15adcbbba9d8cd6ba69936e  guix-build-5c41fa2918c8/output/x86_64-w64-mingw32/bitcoin-5c41fa2918c8-win64-codesigning.tar.gz
    272e8397585ec734c27447e5fd9e84585e385963f0e64c15fe7a9b218aa174abc9  guix-build-5c41fa2918c8/output/x86_64-w64-mingw32/bitcoin-5c41fa2918c8-win64-debug.zip
    282633ad342fd639fb0c13a1e6100cf892e1f9cd4d7ad6b6380f443e23b7cec961  guix-build-5c41fa2918c8/output/x86_64-w64-mingw32/bitcoin-5c41fa2918c8-win64-setup-unsigned.exe
    29d73dd6922ab993729de0677c90b2ecc8f7ebf938ec97dd64092ac10959d3340e  guix-build-5c41fa2918c8/output/x86_64-w64-mingw32/bitcoin-5c41fa2918c8-win64-unsigned.zip
    
  8. willcl-ark approved
  9. willcl-ark commented at 9:50 am on November 5, 2025: member
    utACK 5c41fa2918c8fee36d0e0375e753249f1efa7c07
  10. fanquake merged this on Nov 5, 2025
  11. fanquake closed this on Nov 5, 2025

  12. fanquake deleted the branch on Nov 5, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-06 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me