theStack
commented at 6:06 pm on November 4, 2025:
contributor
This small cleanup PR is a late follow-up to #31250 (commit c847dee1488a294c9a9632a00ba1134b21e41947). These helpers are unused and wouldn’t work anymore, as they call a legacy wallet RPC (dumpprivkey). They were only ever used for testing the importmulti RPC, which also doesn’t exist anymore. Functional tests that need to create key pairs and derive various output script types from them can use get_generate_key (introduced in #16528, commit f193ea889ddb53d9a5c47647966681d525e38368) instead, without involving the node.
DrahtBot added the label
Tests
on Nov 4, 2025
DrahtBot
commented at 6:06 pm on November 4, 2025:
contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
theStack force-pushed
on Nov 4, 2025
DrahtBot added the label
CI failed
on Nov 4, 2025
test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py
These helpers use a legacy wallet RPC (`dumpprivkey`) and thus don't
work anymore. They were only ever used for testing the `importmulti`
RPC, which also doesn't exist anymore.
ec8516ceb7
theStack force-pushed
on Nov 4, 2025
DrahtBot removed the label
CI failed
on Nov 4, 2025
rkrux approved
rkrux
commented at 10:01 am on November 5, 2025:
contributor
crACKec8516ceb7568d7b09836b830023978bd37f8462
brunoerg approved
brunoerg
commented at 2:47 pm on November 5, 2025:
contributor
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2025-11-06 06:13 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me