test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py #33782

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202511-test-remove_get_keymultisig_funcs changing 1 files +0 −51
  1. theStack commented at 6:06 PM on November 4, 2025: contributor

    This small cleanup PR is a late follow-up to #31250 (commit c847dee1488a294c9a9632a00ba1134b21e41947). These helpers are unused and wouldn't work anymore, as they call a legacy wallet RPC (dumpprivkey). They were only ever used for testing the importmulti RPC, which also doesn't exist anymore. Functional tests that need to create key pairs and derive various output script types from them can use get_generate_key (introduced in #16528, commit f193ea889ddb53d9a5c47647966681d525e38368) instead, without involving the node.

  2. DrahtBot added the label Tests on Nov 4, 2025
  3. DrahtBot commented at 6:06 PM on November 4, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33782.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK rkrux, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. theStack force-pushed on Nov 4, 2025
  5. DrahtBot added the label CI failed on Nov 4, 2025
  6. test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py
    These helpers use a legacy wallet RPC (`dumpprivkey`) and thus don't
    work anymore. They were only ever used for testing the `importmulti`
    RPC, which also doesn't exist anymore.
    ec8516ceb7
  7. theStack force-pushed on Nov 4, 2025
  8. DrahtBot removed the label CI failed on Nov 4, 2025
  9. rkrux approved
  10. rkrux commented at 10:01 AM on November 5, 2025: contributor

    crACK ec8516ceb7568d7b09836b830023978bd37f8462

  11. brunoerg approved
  12. brunoerg commented at 2:47 PM on November 5, 2025: contributor

    code review ACK ec8516ceb7568d7b09836b830023978bd37f8462

  13. fanquake merged this on Nov 7, 2025
  14. fanquake closed this on Nov 7, 2025

  15. theStack deleted the branch on Nov 7, 2025
  16. sedited referenced this in commit 94f024ad07 on Nov 11, 2025
  17. yuvicc referenced this in commit f620a2206b on Nov 16, 2025
  18. stringintech referenced this in commit 52fffa1e5d on Nov 24, 2025
  19. stickies-v referenced this in commit 9fa736f8e4 on Jan 22, 2026
  20. Kino1994 referenced this in commit 78b6e04ca2 on Jun 28, 2026
  21. BigcoinBGC referenced this in commit e200b3f9b3 on Jun 30, 2026
  22. Kino1994 referenced this in commit 6095b98181 on Aug 19, 2026
  23. bitcoin locked this on Nov 7, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me