script: remove dead code in `CountWitnessSigOps` #33786

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/witness-pointer-to-reference changing 5 files +7 −9
  1. l0rinc commented at 9:53 PM on November 4, 2025: contributor

    Found while reviewing #32840

    The nullptr witness path was dead in normal code paths: replacing it with reference enables us deleting unreachable logic.

    Code coverage proof: https://maflcko.github.io/b-c-cov/total.coverage/src/script/interpreter.cpp.gcov.html#L2135

  2. refactor: remove dead code in `CountWitnessSigOps`
    Found while reviewing #32840
    
    The `nullptr` witness path was dead in normal code paths: removing it deletes unreachable logic.
    
    Code coverage proof:
    https://maflcko.github.io/b-c-cov/total.coverage/src/script/interpreter.cpp.gcov.html#L2135
    24bcad3d4d
  3. DrahtBot added the label Consensus on Nov 4, 2025
  4. DrahtBot commented at 9:53 PM on November 4, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33786.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK darosior, stickies-v, kevkevinpal, maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32317 (kernel: Separate UTXO set access from validation functions by TheCharlatan)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. darosior approved
  6. darosior commented at 11:26 PM on November 4, 2025: member

    Neat. utACK 24bcad3d4df59690f30c9df8ebb62f0bddd0f1c7.

    The need for a pointer was removed when CTxInWitness was moved into CTxIn in f6fb7acda4aefd01b8ef6cd77063bfc0c4f4ab36.

  7. l0rinc marked this as ready for review on Nov 4, 2025
  8. stickies-v approved
  9. stickies-v commented at 12:01 PM on November 5, 2025: contributor

    ACK 24bcad3d4df59690f30c9df8ebb62f0bddd0f1c7

  10. kevkevinpal commented at 8:10 PM on November 5, 2025: contributor

    ACK 24bcad3

  11. maflcko commented at 4:06 PM on November 6, 2025: member

    review ACK 24bcad3d4df59690f30c9df8ebb62f0bddd0f1c7 🐏

    <details><summary>Show signature</summary>

    Signature:

    untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    trusted comment: review ACK 24bcad3d4df59690f30c9df8ebb62f0bddd0f1c7 🐏
    hj6nIxI+40vPxamIgbX5LlbpRouEUxYZY48TXPn9b4qzVEGLo6G5sBwEiRQKpq2+LSPlEhKOLRkvjKpFnlFqBA==
    

    </details>

  12. fanquake merged this on Nov 7, 2025
  13. fanquake closed this on Nov 7, 2025

  14. l0rinc deleted the branch on Nov 7, 2025
  15. sedited referenced this in commit 94f024ad07 on Nov 11, 2025
  16. yuvicc referenced this in commit f620a2206b on Nov 16, 2025
  17. stringintech referenced this in commit 52fffa1e5d on Nov 24, 2025
  18. achow101 referenced this in commit b26762bdcb on Dec 10, 2025
  19. stickies-v referenced this in commit 9fa736f8e4 on Jan 22, 2026
  20. Kino1994 referenced this in commit b2f44cc469 on Jun 28, 2026
  21. BigcoinBGC referenced this in commit 9f2e5e2432 on Jun 30, 2026
  22. Kino1994 referenced this in commit c0329b6eec on Aug 19, 2026
  23. bitcoin locked this on Nov 7, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-20 15:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me