doc: add cmake help option in Windows build docs #33789

pull frankomosh wants to merge 1 commits into bitcoin:master from frankomosh:doc-windows-cmake-help changing 2 files +5 −0
  1. frankomosh commented at 8:28 am on November 5, 2025: contributor

    Follow-up to #33088.

    Adds cmake -B build -LH documentation to Windows build guides, similar to Unix build documentation.

    Based on the suggestion and example provided by stickies-v in #33088, with minor adjustment to match existing indented code block format in build-windows.md.

    Tested for:

    • WSL Ubuntu with mingw-w64 cross-compilation
    • Windows 11 with Visual Studio 2022 (MSVC)
  2. doc: Add cmake help option in Windows build instructions
    Used to display available configuration options, for consistency with recent changes in Unix build docs
    
    Co-authored-by: stickies-v <stickies-v@users.noreply.github.com>
    9577daa3b8
  3. DrahtBot added the label Docs on Nov 5, 2025
  4. DrahtBot commented at 8:28 am on November 5, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33789.

    Reviews

    See the guideline for information on the review process.

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. stickies-v approved
  6. stickies-v commented at 11:20 am on November 5, 2025: contributor
    ACK 9577daa3b88a8fbe8c96d2848adcc88c55c55a29
  7. hebasto approved
  8. hebasto commented at 11:41 am on November 5, 2025: member
    ACK 9577daa3b88a8fbe8c96d2848adcc88c55c55a29.
  9. waketraindev commented at 1:47 pm on November 5, 2025: contributor
    ACK 9577daa
  10. in doc/build-windows.md:54 in 9577daa3b8
    48@@ -49,6 +49,9 @@ Build using:
    49 
    50     gmake -C depends HOST=x86_64-w64-mingw32  # Append "-j N" for N parallel jobs.
    51     cmake -B build --toolchain depends/x86_64-w64-mingw32/toolchain.cmake
    52+
    53+Run `cmake -B build -LH` to see the full list of available options.
    54+
    


    pablomartin4btc commented at 2:54 pm on November 5, 2025:

    nit:

    0    cmake -B build --toolchain depends/x86_64-w64-mingw32/toolchain.cmake
    1    (run `cmake -B build -LH` to see the full list of available options)
    

    frankomosh commented at 5:46 pm on November 5, 2025:
    I think it needs to match the format in doc/build-unix.md?

    pablomartin4btc commented at 0:05 am on November 6, 2025:
    Not necessarily, in fact, most build instructions have different structure (unify it, if possible, could be the goal of a different PR, as you can see here we need to copy stuff for every platform). My suggestion is not a blocker just that you are adding this line in the middle of the building instructions, and that’s not the case for the other file you are updating. It’s an observation, up to you if you want to leave it that way or not.

    frankomosh commented at 4:21 am on November 6, 2025:
    Thanks for clarifying. I think i’ll keep it as-is for now. Yes, unifying structure across build docs as you have suggested is great and can indeed be tackled seperately. Appreciate your feedback!
  11. pablomartin4btc commented at 2:59 pm on November 5, 2025: member

    ACK 9577daa3b88a8fbe8c96d2848adcc88c55c55a29

    (please try to avoid mentions/ @-prefixed github names in PR descriptions as it can cause potential issues, primarily related to notification spam)

  12. fanquake merged this on Nov 7, 2025
  13. fanquake closed this on Nov 7, 2025

  14. frankomosh deleted the branch on Nov 7, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-23 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me