test: move create_malleated_version() to messages.py for reuse #33793

1. 
   vasild commented at 3:14 pm on November 5, 2025: contributor

   Move create_malleated_version() from p2p_orphan_handling.py to test_framework/messages.py so that it can be reused by other tests.

   ---

   This is part of #29415 Broadcast own transactions only via short-lived Tor or I2P connections. Putting it in its own PR to reduce the size of #29415 and because it does not depend on the other commits from there.

2. test: move create_malleated_version() to messages.py for reuse 2bd155e6ee
3. DrahtBot added the label Tests on Nov 5, 2025
4. 
   DrahtBot commented at 3:14 pm on November 5, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33793.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, brunoerg, w0xlt, pablomartin4btc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29415 (Broadcast own transactions only via short-lived Tor or I2P connections by vasild)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   maflcko commented at 4:43 pm on November 5, 2025: member

   review ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769 🍨

   Signature:

   0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
   1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
   2trusted comment: review ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769 🍨
   3opEEp6mbKyDWYRPD0JRuvAz7Trpm3hwooUJFnYCYjUMqlvnSiY69dl9k2bSOlD8FjXYLSPnYPTqvRzRuQMU4CA==
   

6. brunoerg approved
7. 
   brunoerg commented at 4:49 pm on November 5, 2025: contributor

   ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769
8. 
   w0xlt commented at 0:10 am on November 6, 2025: contributor

   Code Review ACK https://github.com/bitcoin/bitcoin/pull/33793/commits/2bd155e6ee7e3cabd76083ac921b34bb45d98769
9. 
   pablomartin4btc commented at 5:26 am on November 6, 2025: member

   cr ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769

Contributors
vasild DrahtBot maflcko brunoerg w0xlt pablomartin4btc

Labels
Tests