test: move create_malleated_version() to messages.py for reuse #33793

pull vasild wants to merge 1 commits into bitcoin:master from vasild:reusable_create_malleated_version changing 2 files +25 −21

vasild commented at 3:14 PM on November 5, 2025: contributor

Move create_malleated_version() from p2p_orphan_handling.py to test_framework/messages.py so that it can be reused by other tests.

This is part of #29415 Broadcast own transactions only via short-lived Tor or I2P connections. Putting it in its own PR to reduce the size of #29415 and because it does not depend on the other commits from there.
test: move create_malleated_version() to messages.py for reuse 2bd155e6ee
DrahtBot added the label Tests on Nov 5, 2025
DrahtBot commented at 3:14 PM on November 5, 2025: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33793.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, brunoerg, w0xlt, pablomartin4btc, rkrux, l0rinc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #29415 (Broadcast own transactions only via short-lived Tor or I2P connections by vasild)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Type	Reviewers
ACK	maflcko, brunoerg, w0xlt, pablomartin4btc, rkrux, l0rinc

maflcko commented at 4:43 PM on November 5, 2025: member

review ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769 🍨

<details><summary>Show signature</summary>

Signature:

untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769 🍨
opEEp6mbKyDWYRPD0JRuvAz7Trpm3hwooUJFnYCYjUMqlvnSiY69dl9k2bSOlD8FjXYLSPnYPTqvRzRuQMU4CA==

</details>

brunoerg approved
brunoerg commented at 4:49 PM on November 5, 2025: contributor

ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769
w0xlt commented at 12:10 AM on November 6, 2025: contributor

Code Review ACK https://github.com/bitcoin/bitcoin/pull/33793/commits/2bd155e6ee7e3cabd76083ac921b34bb45d98769
pablomartin4btc commented at 5:26 AM on November 6, 2025: member

cr ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769
rkrux approved
rkrux commented at 9:14 AM on November 6, 2025: contributor

crACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769

Seems like a common enough utility function.
l0rinc commented at 10:50 AM on November 6, 2025: contributor

ACK 2bd155e6ee7e3cabd76083ac921b34bb45d98769

Recreated locally, ended up with the same. The move is correct, only the method name is changed. The imports are correctly sorted and adjusted.
fanquake merged this on Nov 7, 2025
fanquake closed this on Nov 7, 2025
vasild deleted the branch on Nov 7, 2025
sedited referenced this in commit 94f024ad07 on Nov 11, 2025
yuvicc referenced this in commit f620a2206b on Nov 16, 2025
stringintech referenced this in commit 52fffa1e5d on Nov 24, 2025
stickies-v referenced this in commit 9fa736f8e4 on Jan 22, 2026
Kino1994 referenced this in commit c2349d66bb on Jun 28, 2026
BigcoinBGC referenced this in commit 69cfd9ff75 on Jun 30, 2026
Kino1994 referenced this in commit 298de37d12 on Aug 19, 2026
bitcoin locked this on Nov 7, 2026