depends: drop qtbase_avoid_native

fanquake commented at 11:20 am on November 11, 2025: member

There is no-longer a minimum required / max supported libgcc version, after #33181.

depends: drop qtbase_avoid_native_float16 qt patch

There is no-longer a minimum required libgcc version, after
https://github.com/bitcoin/bitcoin/pull/33181.

169f93d2ac

DrahtBot added the label Build system on Nov 11, 2025

DrahtBot commented at 11:20 am on November 11, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33850.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	laanwj, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto commented at 11:21 am on November 11, 2025: member

Concept ACK. I was about to open the same PR :)

fanquake added the label DrahtBot Guix build requested on Nov 11, 2025

laanwj approved

laanwj commented at 12:10 pm on November 11, 2025: member

Code review ACK 169f93d2ac887a7295e87f0a69c2407cdd0a936e Good to get rid of this patch. Using native float16 should be fine (and might even be a speed-up) on platforms that have this. If not, it’s a good cleanup.

DrahtBot requested review from hebasto on Nov 11, 2025

fanquake commented at 4:52 pm on November 11, 2025: member

Guix Build (x86_64):

 0945f7146ca27fd741e0512d214171cecb61f9c4d1a07a56821b0c5765aa7db13  guix-build-169f93d2ac88/output/aarch64-linux-gnu/SHA256SUMS.part
 1ff1debd447ad07d09c29f37ce1da4723aef28c40f56e8ca64c1c83ee80a744a4  guix-build-169f93d2ac88/output/aarch64-linux-gnu/bitcoin-169f93d2ac88-aarch64-linux-gnu-debug.tar.gz
 249ebd79348ffad69d3448252896900a3c42c6ac4b0abfc99503887cbff59f190  guix-build-169f93d2ac88/output/aarch64-linux-gnu/bitcoin-169f93d2ac88-aarch64-linux-gnu.tar.gz
 35419239208ebce004e72c60630217e70e363e7df45559256fed9e82840ee8b6e  guix-build-169f93d2ac88/output/arm-linux-gnueabihf/SHA256SUMS.part
 41455bbb4dd1095c906d1fed138595cc31dadd28cd1b0cd5326170596faf7083d  guix-build-169f93d2ac88/output/arm-linux-gnueabihf/bitcoin-169f93d2ac88-arm-linux-gnueabihf-debug.tar.gz
 5a0735bed0b734a4c42e5a96d3e89c6ddf155d52cea8dcca0b0e5bd33692068f4  guix-build-169f93d2ac88/output/arm-linux-gnueabihf/bitcoin-169f93d2ac88-arm-linux-gnueabihf.tar.gz
 64a4d668991226c2c590ef96cf87fe3aa0a19b5b250ec3f0ea9ccf943c2b7f726  guix-build-169f93d2ac88/output/arm64-apple-darwin/SHA256SUMS.part
 7e65a0c3df61ad0e9038bbec8148a3953c3a9d3934ecad687415b5519a8f7aae4  guix-build-169f93d2ac88/output/arm64-apple-darwin/bitcoin-169f93d2ac88-arm64-apple-darwin-codesigning.tar.gz
 86b6c964dca3672a712c5458d9bc21463f832a4e95e3edb3391b9835608e588da  guix-build-169f93d2ac88/output/arm64-apple-darwin/bitcoin-169f93d2ac88-arm64-apple-darwin-unsigned.tar.gz
 945102579920d18f2eecf5d71879ee11671c7f25ed7f73f8f7c67a41a1be7e662  guix-build-169f93d2ac88/output/arm64-apple-darwin/bitcoin-169f93d2ac88-arm64-apple-darwin-unsigned.zip
107051f21ea18886733c2ca6944b95675a296711ff8f5e535f7851058b1dcfd6b2  guix-build-169f93d2ac88/output/dist-archive/bitcoin-169f93d2ac88.tar.gz
1136a07a2f41c0c1e66aa1fe092123de9011c0eac0707dbefa375ce25b524b248c  guix-build-169f93d2ac88/output/powerpc64-linux-gnu/SHA256SUMS.part
12c78050709908f669e189940351c4f9e00c488d3980c661fe988a26a80a8be15c  guix-build-169f93d2ac88/output/powerpc64-linux-gnu/bitcoin-169f93d2ac88-powerpc64-linux-gnu-debug.tar.gz
132a6847e2bc74208331a5867a204baf9690de5812538b9dde9471261f96a10833  guix-build-169f93d2ac88/output/powerpc64-linux-gnu/bitcoin-169f93d2ac88-powerpc64-linux-gnu.tar.gz
147aa6de64e1b4bd09aacc79ab44baa6b489dedf3ef00aae0ccde2d3df2d516185  guix-build-169f93d2ac88/output/riscv64-linux-gnu/SHA256SUMS.part
1540e2e87ee99e8d47517fd85a05ba86d9294d3c13cdf5b2dc8c619befe05083e8  guix-build-169f93d2ac88/output/riscv64-linux-gnu/bitcoin-169f93d2ac88-riscv64-linux-gnu-debug.tar.gz
16c2e33d5ce33c5a50109b814cdbf4ded42fe4d4468091dfe1a07027ec5f8baf8a  guix-build-169f93d2ac88/output/riscv64-linux-gnu/bitcoin-169f93d2ac88-riscv64-linux-gnu.tar.gz
17f625c0ee95e934af41bda6fce707e661ffd214dfc39f61366ac875a6dc831625  guix-build-169f93d2ac88/output/x86_64-apple-darwin/SHA256SUMS.part
180fdc9d644420b9cba20c0144da5d8cba92c2315cd399fdc2d37acb16824323e8  guix-build-169f93d2ac88/output/x86_64-apple-darwin/bitcoin-169f93d2ac88-x86_64-apple-darwin-codesigning.tar.gz
193af08349885da6983807b64982a06f32f43102bf9d0a628ba9d7d2cc32ddac7f  guix-build-169f93d2ac88/output/x86_64-apple-darwin/bitcoin-169f93d2ac88-x86_64-apple-darwin-unsigned.tar.gz
2078c9b93bc84768151fd6864df6004dee137dffbd693f890a4d5524c7801ea0ec  guix-build-169f93d2ac88/output/x86_64-apple-darwin/bitcoin-169f93d2ac88-x86_64-apple-darwin-unsigned.zip
21010cc823160351c5711f7de186988b289a2bc2805daca347a339e6353a4148a5  guix-build-169f93d2ac88/output/x86_64-linux-gnu/SHA256SUMS.part
22f5617cbe8f9c2b40bb7c56fccf47360f67d7786df44c14d58ac41487eaaedf83  guix-build-169f93d2ac88/output/x86_64-linux-gnu/bitcoin-169f93d2ac88-x86_64-linux-gnu-debug.tar.gz
2365b1df470b27dfdcf6c3d0056b3786976949feda7136c6fee08e1203a8a031aa  guix-build-169f93d2ac88/output/x86_64-linux-gnu/bitcoin-169f93d2ac88-x86_64-linux-gnu.tar.gz
2491fdffb564713d45cc42e3c25e8380adcc8e07f8cb5583115d5441747272a314  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/SHA256SUMS.part
25e384d848ea8f1a64f8d21b9f76b03e65f73b588b69a672c32a40acb931c824e1  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-codesigning.tar.gz
267e9cd3154dfd5d1bbdd7c16edaaac1182810c02410f843b4815517b5e20f7abc  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-debug.zip
27a2f9645d168d9bffaaf1b318f10624e323327d1954fabaa4bba41fc38a64576c  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-setup-unsigned.exe
286d3c6cc12f590e9da27fe5520fd5d3796be8d6148468bae30a11d9ce975533a3  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-unsigned.zip

hebasto commented at 5:00 pm on November 11, 2025: member

My Guix build:

 0aarch64
 1945f7146ca27fd741e0512d214171cecb61f9c4d1a07a56821b0c5765aa7db13  guix-build-169f93d2ac88/output/aarch64-linux-gnu/SHA256SUMS.part
 2ff1debd447ad07d09c29f37ce1da4723aef28c40f56e8ca64c1c83ee80a744a4  guix-build-169f93d2ac88/output/aarch64-linux-gnu/bitcoin-169f93d2ac88-aarch64-linux-gnu-debug.tar.gz
 349ebd79348ffad69d3448252896900a3c42c6ac4b0abfc99503887cbff59f190  guix-build-169f93d2ac88/output/aarch64-linux-gnu/bitcoin-169f93d2ac88-aarch64-linux-gnu.tar.gz
 45419239208ebce004e72c60630217e70e363e7df45559256fed9e82840ee8b6e  guix-build-169f93d2ac88/output/arm-linux-gnueabihf/SHA256SUMS.part
 51455bbb4dd1095c906d1fed138595cc31dadd28cd1b0cd5326170596faf7083d  guix-build-169f93d2ac88/output/arm-linux-gnueabihf/bitcoin-169f93d2ac88-arm-linux-gnueabihf-debug.tar.gz
 6a0735bed0b734a4c42e5a96d3e89c6ddf155d52cea8dcca0b0e5bd33692068f4  guix-build-169f93d2ac88/output/arm-linux-gnueabihf/bitcoin-169f93d2ac88-arm-linux-gnueabihf.tar.gz
 74a4d668991226c2c590ef96cf87fe3aa0a19b5b250ec3f0ea9ccf943c2b7f726  guix-build-169f93d2ac88/output/arm64-apple-darwin/SHA256SUMS.part
 8e65a0c3df61ad0e9038bbec8148a3953c3a9d3934ecad687415b5519a8f7aae4  guix-build-169f93d2ac88/output/arm64-apple-darwin/bitcoin-169f93d2ac88-arm64-apple-darwin-codesigning.tar.gz
 96b6c964dca3672a712c5458d9bc21463f832a4e95e3edb3391b9835608e588da  guix-build-169f93d2ac88/output/arm64-apple-darwin/bitcoin-169f93d2ac88-arm64-apple-darwin-unsigned.tar.gz
1045102579920d18f2eecf5d71879ee11671c7f25ed7f73f8f7c67a41a1be7e662  guix-build-169f93d2ac88/output/arm64-apple-darwin/bitcoin-169f93d2ac88-arm64-apple-darwin-unsigned.zip
117051f21ea18886733c2ca6944b95675a296711ff8f5e535f7851058b1dcfd6b2  guix-build-169f93d2ac88/output/dist-archive/bitcoin-169f93d2ac88.tar.gz
1236a07a2f41c0c1e66aa1fe092123de9011c0eac0707dbefa375ce25b524b248c  guix-build-169f93d2ac88/output/powerpc64-linux-gnu/SHA256SUMS.part
13c78050709908f669e189940351c4f9e00c488d3980c661fe988a26a80a8be15c  guix-build-169f93d2ac88/output/powerpc64-linux-gnu/bitcoin-169f93d2ac88-powerpc64-linux-gnu-debug.tar.gz
142a6847e2bc74208331a5867a204baf9690de5812538b9dde9471261f96a10833  guix-build-169f93d2ac88/output/powerpc64-linux-gnu/bitcoin-169f93d2ac88-powerpc64-linux-gnu.tar.gz
157aa6de64e1b4bd09aacc79ab44baa6b489dedf3ef00aae0ccde2d3df2d516185  guix-build-169f93d2ac88/output/riscv64-linux-gnu/SHA256SUMS.part
1640e2e87ee99e8d47517fd85a05ba86d9294d3c13cdf5b2dc8c619befe05083e8  guix-build-169f93d2ac88/output/riscv64-linux-gnu/bitcoin-169f93d2ac88-riscv64-linux-gnu-debug.tar.gz
17c2e33d5ce33c5a50109b814cdbf4ded42fe4d4468091dfe1a07027ec5f8baf8a  guix-build-169f93d2ac88/output/riscv64-linux-gnu/bitcoin-169f93d2ac88-riscv64-linux-gnu.tar.gz
18f625c0ee95e934af41bda6fce707e661ffd214dfc39f61366ac875a6dc831625  guix-build-169f93d2ac88/output/x86_64-apple-darwin/SHA256SUMS.part
190fdc9d644420b9cba20c0144da5d8cba92c2315cd399fdc2d37acb16824323e8  guix-build-169f93d2ac88/output/x86_64-apple-darwin/bitcoin-169f93d2ac88-x86_64-apple-darwin-codesigning.tar.gz
203af08349885da6983807b64982a06f32f43102bf9d0a628ba9d7d2cc32ddac7f  guix-build-169f93d2ac88/output/x86_64-apple-darwin/bitcoin-169f93d2ac88-x86_64-apple-darwin-unsigned.tar.gz
2178c9b93bc84768151fd6864df6004dee137dffbd693f890a4d5524c7801ea0ec  guix-build-169f93d2ac88/output/x86_64-apple-darwin/bitcoin-169f93d2ac88-x86_64-apple-darwin-unsigned.zip
22010cc823160351c5711f7de186988b289a2bc2805daca347a339e6353a4148a5  guix-build-169f93d2ac88/output/x86_64-linux-gnu/SHA256SUMS.part
23f5617cbe8f9c2b40bb7c56fccf47360f67d7786df44c14d58ac41487eaaedf83  guix-build-169f93d2ac88/output/x86_64-linux-gnu/bitcoin-169f93d2ac88-x86_64-linux-gnu-debug.tar.gz
2465b1df470b27dfdcf6c3d0056b3786976949feda7136c6fee08e1203a8a031aa  guix-build-169f93d2ac88/output/x86_64-linux-gnu/bitcoin-169f93d2ac88-x86_64-linux-gnu.tar.gz
2591fdffb564713d45cc42e3c25e8380adcc8e07f8cb5583115d5441747272a314  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/SHA256SUMS.part
26e384d848ea8f1a64f8d21b9f76b03e65f73b588b69a672c32a40acb931c824e1  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-codesigning.tar.gz
277e9cd3154dfd5d1bbdd7c16edaaac1182810c02410f843b4815517b5e20f7abc  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-debug.zip
28a2f9645d168d9bffaaf1b318f10624e323327d1954fabaa4bba41fc38a64576c  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-setup-unsigned.exe
296d3c6cc12f590e9da27fe5520fd5d3796be8d6148468bae30a11d9ce975533a3  guix-build-169f93d2ac88/output/x86_64-w64-mingw32/bitcoin-169f93d2ac88-win64-unsigned.zip

DrahtBot requested review from hebasto on Nov 11, 2025

hebasto approved

hebasto commented at 5:01 pm on November 11, 2025: member

ACK 169f93d2ac887a7295e87f0a69c2407cdd0a936e.

hebasto merged this on Nov 11, 2025

hebasto closed this on Nov 11, 2025

fanquake deleted the branch on Nov 11, 2025

TheCharlatan referenced this in commit 75d8345983 on Nov 12, 2025

TheCharlatan referenced this in commit 7f93626ea0 on Nov 12, 2025

maflcko removed the label DrahtBot Guix build requested on Nov 12, 2025

depends: drop qtbase_avoid_native_float16 qt patch #33850

Code Coverage & Benchmarks

Reviews