depends: drop Qt patches

fanquake commented at 2:30 pm on November 12, 2025: member

Drop one patch that was already unused, and one that compilation succeeds without.

depends: drop unused qt patch

This hasn't been applied since 5e794e62024eef612e1fbb71c76ea54d17435c14,
but the patch was never removed.

0da5a82700

depends: drop qtbase-moc-ignore-gcc-macro.patch qt patch

Looks like this was fixed in 6.5 or 6.6, via
https://codereview.qt-project.org/c/qt/qtbase/+/492580.

3e9aca6f1b

DrahtBot added the label Build system on Nov 12, 2025

DrahtBot commented at 2:30 pm on November 12, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33860.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan
Concept ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

maflcko added the label DrahtBot Guix build requested on Nov 12, 2025

hebasto commented at 3:23 pm on November 12, 2025: member

Concept ACK. Thanks!

fanquake commented at 4:22 pm on November 12, 2025: member

Guix Build (aarch64):

 06eb3c63d243ad8b9e10bed1aa9ec545d4599a10e2d333a69b346c8aaab941fb2  guix-build-3e9aca6f1b52/output/aarch64-linux-gnu/SHA256SUMS.part
 1b7bf29e4e64a207eca6ec785f2a8944d0051c177636b6f8db78da5836404ae89  guix-build-3e9aca6f1b52/output/aarch64-linux-gnu/bitcoin-3e9aca6f1b52-aarch64-linux-gnu-debug.tar.gz
 2dea243b0ce4f6a389ad1612d4f27f0bca816f5f11fe77c2ff4ca703a1db607ee  guix-build-3e9aca6f1b52/output/aarch64-linux-gnu/bitcoin-3e9aca6f1b52-aarch64-linux-gnu.tar.gz
 3341a70902799d01c04a0228c36baf9a1bd0c9f1d16d04bd6269d0560235b3c57  guix-build-3e9aca6f1b52/output/arm-linux-gnueabihf/SHA256SUMS.part
 40dfc90dc4ce40c4cd4ab07f306e30062994ddf3743b2d6c76507c67dae56027c  guix-build-3e9aca6f1b52/output/arm-linux-gnueabihf/bitcoin-3e9aca6f1b52-arm-linux-gnueabihf-debug.tar.gz
 593bdb530f1472f03cd26e83d3691cfeeccd441fad7f7f02e1416a20633722679  guix-build-3e9aca6f1b52/output/arm-linux-gnueabihf/bitcoin-3e9aca6f1b52-arm-linux-gnueabihf.tar.gz
 6f326c1577449ba4965add972ea9ed2571e137262a6f73ebdbfabd21fa56066f8  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/SHA256SUMS.part
 70db50f058e8c920baa73b78c484a16992da1e90f2455b12b5f174cc440f50902  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/bitcoin-3e9aca6f1b52-arm64-apple-darwin-codesigning.tar.gz
 806c02a6d7ca5802ea1cba8c3cfb5bae0614a0756b9874ef36893b27f091c10cc  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/bitcoin-3e9aca6f1b52-arm64-apple-darwin-unsigned.tar.gz
 9af0f4f086f450c1fb2f9e5fa8fc69a7527835ee8a0835b7e8187246c2ba10256  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/bitcoin-3e9aca6f1b52-arm64-apple-darwin-unsigned.zip
100e92df5530bf28db1d5a54494b138dccb5a8c32d539c31b5aa3ba4b1264b7707  guix-build-3e9aca6f1b52/output/dist-archive/bitcoin-3e9aca6f1b52.tar.gz
119898d2981c1323fe7be556021faaf32c36c8d7bfe8d4934fdbeaf88f89cad0fd  guix-build-3e9aca6f1b52/output/powerpc64-linux-gnu/SHA256SUMS.part
127611ba536ab2054e3f0c41f0e78da5ec56adfafe5258de689041ec272449c119  guix-build-3e9aca6f1b52/output/powerpc64-linux-gnu/bitcoin-3e9aca6f1b52-powerpc64-linux-gnu-debug.tar.gz
1303a8f72712ba68053824640e4d1d53df48c4ac04c54e39e8586dba6f46cce427  guix-build-3e9aca6f1b52/output/powerpc64-linux-gnu/bitcoin-3e9aca6f1b52-powerpc64-linux-gnu.tar.gz
149c5f06b646fee743be0601d6e8e93dd7dc4459568c30e54025836be450c4fe29  guix-build-3e9aca6f1b52/output/riscv64-linux-gnu/SHA256SUMS.part
15f47eac387b06d1afdb9e1a5b11137ad14acf026b6e8c576bd40c91f73aeb0dcc  guix-build-3e9aca6f1b52/output/riscv64-linux-gnu/bitcoin-3e9aca6f1b52-riscv64-linux-gnu-debug.tar.gz
167bf1ad3fd70afbe2b625c01d891efb59dbfcf09fbdc31ed6884b911717855f7b  guix-build-3e9aca6f1b52/output/riscv64-linux-gnu/bitcoin-3e9aca6f1b52-riscv64-linux-gnu.tar.gz
17d78be99419c7d11790bc577af635b26408d163d489b75c582157ca7bc72fe8df  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/SHA256SUMS.part
183cf2b3d07a124f4047b01a2240f08daf965a5108d128823f402f213a7794df62  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/bitcoin-3e9aca6f1b52-x86_64-apple-darwin-codesigning.tar.gz
19809903a784ed6e288699f6434a661ad11a2261c93d877b7c695419d9b15f1d32  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/bitcoin-3e9aca6f1b52-x86_64-apple-darwin-unsigned.tar.gz
202f8339911e1e4bfca45c6c5fa30fb15800d0095d32ea970c3d60226e6b0d4160  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/bitcoin-3e9aca6f1b52-x86_64-apple-darwin-unsigned.zip
216f37dc311b324800c5f2ac9f22555fad1a78aa0f99135e1a4b0ebd8de82b2bd0  guix-build-3e9aca6f1b52/output/x86_64-linux-gnu/SHA256SUMS.part
22db1ced518e06d793837a93b223c70d7c9bdde1053b0ef386d8065156de95eb29  guix-build-3e9aca6f1b52/output/x86_64-linux-gnu/bitcoin-3e9aca6f1b52-x86_64-linux-gnu-debug.tar.gz
23fb58336ce100926340776e05c1ec4507835e12d55554fc3e1744700c5409cf2f  guix-build-3e9aca6f1b52/output/x86_64-linux-gnu/bitcoin-3e9aca6f1b52-x86_64-linux-gnu.tar.gz
24d043aa1c97141e57a9fc9c8bb6bd575817b78ab15529624af684776f45c0a55a  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/SHA256SUMS.part
25c44b588e7477483d3ac8d0f33fc3e9bf844444c933361da64dd51d1d41fc3a52  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-codesigning.tar.gz
2637ea405893eefc251b1869fcda0fd6b79c92ce7bfb8abd408151a321ba2e0e54  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-debug.zip
2795c2b3b5bbf2c0fa6a0990373373c1544fa6180fbb44b5d2cc82b86a30ed6499  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-setup-unsigned.exe
2869311914f27a2ad1b8230c7896cccaa7769f1ddbff3816edaa1e5480d993cf95  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-unsigned.zip

TheCharlatan approved

TheCharlatan commented at 4:26 pm on November 13, 2025: contributor

ACK 3e9aca6f1b52169eed386849900a400e8cea431e

Guix build:

 06eb3c63d243ad8b9e10bed1aa9ec545d4599a10e2d333a69b346c8aaab941fb2  guix-build-3e9aca6f1b52/output/aarch64-linux-gnu/SHA256SUMS.part
 1b7bf29e4e64a207eca6ec785f2a8944d0051c177636b6f8db78da5836404ae89  guix-build-3e9aca6f1b52/output/aarch64-linux-gnu/bitcoin-3e9aca6f1b52-aarch64-linux-gnu-debug.tar.gz
 2dea243b0ce4f6a389ad1612d4f27f0bca816f5f11fe77c2ff4ca703a1db607ee  guix-build-3e9aca6f1b52/output/aarch64-linux-gnu/bitcoin-3e9aca6f1b52-aarch64-linux-gnu.tar.gz
 3341a70902799d01c04a0228c36baf9a1bd0c9f1d16d04bd6269d0560235b3c57  guix-build-3e9aca6f1b52/output/arm-linux-gnueabihf/SHA256SUMS.part
 40dfc90dc4ce40c4cd4ab07f306e30062994ddf3743b2d6c76507c67dae56027c  guix-build-3e9aca6f1b52/output/arm-linux-gnueabihf/bitcoin-3e9aca6f1b52-arm-linux-gnueabihf-debug.tar.gz
 593bdb530f1472f03cd26e83d3691cfeeccd441fad7f7f02e1416a20633722679  guix-build-3e9aca6f1b52/output/arm-linux-gnueabihf/bitcoin-3e9aca6f1b52-arm-linux-gnueabihf.tar.gz
 6f326c1577449ba4965add972ea9ed2571e137262a6f73ebdbfabd21fa56066f8  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/SHA256SUMS.part
 70db50f058e8c920baa73b78c484a16992da1e90f2455b12b5f174cc440f50902  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/bitcoin-3e9aca6f1b52-arm64-apple-darwin-codesigning.tar.gz
 806c02a6d7ca5802ea1cba8c3cfb5bae0614a0756b9874ef36893b27f091c10cc  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/bitcoin-3e9aca6f1b52-arm64-apple-darwin-unsigned.tar.gz
 9af0f4f086f450c1fb2f9e5fa8fc69a7527835ee8a0835b7e8187246c2ba10256  guix-build-3e9aca6f1b52/output/arm64-apple-darwin/bitcoin-3e9aca6f1b52-arm64-apple-darwin-unsigned.zip
100e92df5530bf28db1d5a54494b138dccb5a8c32d539c31b5aa3ba4b1264b7707  guix-build-3e9aca6f1b52/output/dist-archive/bitcoin-3e9aca6f1b52.tar.gz
119898d2981c1323fe7be556021faaf32c36c8d7bfe8d4934fdbeaf88f89cad0fd  guix-build-3e9aca6f1b52/output/powerpc64-linux-gnu/SHA256SUMS.part
127611ba536ab2054e3f0c41f0e78da5ec56adfafe5258de689041ec272449c119  guix-build-3e9aca6f1b52/output/powerpc64-linux-gnu/bitcoin-3e9aca6f1b52-powerpc64-linux-gnu-debug.tar.gz
1303a8f72712ba68053824640e4d1d53df48c4ac04c54e39e8586dba6f46cce427  guix-build-3e9aca6f1b52/output/powerpc64-linux-gnu/bitcoin-3e9aca6f1b52-powerpc64-linux-gnu.tar.gz
149c5f06b646fee743be0601d6e8e93dd7dc4459568c30e54025836be450c4fe29  guix-build-3e9aca6f1b52/output/riscv64-linux-gnu/SHA256SUMS.part
15f47eac387b06d1afdb9e1a5b11137ad14acf026b6e8c576bd40c91f73aeb0dcc  guix-build-3e9aca6f1b52/output/riscv64-linux-gnu/bitcoin-3e9aca6f1b52-riscv64-linux-gnu-debug.tar.gz
167bf1ad3fd70afbe2b625c01d891efb59dbfcf09fbdc31ed6884b911717855f7b  guix-build-3e9aca6f1b52/output/riscv64-linux-gnu/bitcoin-3e9aca6f1b52-riscv64-linux-gnu.tar.gz
17d78be99419c7d11790bc577af635b26408d163d489b75c582157ca7bc72fe8df  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/SHA256SUMS.part
183cf2b3d07a124f4047b01a2240f08daf965a5108d128823f402f213a7794df62  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/bitcoin-3e9aca6f1b52-x86_64-apple-darwin-codesigning.tar.gz
19809903a784ed6e288699f6434a661ad11a2261c93d877b7c695419d9b15f1d32  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/bitcoin-3e9aca6f1b52-x86_64-apple-darwin-unsigned.tar.gz
202f8339911e1e4bfca45c6c5fa30fb15800d0095d32ea970c3d60226e6b0d4160  guix-build-3e9aca6f1b52/output/x86_64-apple-darwin/bitcoin-3e9aca6f1b52-x86_64-apple-darwin-unsigned.zip
216f37dc311b324800c5f2ac9f22555fad1a78aa0f99135e1a4b0ebd8de82b2bd0  guix-build-3e9aca6f1b52/output/x86_64-linux-gnu/SHA256SUMS.part
22db1ced518e06d793837a93b223c70d7c9bdde1053b0ef386d8065156de95eb29  guix-build-3e9aca6f1b52/output/x86_64-linux-gnu/bitcoin-3e9aca6f1b52-x86_64-linux-gnu-debug.tar.gz
23fb58336ce100926340776e05c1ec4507835e12d55554fc3e1744700c5409cf2f  guix-build-3e9aca6f1b52/output/x86_64-linux-gnu/bitcoin-3e9aca6f1b52-x86_64-linux-gnu.tar.gz
24d043aa1c97141e57a9fc9c8bb6bd575817b78ab15529624af684776f45c0a55a  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/SHA256SUMS.part
25c44b588e7477483d3ac8d0f33fc3e9bf844444c933361da64dd51d1d41fc3a52  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-codesigning.tar.gz
2637ea405893eefc251b1869fcda0fd6b79c92ce7bfb8abd408151a321ba2e0e54  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-debug.zip
2795c2b3b5bbf2c0fa6a0990373373c1544fa6180fbb44b5d2cc82b86a30ed6499  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-setup-unsigned.exe
2869311914f27a2ad1b8230c7896cccaa7769f1ddbff3816edaa1e5480d993cf95  guix-build-3e9aca6f1b52/output/x86_64-w64-mingw32/bitcoin-3e9aca6f1b52-win64-unsigned.zip

DrahtBot requested review from hebasto on Nov 13, 2025

DrahtBot commented at 8:04 pm on November 13, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 48d4b936e09f82a3bcb65fe5850977e0e526e634(master)	commit e17db9b72f7c940a61e66e14f71662c67c8a3484(pull/33860/merge)
*-aarch64-linux-gnu-debug.tar.gz	`0e91c5296dc9766c...`	`1b3bc86237df81e3...`
*-aarch64-linux-gnu.tar.gz	`23105bbc499bb8e9...`	`24ca4d8442567715...`
*-arm-linux-gnueabihf-debug.tar.gz	`22cca8e9a03f1aea...`	`198514709aa112da...`
*-arm-linux-gnueabihf.tar.gz	`cfc182e78b0ea139...`	`effd4c6827ce10f1...`
*-arm64-apple-darwin-codesigning.tar.gz	`f1f746dbf6ed403b...`	`bbf9c49bf7b5e04c...`
*-arm64-apple-darwin-unsigned.tar.gz	`de23f9fcc20c020b...`	`f032e0078266841f...`
*-arm64-apple-darwin-unsigned.zip	`661a60bd789308f6...`	`f05e03ed1b4dc51c...`
*-powerpc64-linux-gnu-debug.tar.gz	`03c97bd5b6825e68...`	`42db9a44205dc6a0...`
*-powerpc64-linux-gnu.tar.gz	`ff6674675793c7bb...`	`6a94f20b3ca0b475...`
*-riscv64-linux-gnu-debug.tar.gz	`3e95e8b0d774d050...`	`88b6032ec229bd54...`
*-riscv64-linux-gnu.tar.gz	`e0ac9c7cef8ed923...`	`a85bd2d5a97682e9...`
*-x86_64-apple-darwin-codesigning.tar.gz	`23899ddfe9d0ad30...`	`e8b9a1582f28f133...`
*-x86_64-apple-darwin-unsigned.tar.gz	`30592eaa2551f988...`	`fba5a9323f59f7b2...`
*-x86_64-apple-darwin-unsigned.zip	`0afe52ae91b6e406...`	`3d2c44cf4da05597...`
*-x86_64-linux-gnu-debug.tar.gz	`351513a4bd15d7b6...`	`aac209f839f3cd0e...`
*-x86_64-linux-gnu.tar.gz	`42e20003c30e8579...`	`24ee54f7ec892dcc...`
*.tar.gz	`b8a22bded6088192...`	`ef22def645a49c0f...`
SHA256SUMS.part	`e2ca6f17c35f1b04...`	`85b14fd2d9d5bd5a...`
guix_build.log	`2bd54e53dfea5197...`	`aebd85ce12c85d18...`
guix_build.log.diff		`60fc8e2ea486bd19...`

DrahtBot removed the label DrahtBot Guix build requested on Nov 13, 2025

fanquake merged this on Nov 14, 2025

fanquake closed this on Nov 14, 2025

fanquake deleted the branch on Nov 14, 2025

hebasto commented at 12:51 pm on November 14, 2025: member

Post-merge ACK.

I tested using GCC 12 with CMake 3.22 and 3.27.

depends: drop Qt patches #33860

Code Coverage & Benchmarks

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]