refactor: Avoid -W*-whitespace in git archive #33869

1. 
   maflcko commented at 8:41 am on November 13, 2025: member

   Otherwise, compilation with GCC-15+ will warn about it:

   0src/clientversion.cpp:33:79: error: trailing whitespace [-Werror=trailing-whitespace=]
   1   33 | //! git will put "#define GIT_COMMIT_ID ..." on the next line inside archives.
   

   Follow-up to #32482 (comment)

   Can be tested via git archive --output=/tmp/a.tar HEAD

2. refactor: Avoid -W*-whitespace in git archive faf99ae379
3. DrahtBot added the label Refactoring on Nov 13, 2025
4. 
   DrahtBot commented at 8:41 am on November 13, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33869.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   fanquake commented at 9:30 am on November 13, 2025: member

   Should we modify one job to use the archive? We should probably be catching, and minimising any differences, like this, between building from source, and the tarball.
6. 
   maflcko commented at 9:37 am on November 13, 2025: member

   Should we modify one job to use the archive?

   Possibly, but I don’t think any job is running with gcc-15, so the benefits here would be limited. Though, I can modify my nightly matrix to use archives explicitly, instead of by accident of git not being present.

   We should probably be catching, and minimising any differences, like this, between building from source, and the tarball.

   I want to keep the changes here minimal. Reworking this is already tracked in #31999 and the related pulls, so maybe the discussion can continue there?

7. 
   fanquake commented at 10:19 am on November 13, 2025: member

   Possibly, but I don’t think any job is running with gcc-15, so the benefits here would be limited.

   I’m just thinking generally, not about this single warning, or gcc-15. Happy for it to best changed in a followup, or in another related change.

8. ci: Run macos tasks in a git archive, not git checkout

   This confirms that compiling this way is possible at all.

   fa95353902
9. maflcko force-pushed on Nov 13, 2025
10. DrahtBot added the label CI failed on Nov 13, 2025
11. DrahtBot removed the label CI failed on Nov 13, 2025
12. 
    fanquake commented at 11:32 am on November 17, 2025: member

    ACK fa95353902b7a6f73f094e78106088ab3c16ce14

    On a rebased branch:

    0// git will expand the next line to "#define GIT_COMMIT_ID ..." inside archives:
    1//
    2#define GIT_COMMIT_ID "84f39b282de0836ca5ad6166daafecf15e4c813d"
    

    0./build/bin/bitcoind --version
    1Bitcoin Core daemon version v30.99.0-g84f39b282de0836ca5ad6166daafecf15e4c813d bitcoind
    

13. fanquake merged this on Nov 17, 2025
14. fanquake closed this on Nov 17, 2025

    ---

15. maflcko deleted the branch on Nov 17, 2025
16. 
    hebasto commented at 8:28 pm on November 17, 2025: member

    post-merge ACK.

Contributors
maflcko DrahtBot fanquake hebasto

Labels
Refactoring