init: completely remove `-maxorphantx` option #33872

1. 
   theStack commented at 6:00 PM on November 13, 2025: contributor

   This is a small follow-up for #32941 (commit 1384dbaf6d0bfcdb05f97e1e3cb3d5e498bee505), removing the -maxorphantx option completely, now that v30 has been released. If removing it for v31 is seen as controversial/premature (I personally don't think it is), the merge can be delayed for a future release.

2. 
   DrahtBot commented at 6:00 PM on November 13, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33872.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	w0xlt, rkrux, stickies-v, maflcko, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

3. init: completely remove `-maxorphantx` option 0aebdac95d
4. theStack force-pushed on Nov 13, 2025
5. DrahtBot added the label CI failed on Nov 13, 2025
6. maflcko added this to the milestone 31.0 on Nov 13, 2025
7. DrahtBot removed the label CI failed on Nov 13, 2025
8. in doc/release-notes-33872.md:5 in 0aebdac95d

      0 | @@ -0,0 +1,5 @@
      1 | +P2P and network changes
      2 | +-----------------------
      3 | +
      4 | +- The `-maxorphantx` startup option has been removed. It was
      5 | +  previously deprecated and has no effect anymore since v30.0. (#33872)
   

   ---

   ---

   

   w0xlt commented at 9:23 PM on November 13, 2025:

   nit:

     previously deprecated and has no effect anymore since v30.0. (#33872).
     Passing it now causes startup failure.
   

9. 
   w0xlt commented at 9:23 PM on November 13, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/33872/commits/0aebdac95da9a7d476264424c0107bd806ce5362

10. rkrux approved
11. 
    rkrux commented at 10:28 AM on November 14, 2025: contributor

    lgtm ACK 0aebdac95da9a7d476264424c0107bd806ce5362

12. stickies-v approved
13. 
    stickies-v commented at 11:34 AM on November 14, 2025: contributor

    ACK 0aebdac95da9a7d476264424c0107bd806ce5362

14. 
    maflcko commented at 1:48 PM on November 17, 2025: member

    lgtm ACK 0aebdac95da9a7d476264424c0107bd806ce5362

15. 
    achow101 commented at 2:08 AM on November 18, 2025: member

    ACK 0aebdac95da9a7d476264424c0107bd806ce5362

16. achow101 merged this on Nov 18, 2025
17. achow101 closed this on Nov 18, 2025

    ---

18. theStack deleted the branch on Nov 18, 2025

Milestone
31.0