net: Remove unused local_socket_bytes variable in CConnman::GetAddresses() #33894

pull waketraindev wants to merge 1 commits into bitcoin:master from waketraindev:prs/2025-11-getaddresses-unused-code changing 1 files +0 −1
  1. waketraindev commented at 10:04 pm on November 17, 2025: contributor
    The local_socket_bytes variable was never used. Removed it to clean up dead code.
  2. net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` 4d893c0f46
  3. DrahtBot added the label P2P on Nov 17, 2025
  4. DrahtBot commented at 10:04 pm on November 17, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33894.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK mzumsande, theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. mzumsande commented at 10:32 pm on November 17, 2025: contributor

    ACK 4d893c0f46055218d6a2b3d24fbce9f0fb6ddc92

    I forgot to remove this in 94db966a3bb52a3677eb5f762447202ed3889f0f / #33464 (the variable was used before that).

  6. theStack approved
  7. theStack commented at 11:05 pm on November 17, 2025: contributor
    ACK 4d893c0f46055218d6a2b3d24fbce9f0fb6ddc92
  8. fanquake merged this on Nov 18, 2025
  9. fanquake closed this on Nov 18, 2025

  10. waketraindev deleted the branch on Nov 18, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-28 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me