net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` #33894

pull waketraindev wants to merge 1 commits into bitcoin:master from waketraindev:prs/2025-11-getaddresses-unused-code changing 1 files +0 −1
  1. waketraindev commented at 10:04 PM on November 17, 2025: contributor

    The local_socket_bytes variable was never used. Removed it to clean up dead code.

  2. net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` 4d893c0f46
  3. DrahtBot added the label P2P on Nov 17, 2025
  4. DrahtBot commented at 10:04 PM on November 17, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33894.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK mzumsande, theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. mzumsande commented at 10:32 PM on November 17, 2025: contributor

    ACK 4d893c0f46055218d6a2b3d24fbce9f0fb6ddc92

    I forgot to remove this in 94db966a3bb52a3677eb5f762447202ed3889f0f / #33464 (the variable was used before that).

  6. theStack approved
  7. theStack commented at 11:05 PM on November 17, 2025: contributor

    ACK 4d893c0f46055218d6a2b3d24fbce9f0fb6ddc92

  8. fanquake merged this on Nov 18, 2025
  9. fanquake closed this on Nov 18, 2025

  10. waketraindev deleted the branch on Nov 18, 2025
  11. stringintech referenced this in commit 52fffa1e5d on Nov 24, 2025
  12. alexanderwiederin referenced this in commit 7334556a3f on Dec 1, 2025
  13. yuvicc referenced this in commit 4a77a3b8eb on Dec 16, 2025
  14. stickies-v referenced this in commit 9fa736f8e4 on Jan 22, 2026
  15. Kino1994 referenced this in commit 1fccd1a2f6 on Jun 28, 2026
  16. BigcoinBGC referenced this in commit 718908d02b on Jun 30, 2026
  17. Kino1994 referenced this in commit d29ee02630 on Aug 19, 2026
  18. bitcoin locked this on Nov 18, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-20 15:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me