The local_socket_bytes variable was never used. Removed it to clean up dead code.
net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` #33894
pull waketraindev wants to merge 1 commits into bitcoin:master from waketraindev:prs/2025-11-getaddresses-unused-code changing 1 files +0 −1-
waketraindev commented at 10:04 PM on November 17, 2025: contributor
-
net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` 4d893c0f46
- DrahtBot added the label P2P on Nov 17, 2025
-
DrahtBot commented at 10:04 PM on November 17, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33894.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
- theStack approved
-
theStack commented at 11:05 PM on November 17, 2025: contributor
ACK 4d893c0f46055218d6a2b3d24fbce9f0fb6ddc92
- fanquake merged this on Nov 18, 2025
- fanquake closed this on Nov 18, 2025
- waketraindev deleted the branch on Nov 18, 2025
Contributors
Labels