depends: fallback server missing Qt downloads #33898

Looks like https://code.qt.io is down / having issues. None of the files needed from that site are available from the fallback server:

Checksum missing or mismatched for qt source. Forcing re-download.
Fetching qtbase-everywhere-src-6.7.3.tar.xz from https://download.qt.io/archive/qt/6.7/6.7.3/submodules
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   281  100   281    0     0    306      0 --:--:-- --:--:-- --:--:--   306
100 47.1M  100 47.1M    0     0  4687k      0  0:00:10  0:00:10 --:--:-- 7798k
/bitcoin/depends/work/download/qt-6.7.3/qtbase-everywhere-src-6.7.3.tar.xz.temp: OK
Fetching qttranslations-everywhere-src-6.7.3.tar.xz from https://download.qt.io/archive/qt/6.7/6.7.3/submodules
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   289  100   289    0     0    284      0  0:00:01  0:00:01 --:--:--   285
100 1511k  100 1511k    0     0   622k      0  0:00:02  0:00:02 --:--:-- 1430k
/bitcoin/depends/work/download/qt-6.7.3/qttranslations-everywhere-src-6.7.3.tar.xz.temp: OK
Fetching qttools-everywhere-src-6.7.3.tar.xz from https://download.qt.io/archive/qt/6.7/6.7.3/submodules
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   282  100   282    0     0    336      0 --:--:-- --:--:-- --:--:--   336
100 8811k  100 8811k    0     0  2715k      0  0:00:03  0:00:03 --:--:-- 3864k
/bitcoin/depends/work/download/qt-6.7.3/qttools-everywhere-src-6.7.3.tar.xz.temp: OK
Fetching CMakeLists.txt?h=6.7.3 from https://code.qt.io/cgit/qt/qt5.git/plain
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:30 --:--:--     0
curl: (28) Failed to connect to code.qt.io port 443 after 30002 ms: Timeout was reached
Warning: Problem : timeout. Will retry in 1 seconds. 3 retries left.
  0     0    0     0    0     0      0      0 --:--:--  0:00:30 --:--:--     0
curl: (28) Failed to connect to code.qt.io port 443 after 30006 ms: Timeout was reached
Warning: Problem : timeout. Will retry in 2 seconds. 2 retries left.
  0     0    0     0    0     0      0      0 --:--:--  0:00:30 --:--:--     0
curl: (28) Failed to connect to code.qt.io port 443 after 30005 ms: Timeout was reached
Warning: Problem : timeout. Will retry in 4 seconds. 1 retries left.
  0     0    0     0    0     0      0      0 --:--:--  0:00:30 --:--:--     0
curl: (28) Failed to connect to code.qt.io port 443 after 30004 ms: Timeout was reached
Fetching CMakeLists.txt?h=6.7.3 from https://bitcoincore.org/depends-sources
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   146    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
make[1]: *** [funcs.mk:346: /bitcoin/depends/sources/download-stamps/.stamp_fetched-qt-qtbase-everywhere-src-6.7.3.tar.xz.hash] Error 22
make[1]: Leaving directory '/bitcoin/depends'
make: *** [Makefile:276: download-linux] Error 2
make: Leaving directory '/bitcoin/depends'

They are cgit requests, so likely the server is just dos'd by llm bots

The file is located at https://bitcoincore.org/depends-sources/CMakeLists.txt-6.7.3

Not sure how to have download figure that out.

cc @hebasto

I forced fallback downloads using the following patch:

--- a/depends/funcs.mk
+++ b/depends/funcs.mk
@@ -36,8 +36,7 @@ define fetch_file_inner
 endef
 
 define fetch_file
-    ( $(call fetch_file_inner,$(1),$(2),$(3),$(4),$(5)) || \
-      $(call fetch_file_inner,$(1),$(FALLBACK_DOWNLOAD_PATH),$(4),$(4),$(5)))
+      $(call fetch_file_inner,$(1),$(FALLBACK_DOWNLOAD_PATH),$(4),$(4),$(5))
 endef
 
 # Shell script to create a source tarball in $(1)_source from local directory

Everything appears to work as expected:

$ gmake -C depends qt_fetched
gmake: Entering directory '/home/hebasto/dev/bitcoin/depends'
Fetching qtbase-everywhere-src-6.7.3.tar.xz from https://bitcoincore.org/depends-sources
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 47.1M  100 47.1M    0     0  2753k      0  0:00:17  0:00:17 --:--:-- 3259k
/home/hebasto/dev/bitcoin/depends/work/download/qt-6.7.3/qtbase-everywhere-src-6.7.3.tar.xz.temp: OK
Fetching qttranslations-everywhere-src-6.7.3.tar.xz from https://bitcoincore.org/depends-sources
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1511k  100 1511k    0     0   829k      0  0:00:01  0:00:01 --:--:--  829k
/home/hebasto/dev/bitcoin/depends/work/download/qt-6.7.3/qttranslations-everywhere-src-6.7.3.tar.xz.temp: OK
Fetching qttools-everywhere-src-6.7.3.tar.xz from https://bitcoincore.org/depends-sources
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 8811k  100 8811k    0     0  1109k      0  0:00:07  0:00:07 --:--:-- 1706k
/home/hebasto/dev/bitcoin/depends/work/download/qt-6.7.3/qttools-everywhere-src-6.7.3.tar.xz.temp: OK
Fetching CMakeLists.txt-6.7.3 from https://bitcoincore.org/depends-sources
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4041  100  4041    0     0   5121      0 --:--:-- --:--:-- --:--:--  5121
/home/hebasto/dev/bitcoin/depends/work/download/qt-6.7.3/CMakeLists.txt-6.7.3.temp: OK
Fetching ECMOptionalAddSubdirectory.cmake-6.7.3 from https://bitcoincore.org/depends-sources
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3029  100  3029    0     0   3741      0 --:--:-- --:--:-- --:--:--  3739
/home/hebasto/dev/bitcoin/depends/work/download/qt-6.7.3/ECMOptionalAddSubdirectory.cmake-6.7.3.temp: OK
Fetching QtTopLevelHelpers.cmake-6.7.3 from https://bitcoincore.org/depends-sources
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 21633  100 21633    0     0  22979      0 --:--:-- --:--:-- --:--:-- 22964
/home/hebasto/dev/bitcoin/depends/work/download/qt-6.7.3/QtTopLevelHelpers.cmake-6.7.3.temp: OK
gmake: Leaving directory '/home/hebasto/dev/bitcoin/depends'
$ gmake -C depends qt_extracted
gmake: Entering directory '/home/hebasto/dev/bitcoin/depends'
Extracting qt...
/home/hebasto/dev/bitcoin/depends/sources/qtbase-everywhere-src-6.7.3.tar.xz: OK
/home/hebasto/dev/bitcoin/depends/sources/qttranslations-everywhere-src-6.7.3.tar.xz: OK
/home/hebasto/dev/bitcoin/depends/sources/qttools-everywhere-src-6.7.3.tar.xz: OK
/home/hebasto/dev/bitcoin/depends/sources/CMakeLists.txt-6.7.3: OK
/home/hebasto/dev/bitcoin/depends/sources/ECMOptionalAddSubdirectory.cmake-6.7.3: OK
/home/hebasto/dev/bitcoin/depends/sources/QtTopLevelHelpers.cmake-6.7.3: OK
gmake: Leaving directory '/home/hebasto/dev/bitcoin/depends'

Seems like https://code.qt.io also doesn't work with (some?) VPN providers, so we should probably move away from using that.

Seems like https://code.qt.io also doesn't work with (some?) VPN providers, so we should probably move away from using that.

I can see two options:

1. Switch to https://raw.githubusercontent.com/qt/qt5.
2. Treat the three files as patches.