The option was fine, but now that there is a dedicated Alpine Linux task, which uses BusyBox, it seems redundant.
(See: ci/test/00_setup_env_native_alpine_musl.sh)
So remove the USE_BUSY_BOX option, along with the BINS_SCRATCH_DIR env var.
Also includes two small ci-doc fixups.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33903.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
The option was fine, but it never found an issue, IIRC.
I’m not disputing this specific change, but that line of reasoning isn’t valid, as the absence of past errors does not imply their absence in the future. It seems as a form of the appeal to ignorance fallacy.
The option was fine, but it never found an issue, IIRC.
I’m not disputing this specific change, but that line of reasoning isn’t valid, as the absence of past errors does not imply their absence in the future. It seems as a form of the appeal to ignorance fallacy.
Thx, removed the line from the pull description. It being redundant is the real reason, also put in the pull title. It not having found an issue is more a “fun-fact” I wanted to highlight.
This is not needed in combination with the outer env.
No other task has in its name whether it is using depends or not, so
remove it here as well.
The option was fine, but now that there is a dedicated Alpine Linux
task, which uses BusyBox, it seems redundant.
(See: ci/test/00_setup_env_native_alpine_musl.sh)
So remove the USE_BUSY_BOX option, along with the BINS_SCRATCH_DIR env
var.
Also, enable pipefail in the ci/test/00_setup_env.sh script, while
touching it.