qa: Remove no longer needed feature_dirsymlinks.py #33924

1. 
   hebasto commented at 3:56 pm on November 22, 2025: member

   This PR follows up on #33842, which removed (1) the unused create_directories workaround and (2) the corresponding unit test, but left the related functional test in place. The latter is now being removed.

   For historical context, see:

   • #24338
   • https://github.com/bitcoin/bitcoin/pull/33842
2. qa: Remove no longer needed `feature_dirsymlinks.py`

   This test has become redundant following https://github.com/bitcoin/bitcoin/pull/33842.

   b50edfc72d
3. hebasto added the label Tests on Nov 22, 2025
4. 
   DrahtBot commented at 3:56 pm on November 22, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33924.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   No conflicts as of last run.

5. 
   maflcko commented at 4:54 pm on November 22, 2025: member

   Being able to symlink the dir seems like a Bitcoin Core feature that should be supported and tested?
6. 
   hebasto commented at 9:40 pm on November 22, 2025: member

   Being able to symlink the dir seems like a Bitcoin Core feature that should be supported and tested?

   If “a Bitcoin Core feature” is taken to mean something explicitly implemented in the Bitcoin Core codebase, then this PR would indeed reduce test coverage. But that is not the case here.

7. 
   maflcko commented at 8:47 am on November 27, 2025: member

   Yeah, I guess there may not be a reduced path coverage inside Bitcoin Core right now, but will it always be that case in the future?

   Is there some other benefit to removing the test?

8. 
   hebasto commented at 9:52 am on November 27, 2025: member

   Yeah, I guess there may not be a reduced path coverage inside Bitcoin Core right now, but will it always be that case in the future?

   I think so, as long as Bitcoin Core relies on the C++ filesystem library.

   Is there some other benefit to removing the test?

   The only reason to remove it is that it does not test any Bitcoin Core–specific functionality. It is simply a logical reversal of the principle that a test should not be added if it verifies nothing of our own.

9. 
   fanquake commented at 10:22 am on December 5, 2025: member

   ~0. Seems fine to leave this for now.
10. hebasto closed this on Dec 5, 2025

    ---

Contributors
hebasto DrahtBot maflcko fanquake

Labels
Tests