test: Remove system_tests/run_command runtime dependencies #33929

1. 
   hebasto commented at 11:03 pm on November 23, 2025: member

   system_tests currently rely on cat, echo, false and sh being available in PATH at runtime.

   This PR:

   1. Removes these dependencies.
   2. Reduces the number of platform-specific code paths.

   The change is primarily motivated by my work on maintaining the bitcoin-core package in Guix. It enables the removal of the existing bash and coreutils native inputs, which in turn makes it possible to drop the implicit dependency on qtbase@5 (see https://codeberg.org/guix/guix/pulls/4386#issuecomment-8613333).

2. test: Remove `system_tests/run_command` runtime dependencies a4144ac1d6
3. test: Enable `system_tests/run_command` "stdin" test on Windows c996515a6d
4. hebasto added the label Tests on Nov 23, 2025
5. 
   DrahtBot commented at 11:03 pm on November 23, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33929.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #33483 (CMake: Add dynamic test discovery by purpleKarrot)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. in src/test/system_tests.cpp:26 in c996515a6d

   21 
   22 #ifdef ENABLE_EXTERNAL_SIGNER
   23 
   24 BOOST_AUTO_TEST_CASE(run_command)
   25 {
   26+    const std::string test_executable = std::string(boost::unit_test::framework::master_test_suite().argv[0]).append(" --log_level=nothing --report_level=no --run_test=mock_process/");
   

   ---

   ---

   

   maflcko commented at 8:45 pm on December 4, 2025:

   nit: This will fail with spaces in the dir:

   0$ ./a\ space/test_bitcoin -t system_tests
   1Running 1 test case...
   2unknown location(0): fatal error: in "system_tests/run_command": subprocess::CalledProcessError: execve failed: No such file or directory (2)
   3test/system_tests.cpp(29): last checkpoint
   4
   5*** 1 failure is detected in the test module "Bitcoin Core Test Suite"
   

7. maflcko approved
8. 
   maflcko commented at 8:45 pm on December 4, 2025: member

   would be nice to fix the space error, but not sure how easy that is.

   review ACK c996515a6dcb158d2d3aa88efc499ffff49bea79 🚆

   Signature:

   0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
   1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
   2trusted comment: review ACK c996515a6dcb158d2d3aa88efc499ffff49bea79 🚆
   3tIPkSDEjaEB97BQIv8sM9m414fm5sxxOHHqLWNWGBf6fsHuOwabixwP9VIGmJHyf+ljEBjgD2gIKL2G+psZMAA==
   

Contributors
hebasto DrahtBot maflcko

Labels
Tests