ci: Use latest Xcode that the minimum macOS version allows #33932

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2511-ci-xcode-macos-min-latest changing 1 files +3 −3
  1. maflcko commented at 8:34 am on November 24, 2025: member
    Changing the CI policy to use the latest Xcode (instead of the earliest), allowed by the Bitcoin Core minimum supported macOS version, makes sense: While this may require the developer or user to install a later security point-release on macOS, this should generally be fine and it is even expected that users run the latest supported security release of their operating system. Also, in practise, this often doesn’t result in a visible change anyway: This specific change from Xcode 16.0 to 16.2 does not change any behavior of the Bitcoin Core CI, because there are no C++-related changes in those point releases.
  2. ci: Use latest Xcode that the minimum macOS version allows fa9537cde1
  3. DrahtBot added the label Tests on Nov 24, 2025
  4. DrahtBot commented at 8:34 am on November 24, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33932.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK vasild, fanquake, l0rinc

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. vasild approved
  6. vasild commented at 11:49 am on November 24, 2025: contributor
    ACK fa9537cde10120b12c96061cbc3f79a7680f9d64
  7. fanquake approved
  8. l0rinc commented at 3:17 pm on November 24, 2025: contributor

    This probably doesn’t help #29415 (review), the <=> is not fixed in 16.2 yet, only in 16.3. And it seems this isn’t the source of that error, we’re explicitly downloading version 15 there:

    22.23 + retry – curl –location –fail bitcoincore.org/depends-sources/sdks/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz -o /home/runner/work/_temp/depends/sdk-sources/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz

    Do we have to keep those or can we bump them to 16? That might also enable us using std::jthread in a few places… I don’t mind pushing a PR for it if there’s a conceptual agreement it’s what we want.

  9. maflcko commented at 3:56 pm on November 24, 2025: member

    This probably doesn’t help #29415 (comment), the <=> is not fixed in 16.2 yet, only in 16.3.

    Correct. This diff here does not change any behavior of the Bitcoin Core CI, as explained in the description.

    Do we have to keep those or can we bump them to 16?

    Yeah, it should be possible to bump to the latest version. Though, it may be best to first make it deterministic: #32009. Otherwise, it will be harder to re-create. Though, changing the Xcode used for releases seems unrelated to this pull, which is about using the latest Xcode for the minimum macOS version.

  10. l0rinc commented at 4:44 pm on November 24, 2025: contributor
    ACK fa9537cde10120b12c96061cbc3f79a7680f9d64
  11. fanquake merged this on Nov 25, 2025
  12. fanquake closed this on Nov 25, 2025

  13. maflcko deleted the branch on Nov 25, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-01 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me