depends, doc: Add tcl as build dependency for sqlite package #33975

1. 
   hebasto commented at 10:26 pm on November 30, 2025: member

   Since #32655, the sqlite package has relied on a native C compiler being incidentally available on the system under the default names. However, this is not always the case. For example, on Ubuntu 24.04:

   0$ gmake -C depends sqlite CC=gcc-14 CXX=g++-14
   1gmake: Entering directory '/bitcoin/depends'
   2Configuring sqlite...
   3No installed jimsh or tclsh, building local bootstrap jimsh0
   4No working C compiler found. Tried cc and gcc.
   5gmake: *** [funcs.mk:344: /bitcoin/depends/x86_64-pc-linux-gnu/.sqlite_stamp_configured] Error 1
   6gmake: Leaving directory '/bitcoin/depends'
   

   Adding the tcl package as an explicit build dependency, as is done in the Guix script, avoids this behaviour and improves robustness.

2. depends, doc: Add `tcl` as build dependency for `sqlite` package 632cf872a5
3. hebasto added the label Docs on Nov 30, 2025
4. hebasto added the label Build system on Nov 30, 2025
5. 
   DrahtBot commented at 10:26 pm on November 30, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33975.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, janb84

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #33902 (doc: Document compiler configuration for native depends packages by willcl-ark)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. in depends/README.md:11 in 632cf872a5

    7@@ -8,7 +8,7 @@ as well as [packages.md](packages.md) for how to add packages.
    8 
    9 ### Ubuntu & Debian
   10 
   11-    apt install cmake curl make patch
   12+    apt install cmake curl make patch tcl
   

   ---

   ---

   

   hebasto commented at 10:33 pm on November 30, 2025:

   FWIW, jimsh works as well.

   tcl is chosen for consistency with the Guix script.

7. 
   maflcko commented at 7:48 am on December 1, 2025: member

   lgtm ACK 632cf872a584e4a373a669aca5b885f63a2b7add
8. maflcko added this to the milestone 31.0 on Dec 1, 2025
9. 
   janb84 commented at 4:00 pm on December 1, 2025: contributor

   This doesn’t work for me on ubuntu 24.04, if I only install what is specified and then execute:

   0gmake -C depends sqlite CC=gcc-14 CXX=g++-14
   

   it will fail to find C compiler (with the error state above), I needed to install g++:

   0apt install g++ 
   

   But it will install g++13 so I needed to run :

   0gmake -C depends sqlite CC=gcc-13 CXX=g++-13
   

10. 
    hebasto commented at 5:45 pm on December 1, 2025: member

    @janb84

    This doesn’t work for me on ubuntu 24.04, if I only install what is specified and then execute:

    0gmake -C depends sqlite CC=gcc-14 CXX=g++-14
    

    The example above assumes that the gcc-14 and g++-14 packages are installed.

11. 
    janb84 commented at 5:57 pm on December 1, 2025: contributor

    @janb84

    This doesn’t work for me on ubuntu 24.04, if I only install what is specified and then execute:

    0gmake -C depends sqlite CC=gcc-14 CXX=g++-14
    

    The example above assumes that the gcc-14 and g++-14 packages are installed.

    Ah Sorry, my mistake, took your example to literally.

12. 
    janb84 commented at 5:59 pm on December 1, 2025: contributor

    ACK 632cf872a584e4a373a669aca5b885f63a2b7add

    PR adds tcl as package to install in order to be able to compile depends. (specific case sqlite) Have confirmed change on ubuntu 24.04

13. 
    fanquake commented at 10:18 am on December 2, 2025: member

    Can we just pass the compiler through?
14. 
    hebasto commented at 2:50 pm on December 2, 2025: member

    Can we just pass the compiler through?

    See #33995.

15. fanquake removed this from the milestone 31.0 on Dec 3, 2025
16. 
    hebasto commented at 3:25 pm on December 3, 2025: member

    Can we just pass the compiler through?

    See #33995.

    Closing in favour of #33995.

17. hebasto closed this on Dec 3, 2025

    ---

18. fanquake referenced this in commit e68517208b on Dec 5, 2025
19. hebasto deleted the branch on Dec 5, 2025

Contributors
hebasto DrahtBot maflcko janb84 fanquake

Labels
Docs Build system