rpc: Reject distinct transactions in combinerawtransaction #34024

1. 
   mossein commented at 10:17 pm on December 6, 2025: none

   Previously, combinerawtransaction silently processed only the first transaction when given unrelated transactions as input, ignoring the rest. This could be confusing and lead to unexpected behavior.

   This change adds validation to ensure all transactions passed to combinerawtransaction have the same base structure (same inputs and outputs), throwing RPC_INVALID_PARAMETER if they differ.

   Fixes #25980

2. rpc: Reject distinct transactions in combinerawtransaction

   Previously, combinerawtransaction silently processed only the first
   transaction when given unrelated transactions as input, ignoring
   the rest. This could be confusing and lead to unexpected behavior.
   
   This change adds validation to ensure all transactions passed to
   combinerawtransaction have the same base structure (same inputs and
   outputs), throwing RPC_INVALID_PARAMETER if they differ.
   
   Fixes #25980

   2bf6a53365
3. DrahtBot added the label RPC/REST/ZMQ on Dec 6, 2025
4. 
   DrahtBot commented at 10:17 pm on December 6, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34024.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

5. mossein closed this on Dec 6, 2025

   ---

Contributors
mossein DrahtBot

Labels
RPC/REST/ZMQ