The libraries design document was out of sync with the current bitcoinkernel implementation and its consumers. It claimed that libbitcoin_node links against libbitcoin_kernel and that the kernel library only depends on consensus, crypto, and util, which is not true for the current CMake targets.
doc: clarify libbitcoinkernel usage in libraries design #34042
pull Galoretka wants to merge 1 commits into bitcoin:master from Galoretka:doc/clarify-libbitcoinkernel-libraries changing 1 files +5 −5-
Galoretka commented at 2:52 PM on December 10, 2025: none
-
doc: clarify libbitcoinkernel usage in libraries design 54073e74a4
- DrahtBot added the label Docs on Dec 10, 2025
-
DrahtBot commented at 2:52 PM on December 10, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34042.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28690 (build: Introduce internal kernel library by sedited)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
sedited commented at 4:14 PM on December 10, 2025: contributor
- fanquake marked this as a draft on Dec 17, 2025