kernel: Remove non-kernel module includes #34079

pull sedited wants to merge 2 commits into bitcoin:master from sedited:kernelPruneHeaders changing 7 files +25 −23
  1. sedited commented at 9:30 pm on December 15, 2025: contributor
    Found these while attempting to isolate the kernel library sources into their own repository. There still is no mechanism for preventing including headers into the kernel library that don’t belong to kernel modules, but it is also fairly straight forward to correct manually for now. However, the changes here might be incomplete.
  2. kernel: Remove some unnecessary non-kernel includes
    Specifically gets rid of batchpriority, chainparams, and system includes
    d048ad3e17
  3. DrahtBot added the label Validation on Dec 15, 2025
  4. DrahtBot commented at 9:31 pm on December 15, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34079.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK hebasto

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #33779 (ci, iwyu: Fix warnings in src/kernel and treat them as errors by hebasto)
    • #30214 (refactor: Improve assumeutxo state representation by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. kernel: Move BlockInfo to a kernel file 5b6bc717ef
  6. sedited force-pushed on Dec 15, 2025
  7. DrahtBot added the label CI failed on Dec 15, 2025
  8. DrahtBot commented at 10:09 pm on December 15, 2025: contributor

    🚧 At least one of the CI tasks failed. Task tidy: https://github.com/bitcoin/bitcoin/actions/runs/20248118058/job/58133590667 LLM reason (✨ experimental): IWYU check failed (include/dependency issues detected) causing the CI to fail.

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  9. hebasto commented at 10:42 pm on December 15, 2025: member
    Concept ACK.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-17 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me