contrib: asmap-tool.py - Don’t write binary to TTY #34089

1. 
   hodlinator commented at 2:04 pm on December 17, 2025: contributor

   Verify that we wouldn’t be writing encoded asmap binary data directly to the TTY since it is the default but makes no sense. (Having stdout as default does make sense when piping to other applications however).

   Found while exploring the ASMap data pipeline (https://github.com/asmap/asmap-data/pull/38#pullrequestreview-3547352533) from Kartograf into Bitcoin Core.

2. contrib: Avoid outputting binary data to TTY e7e51952dc
3. DrahtBot added the label Scripts and tools on Dec 17, 2025
4. 
   DrahtBot commented at 2:04 pm on December 17, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34089.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipa, fjahr

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. 
   fanquake commented at 2:06 pm on December 17, 2025: member

   cc @fjahr
6. 
   sipa commented at 2:44 pm on December 17, 2025: member

   ACK e7e51952dc24531932b6c06e4599be3a3d6bede8
7. 
   fjahr commented at 3:13 pm on December 17, 2025: contributor

   tACK e7e51952dc24531932b6c06e4599be3a3d6bede8

   Thanks for continuing to test this data pipeline!

   0$ ./contrib/asmap/asmap-tool.py encode ../../python/kartograf/out/1765638546/final_result.txt
   1Not much use in writing binary to a TTY. Please specify an output file or pipe output to another process.
   

8. fanquake merged this on Dec 17, 2025
9. fanquake closed this on Dec 17, 2025

   ---

Contributors
hodlinator DrahtBot fanquake sipa fjahr

Labels
Scripts and tools