mlock() all private keys in memory #341

pull nobled wants to merge 1 commits into bitcoin:master from nobled:seckeys changing 1 files +22 −1
  1. nobled commented at 3:27 AM on June 24, 2011: contributor

    Inline comment about VirtualLock() and general idea come from Matt Corallo's encprivkeys branch. By adding it to the custom allocator like this though, it's done for us on all CPrivKey objects automagically.

  2. mlock() all private keys in memory
    Inline comment and idea come from the encprivkeys branch
    by Matt Corallo <matt@bluematt.me>.
    c6563285a9
  3. sipa commented at 10:36 AM on June 24, 2011: member

    I like this, but an munlock() call should be issued when deallocating, after clearing the memory.

  4. gavinandresen commented at 4:06 PM on June 24, 2011: contributor

    Good idea; add a munlock and rebase and looks to me like it's ready to pull.

  5. TheBlueMatt commented at 4:54 PM on June 24, 2011: member

    Been doing similar stuff for new wallet crypter, with more stuff mlocked, but looks good to me (once munlock()d) edit: oh, I need to read, anyway, looks good to me.

  6. TheBlueMatt commented at 10:19 PM on June 26, 2011: member

    Because I depend on this for the new encryption branch, I went ahead and did the munlock stuff, current version is at ee286b3ced9c80c12c369ccceb21ec287f24306b

  7. jgarzik commented at 2:13 AM on July 13, 2011: contributor

    superceded

  8. jgarzik closed this on Jul 13, 2011

  9. dexX7 referenced this in commit 3b2968ede0 on Feb 12, 2016
  10. ptschip referenced this in commit 1b57e3dfcf on Mar 7, 2017
  11. classesjack referenced this in commit c19b300087 on Jan 2, 2018
  12. attilaaf referenced this in commit c2f723940c on Jan 13, 2020
  13. rajarshimaitra referenced this in commit bc54811d12 on Aug 5, 2021
  14. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 06:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me