Replace the manual operator== and friend operator<=> in src/script/verify_flags.h with a defaulted member operator<=>.
This reduces boilerplate while preserving the existing semantics (m_value comparison) and continues to provide ==, <, >, <=, and >= via the compiler-generated comparison operators.
Note: This is a small refactor, but it removes duplicated comparison logic and reduces the chance of == and <=> diverging in future edits. If that’s not considered worthwhile, I can close/drop it.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34122.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | billymcbip |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
51 | - /** Compare two script_verify_flags. <, >, <=, and >= are auto-generated from this. */ 52 | - friend constexpr std::strong_ordering operator<=>(const script_verify_flags& a, const script_verify_flags& b) noexcept 53 | - { 54 | - return a.m_value <=> b.m_value; 55 | - } 56 | + constexpr auto operator<=>(const script_verify_flags& other) const = default;
Can you use std::strong_ordering instead of auto?
I'm getting a Included header compare is not used directly lint warning for #include <compare> when using auto.
Done!
Replace the manual operator== and friend operator<=> in src/script/verify_flags.h
with a defaulted member operator<=>.
This reduces boilerplate while preserving the existing semantics (m_value
comparison) and continues to provide ==, <, >, <=, and >= via the
compiler-generated comparison operators.
tACK eaf2f07e42ac3574ea4b1b2fc9a5d11d3ab6ded2
I'm not convinced that this is worthwhile. For such a tiny refactor it has also not attracted much review over the past month. I think we can switch to a defaulted space ship operator when there is a need for it.
Closing for now. Looks like this may be controversial.