test: Allow mempool_updatefromblock.py to run on 32-bit #34136

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2512-test-32-bit changing 2 files +10 −7
  1. maflcko commented at 10:59 AM on December 22, 2025: member

    The number of dropped parent transactions in the test_max_disconnect_pool_bytes test was hard-coded to 2.

    This happens to work fine on 64-bit for now. However, it seems to fail on 32-bit (https://github.com/bitcoin/bitcoin/issues/34108).

    I don't think we care about the exact number, as long as it is at least 1.

    So hard-code 1 for an initial sanity check, and then calculate the exact value at runtime via len(mempool) // 2.

    Also, enable the functional tests in 32-bit CI, to confirm the regression test.

    Fixes https://github.com/bitcoin/bitcoin/issues/34108

  2. test: Allow mempool_updatefromblock.py to run on 32-bit fac5a1b10a
  3. DrahtBot added the label Tests on Dec 22, 2025
  4. DrahtBot commented at 10:59 AM on December 22, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34136.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK bensig, instagibbs

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. bensig commented at 7:26 PM on January 2, 2026: contributor

    ACK fac5a1b10a

    Tested locally - mempool_updatefromblock.py passes.

  6. maflcko requested review from instagibbs on Jan 5, 2026
  7. instagibbs commented at 2:21 PM on January 5, 2026: member

    ACK fac5a1b10a6979a7898c5c3555d62b593560772f

  8. fanquake merged this on Jan 5, 2026
  9. fanquake closed this on Jan 5, 2026

  10. maflcko deleted the branch on Jan 5, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me