[30.x] Backports #34192

pull fanquake wants to merge 9 commits into bitcoin:30.x from fanquake:30_2_backports changing 13 files +82 −63
  1. fanquake commented at 3:24 pm on January 2, 2026: member
  2. build: Update minimum required Boost version
    Building with Boost 1.73.0 is broken.
    
    Github-Pull: #34107
    Rebased-From: f480c1e7177744d11b058c3a9422975d7ec1af46
    7ea855fd55
  3. guix: reduce allowed exported symbols
    Github-Pull: #33950
    Rebased-From: 7b90b4f5bb10e2156709b07e3996f867e2421232
    b734c4026b
  4. fuzz: doc: remove any mention to address_deserialize_v2
    Github-Pull: #34091
    Rebased-From: caf4843a59a9d2512d69f8fd88a9672112bd80ac
    f620dde411
  5. DrahtBot added the label Backport on Jan 2, 2026
  6. DrahtBot commented at 3:24 pm on January 2, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34192.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK willcl-ark, marcofleon

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  7. doc: update copyright year
    Github-Pull: #34174
    Rebased-From: b23b901363c56043c536f32261ac8cb540624a84
    ed0774bd08
  8. doc: Update OpenBSD Build Guide
    Github-Pull: #34182
    Rebased-From: 84d8c52662545b33c0d02c8ac02ae694950ad9d4
    8769c718f4
  9. test: Test SIGTERM handling during waitforblockheight call
    Currently when CTRL-C is pressed and there is an active `waitforblockheight`,
    or `waitforblock`, or `waitfornewblock` RPC call, or a mining interface
    `waitTipChanged` IPC call with a long timeout, the node will not shut down
    right away, and will wait for the timeout to be reached before exiting.
    
    This behavior is not ideal and only happens when the node is stopped with
    CTRL-C or SIGTERM. When the node is stopped with `bitcoin-cli stop`, the wait
    calls are interrupted and the node does shut down right away.
    
    The next commit improves node behavior. This commit just adds test coverage to
    simplify the next commit and clarify the change in behavior there.
    
    Github-Pull: #33511
    Rebased-From: 6a29f79006a9d60b476893dface5eea8f9bf271c
    6983c7d769
  10. init: Signal m_tip_block_cv on Ctrl-C
    Signal m_tip_block_cv when Ctrl-C is pressed or SIGTERM is received, the same
    way it is currently signalled when the `stop` RPC is called. This lets RPC
    calls like `waitforblockheight` and IPC calls like `waitTipChanged` be
    interrupted, instead of waiting for their original timeouts and delaying
    shutdown.
    
    Historical notes:
    
    - The behavior where `stop` RPC signals `m_tip_block_cv`, but CTRL-C does not,
      has been around since the condition variable was introduced in #30409
      (7eccdaf16081d6f624c4dc21df75b0474e049d2b).
    - The signaling was later moved without changing behavior in #30967
      (5ca28ef28bcca1775ff49921fc2528d9439b71ab). This commit moves it again to
      the Interrupt() function, which is probably the place it should have been
      added initially, so it works for Ctrl-C shutdowns as well as `stop`
      shutdowns.
    - A Qt shutdown bug calling wait methods was fixed previously in #18452
      (da73f1513a637a9f347b64de66564d6cdb2541f8), and this change updates that
      fix to avoid the hang happening again in Qt.
    
    Github-Pull: #33511
    Rebased-From: c25a5e670b27d3b6eb958ce437dbe89678bd1511
    c065bcd2d7
  11. fanquake force-pushed on Jan 5, 2026
  12. test: Avoid hard time.sleep(1) in feature_init.py
    Github-Pull: #34137
    Rebased-From: fa727e3ec984106371eeedb34d7bbbbc3dcce4ff
    7568bc3ab0
  13. doc: update release notes for v30.x f22122bc27
  14. fanquake force-pushed on Jan 5, 2026
  15. fanquake marked this as ready for review on Jan 5, 2026
  16. fanquake requested review from marcofleon on Jan 5, 2026
  17. willcl-ark approved
  18. willcl-ark commented at 1:37 pm on January 5, 2026: member

    ACK f22122bc27b52f4d82fb0a79e5e145f1e4112732

    These backports all look good to me 👍🏼

  19. fanquake added this to the milestone 30.2 on Jan 5, 2026
  20. marcofleon approved
  21. marcofleon commented at 5:18 pm on January 5, 2026: contributor
    ACK f22122bc27b52f4d82fb0a79e5e145f1e4112732
  22. fanquake merged this on Jan 5, 2026
  23. fanquake closed this on Jan 5, 2026

  24. fanquake deleted the branch on Jan 5, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-07 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me