miniminer: stop assuming ancestor fees >= self fees #34235

1. 
   glozow commented at 3:58 pm on January 8, 2026: member

   These assertions exist to detect double-deducting values when we update descendants. However, negative fees are possible with prioritisetransaction so it doesn’t make sense to check this.

   Leave the check for sizes because those are never negative.

   Fixes #34234

2. [miniminer] stop assuming ancestor fees >= self fees

   Negative fees are possible with prioritisetransaction.

   2cade5d5d1
3. 
   DrahtBot commented at 3:58 pm on January 8, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34235.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	instagibbs, dergoegge

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

4. instagibbs approved
5. 
   instagibbs commented at 5:47 pm on January 8, 2026: member

   ACK 2cade5d5d17010cd89855b26da350d6e54683805
6. dergoegge approved
7. 
   dergoegge commented at 11:00 am on January 9, 2026: member

   utACK 2cade5d5d17010cd89855b26da350d6e54683805
8. fanquake merged this on Jan 9, 2026
9. fanquake closed this on Jan 9, 2026

   ---

Contributors
glozow DrahtBot instagibbs dergoegge