verify-commits: Allow specific commits to allow sha1 #34246

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:verify-commits-sha1-exceptions changing 2 files +5 −0
  1. achow101 commented at 0:29 am on January 10, 2026: member

    Allow specific commits to not require the sha1 check.

    Fixes the CI for aeaa67a9eac0decb89c60a67f9755ca10cbcc1d9 which uses SHA1 somewhere in the key’s self signatures.

  2. contrib: verify-commits sha1 exceptions
    Allow some commits to not require the sha1 check.
    8ac134be5e
  3. DrahtBot commented at 0:29 am on January 10, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34246.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge, darosior

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  4. dergoegge approved
  5. dergoegge commented at 9:44 am on January 12, 2026: member

    utACK 8ac134be5e57680eb1c6ef596e5de085825e83ee

    Seems fine to document and fix it this way

  6. darosior approved
  7. darosior commented at 3:02 pm on January 12, 2026: member
    utACK 8ac134be5e57680eb1c6ef596e5de085825e83ee. Looks good to me provided we want to avoid the temporary red CI on master branch.
  8. glozow merged this on Jan 13, 2026
  9. glozow closed this on Jan 13, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-21 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me