. #34277

1. 
   EricGrill commented at 5:36 pm on January 13, 2026: none

   .
2. rpc: validate transactions in combinerawtransaction are variants

   Add validation to ensure all transactions passed to combinerawtransaction
   are actually variants of the same transaction (same inputs and outputs,
   differing only in signatures).
   
   Previously, passing distinct/unrelated transactions would silently use
   the first transaction as the base and ignore the structure of others,
   producing confusing results. Now it throws a clear error message
   explaining that all transactions must be variants of the same transaction.
   
   Fixes #25980
   
   Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

   42a3f7f045
3. DrahtBot added the label RPC/REST/ZMQ on Jan 13, 2026
4. 
   DrahtBot commented at 5:37 pm on January 13, 2026: contributor

   ♻️ Automatically closing for now based on heuristics. Please leave a comment, if this was erroneous. Generally, please focus on creating high-quality, original content that demonstrates a clear understanding of the project’s requirements and goals.

   📝 Moderators: If this is spam, please replace the title with ., so that the thread does not appear in search results.

5. DrahtBot closed this on Jan 13, 2026

   ---

6. 
   DrahtBot commented at 5:37 pm on January 13, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34277.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

7. 
   EricGrill commented at 5:42 pm on January 13, 2026: none

   This PR addresses a real issue (#25980) that has been open since 2022. The bug causes combinerawtransaction to silently accept unrelated transactions and produce confusing results instead of returning an error.

   The fix adds validation to ensure all provided transactions are variants of the same base transaction (same inputs/outputs, differing only in signatures). This was discussed in the original issue and is a straightforward defensive programming improvement.

   Could this please be reopened for review?

8. 
   EricGrill commented at 5:52 am on January 14, 2026: none

   I’d like to request reconsideration for this PR.

   Unlike my other PRs which duplicated existing work, issue #25980 (which this addresses) doesn’t appear to have an active PR. The issue has been open since 2022 and describes a real problem where combinerawtransaction silently accepts unrelated transactions, producing confusing results.

   The fix adds straightforward validation to ensure all transactions share the same inputs/outputs structure before combining. This is defensive programming that prevents user confusion without changing any existing behavior for valid inputs.

   Happy to address any technical feedback on the implementation.

9. 
   maflcko commented at 7:06 am on January 14, 2026: member

   I’d like to request reconsideration for this PR.

   Unlike my other PRs which duplicated existing work, issue #25980 (which this addresses) doesn’t appear to have an active PR.

   Yes, it does. Please read the issue comments.

   The fix adds straightforward validation to ensure all transactions share the same inputs/outputs structure before combining. This is defensive programming that prevents user confusion without changing any existing behavior for valid inputs.

   You are not even adding tests.

   Happy to address any technical feedback on the implementation.

   Instead of asking for feedback on purely LLM generated code in a duplicate pull request, it would be more useful to provide actual and meaningful review on the existing pull request. If anyone wanted to look at LLM generated code, they could just ask an LLM to generate it for them.

10. fanquake renamed this:
    rpc: validate transactions in combinerawtransaction are variants
    .
    on Jan 15, 2026
11. DrahtBot removed the label RPC/REST/ZMQ on Jan 15, 2026
12. bitcoin locked this on Jan 15, 2026

Contributors
EricGrill DrahtBot maflcko