. #34278
pull EricGrill wants to merge 1 commits into bitcoin:master from EricGrill:fix/gen-manpages-build-checks-17506 changing 1 files +32 −0-
EricGrill commented at 5:38 pm on January 13, 2026: none.
-
ef6c22e245
devtools: check build options in gen-manpages.py
Add validation to gen-manpages.py that checks test/config.ini for required build components. The script now warns if ENABLE_WALLET or ENABLE_ZMQ are not enabled, as man pages generated without these features will be missing documentation for their respective options. This helps prevent committing incomplete man pages that don't document all available options like -wallet, -disablewallet, -zmqpubhashtx, etc. Fixes #17506 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
-
DrahtBot commented at 5:38 pm on January 13, 2026: contributor
♻️ Automatically closing for now based on heuristics. Please leave a comment, if this was erroneous. Generally, please focus on creating high-quality, original content that demonstrates a clear understanding of the project’s requirements and goals.
📝 Moderators: If this is spam, please replace the title with
., so that the thread does not appear in search results. -
DrahtBot closed this on Jan 13, 2026
-
DrahtBot commented at 5:38 pm on January 13, 2026: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34278.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
EricGrill commented at 5:42 pm on January 13, 2026: none
This PR addresses issue #17506 which has been open since 2019. The issue specifically requests that
gen-manpages.pycheck build options to ensure complete documentation.The fix implements the approach suggested by @laanwj in the issue discussion - checking
test/config.inifor required components (ENABLE_WALLET, ENABLE_ZMQ) and warning if they’re missing.Could this please be reopened for review?
-
fanquake renamed this:
devtools: check build options in gen-manpages.py
.
on Jan 15, 2026 -
bitcoin locked this on Jan 15, 2026
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-15 03:13 UTC
More mirrored repositories can be found on mirror.b10c.me