doc: Document IWYU workaround #34308

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260115-doc-iwyu changing 1 files +3 −0
  1. hebasto commented at 2:47 pm on January 15, 2026: member

    This PR addresses the following comments:

    • #34079 (review):

      it would be good to reduce and report this bug upstream. Otherwise, wide-spread use of iwyu in this code-base seems risky.

    • #34079 (review):

      Would have been good if it was documented, rather than adding undocumented workarounds for buggy tools.

  2. hebasto added the label Docs on Jan 15, 2026
  3. DrahtBot commented at 2:47 pm on January 15, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34308.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, sedited

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34296 (refactor: [move-only] Merge core_io module, remove from libkernel by maflcko)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. fanquake commented at 4:42 pm on January 15, 2026: member
    Seems fine, and thanks for reporting upstream, however this include might also just be deleted as part of #34296.
  5. hebasto commented at 5:36 pm on January 15, 2026: member

    … however this include might also just be deleted as part of #34296.

    It remains there: https://github.com/bitcoin/bitcoin/blob/fa93e014c8a3482c3084f88b7fe4734022633398/src/core_io.cpp#L13

  6. doc: Document IWYU workaround 03f363d378
  7. hebasto force-pushed on Jan 19, 2026
  8. hebasto commented at 5:06 pm on January 19, 2026: member
    Rebased to resolve a conflict with the merged bitcoin/bitcoin#34296.
  9. maflcko commented at 5:19 pm on January 19, 2026: member

    lgtm ACK 03f363d37884fe68d2f84a3def3fd6fe7bf4a506

    This is adding a comment

  10. sedited approved
  11. sedited commented at 5:24 pm on January 19, 2026: contributor
    ACK 03f363d37884fe68d2f84a3def3fd6fe7bf4a506
  12. fanquake merged this on Jan 20, 2026
  13. fanquake closed this on Jan 20, 2026

  14. hebasto deleted the branch on Jan 20, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-22 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me