test: clean up tx resurrection (re-org) test in feature_block.py #34361

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202601-test-feature_block_resurrect_cleanup changing 1 files +7 −14
  1. theStack commented at 4:08 am on January 21, 2026: contributor

    The following comment about ECDSA signatures created with the test framework not passing mempool policy has been obsolete for a long time (at least since 2019, see PR #15826):

    https://github.com/bitcoin/bitcoin/blob/8c07800b193e94740a20f40d3e7c6626a59dd21f/test/functional/feature_block.py#L1167-L1172

    so remove it. While at it, change the resurrected txs to be indeed standard valid, so the acceptnonstdtxn=1 parameter can also be removed from the functional test.

    Kudos to stratospher, who (IIRC) mentioned this outdated comment a while ago.

  2. DrahtBot added the label Tests on Jan 21, 2026
  3. DrahtBot commented at 4:09 am on January 21, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34361.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. test: clean up tx resurrection (re-org) test in feature_block.py
    This comment about ECDSA signatures created with the test framework not
    passing mempool policy has been obsolete for a long time (at least since
    2019, see PR #15826), so remove it. While at it, change the resurrected
    txs to be indeed standard valid, so the `-acceptnonstdtxn=1` parameter
    can also be removed.
    5b2c3960b9
  5. theStack force-pushed on Jan 21, 2026
  6. DrahtBot added the label CI failed on Jan 21, 2026
  7. DrahtBot removed the label CI failed on Jan 21, 2026


theStack DrahtBot

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-27 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me