test: clean up tx resurrection (re-org) test in feature_block.py #34361

1. 
   theStack commented at 4:08 am on January 21, 2026: contributor

   The following comment about ECDSA signatures created with the test framework not passing mempool policy has been obsolete for a long time (at least since 2019, see PR #15826):

   https://github.com/bitcoin/bitcoin/blob/8c07800b193e94740a20f40d3e7c6626a59dd21f/test/functional/feature_block.py#L1167-L1172

   so remove it. While at it, change the resurrected txs to be indeed standard valid, so the acceptnonstdtxn=1 parameter can also be removed from the functional test.

   Kudos to stratospher, who (IIRC) mentioned this outdated comment a while ago.

2. DrahtBot added the label Tests on Jan 21, 2026
3. 
   DrahtBot commented at 4:09 am on January 21, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34361.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sedited, Bortlesboat, stratospher

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

4. test: clean up tx resurrection (re-org) test in feature_block.py

   This comment about ECDSA signatures created with the test framework not
   passing mempool policy has been obsolete for a long time (at least since
   2019, see PR #15826), so remove it. While at it, change the resurrected
   txs to be indeed standard valid, so the `-acceptnonstdtxn=1` parameter
   can also be removed.

   5b2c3960b9
5. theStack force-pushed on Jan 21, 2026
6. DrahtBot added the label CI failed on Jan 21, 2026
7. DrahtBot removed the label CI failed on Jan 21, 2026
8. sedited approved
9. 
   sedited commented at 9:09 am on March 8, 2026: contributor

   ACK 5b2c3960b929bd015911783fb59e3660b0810f03
10. sedited requested review from stratospher on Mar 8, 2026
11. 
    fanquake commented at 2:41 pm on March 8, 2026: member

    cc @stratospher
12. 
    Bortlesboat commented at 7:01 pm on March 8, 2026: none

    Tested ACK 5b2c3960b929. Ran feature_block.py locally, passes. Nice cleanup — removing -acceptnonstdtxn=1 by making the resurrection txs standard (P2PK) is the right approach. The old unsigned OP_TRUE workaround comment explains why this was needed, glad to see it gone.
13. 
    stratospher commented at 7:13 am on March 9, 2026: contributor

    ACK 5b2c3960. nice!
14. fanquake merged this on Mar 9, 2026
15. fanquake closed this on Mar 9, 2026

    ---

16. theStack deleted the branch on Mar 9, 2026

Contributors
theStack DrahtBot sedited fanquake Bortlesboat stratospher

Labels
Tests