OP_NOP8 to the scriptSig to make it non-push-only. The test should check that scriptSig.IsPushOnly() is only enforced in P2SH mode when the scriptPubKey actually matches the P2SH pattern. To test this, we need to turn on the P2SH flag.
OP_NOP8 to the scriptSig to make it non-push-only. The test should check that scriptSig.IsPushOnly() is only enforced in P2SH mode when the scriptPubKey actually matches the P2SH pattern. To test this, we need to turn on the P2SH flag.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34380.
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
utACK c9ce1c7c4a12b54ada7d48f100ec3a141ae99f86
Good catch!
billymcbip
DrahtBot
sipa
darosior
Labels
Tests