I found another script_tests case that isn't behaving the way it was meant to. It's a P2PK spend where we add an OP_NOP8 to the scriptSig to make it non-push-only. The test should check that scriptSig.IsPushOnly() is only enforced in P2SH mode when the scriptPubKey actually matches the P2SH pattern. To test this, we need to turn on the P2SH flag.
test: Fix P2PK script test #34380
pull billymcbip wants to merge 1 commits into bitcoin:master from billymcbip:sigpushonly changing 2 files +2 −2-
billymcbip commented at 12:35 PM on January 22, 2026: contributor
-
test: Fix P2PK script test c9ce1c7c4a
- DrahtBot added the label Tests on Jan 22, 2026
-
DrahtBot commented at 12:35 PM on January 22, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34380.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- billymcbip referenced this in commit 269281b7cc on Jan 22, 2026
-
sipa commented at 2:23 PM on January 22, 2026: member
ACK c9ce1c7c4a12b54ada7d48f100ec3a141ae99f86
- darosior approved
-
darosior commented at 2:44 PM on January 22, 2026: member
utACK c9ce1c7c4a12b54ada7d48f100ec3a141ae99f86
Good catch!
- fanquake merged this on Jan 23, 2026
- fanquake closed this on Jan 23, 2026
- billymcbip deleted the branch on Jan 23, 2026
Contributors
Labels