guix: use osslsigncode 2.12

fanquake commented at 11:28 am on January 26, 2026: member

Update osslsigncode used in Guix to 2.12.

Add zlib as an input, its a hard dependency since https://github.com/mtrojnar/osslsigncode/pull/303.

Add python-cryptography and python-minimal for running the tests.

DrahtBot added the label Build system on Jan 26, 2026

DrahtBot commented at 11:28 am on January 26, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34407.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#25573 (guix: produce a -static-pie bitcoind by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake added the label DrahtBot Guix build requested on Jan 26, 2026

in contrib/guix/manifest.scm:221 in 607485ab83

229-              (if tests?
230-                  (invoke "faketime" "-f" "@2025-01-01 00:00:00" ;; Tests fail after 2025.
231-                          "ctest" "--output-on-failure" "--no-tests=error")
232-                  (format #t "test suite not run~%")))))))
233-    (inputs (list libfaketime openssl))
234+    (inputs (list openssl zlib))

hebasto commented at 5:29 pm on January 26, 2026:

The tests are currently being skipped because of missing dependencies:

0-- Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter) 
1-- CTest skips tests: Python3 not found

If skipping these is intentional, we should probably do so explicitly in the build configuration.

FWIW, there is an upstream implementation available here: bb898f243ad0c10ba1c59ddbfbf7091c19c0277d.

DrahtBot commented at 8:45 pm on January 29, 2026: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 2778eb46647a629c439e3688ddeedd5bef5d2511(master)	commit 63b36911b74dcc86ec96d82c45304a58223acc23(pull/34407/merge)
*-aarch64-linux-gnu-debug.tar.gz	`019c0535d2173cc9...`	`d0fd98a54874af8a...`
*-aarch64-linux-gnu.tar.gz	`33b4a0cfc47187c0...`	`f0a0b3f589f0ceae...`
*-arm-linux-gnueabihf-debug.tar.gz	`686552831b304414...`	`db197e0fb009a5a1...`
*-arm-linux-gnueabihf.tar.gz	`f71618d722e95e81...`	`d1e61a1ce98d4463...`
*-arm64-apple-darwin-codesigning.tar.gz	`9445fa2a2ace0400...`	`a235fa54f47a2c95...`
*-arm64-apple-darwin-unsigned.tar.gz	`00534be3e2154e2b...`	`06f63238b3c3c8d7...`
*-arm64-apple-darwin-unsigned.zip	`1312439abf4b95e2...`	`577eda2ce3d751b6...`
*-powerpc64-linux-gnu-debug.tar.gz	`ceb3b7104397900b...`	`f44d053745286e65...`
*-powerpc64-linux-gnu.tar.gz	`32e437fc9ecbd9e4...`	`e9943cc91a55b9a5...`
*-riscv64-linux-gnu-debug.tar.gz	`4c2899e05bd609f8...`	`7cc8f3c76d89239c...`
*-riscv64-linux-gnu.tar.gz	`b4db92e5b88bcf16...`	`e585a0c2a58b4fcb...`
*-win64-codesigning.tar.gz	`a9377995f373ffc5...`	`80b845f853786702...`
*-win64-debug.zip	`31ef08e8e085985c...`	`bb83254cd42cfeb4...`
*-win64-setup-unsigned.exe	`c42352b7cb1d8026...`	`bd8f4f339942dd6d...`
*-win64-unsigned.zip	`4f18a3f583ee7010...`	`323cc7d28fbbccc5...`
*-x86_64-apple-darwin-codesigning.tar.gz	`56abfaca37c5bdc1...`	`19356dc3817ac6ce...`
*-x86_64-apple-darwin-unsigned.tar.gz	`a1bf39433db0ba08...`	`603c46e376b07c7e...`
*-x86_64-apple-darwin-unsigned.zip	`557b65aaefb4f4ed...`	`2f620b461c672203...`
*-x86_64-linux-gnu-debug.tar.gz	`1e3674347bf564d6...`	`2742a97585708b96...`
*-x86_64-linux-gnu.tar.gz	`b1f3a396967f9bd0...`	`e43927f08af02b43...`
*.tar.gz	`922a5318f1bd0dfc...`	`017463b8c8f6348e...`
SHA256SUMS.part	`7cad73ada2210cbb...`	`8315106612962497...`
guix_build.log	`65d2a74862c7ed9b...`	`7e3a6466bf6fe296...`
guix_build.log.diff		`aaf93b1022ebe4db...`

DrahtBot removed the label DrahtBot Guix build requested on Jan 29, 2026

fanquake commented at 6:35 pm on February 2, 2026: member

Will update this to 2.12: https://github.com/mtrojnar/osslsigncode/releases/tag/2.12.

fanquake force-pushed on Feb 3, 2026

DrahtBot added the label CI failed on Feb 3, 2026

guix: use osslsigncode 2.12

Add zlib as an input, its a hard dependency since
https://github.com/mtrojnar/osslsigncode/pull/303.

8c0be94f41

in contrib/guix/manifest.scm:221 in 1f98688544

229-              (if tests?
230-                  (invoke "faketime" "-f" "@2025-01-01 00:00:00" ;; Tests fail after 2025.
231-                          "ctest" "--output-on-failure" "--no-tests=error")
232-                  (format #t "test suite not run~%")))))))
233-    (inputs (list libfaketime openssl))
234+    (inputs (list openssl python-cryptography python-minimal zlib))

hebasto commented at 1:59 pm on February 3, 2026:

FWIW, Guix people suggest using python-minimal-wrapper.

And test-specific dependencies could be listed as native-inputs.

fanquake commented at 2:08 pm on February 3, 2026:

FWIW, Guix people suggest using python-minimal-wrapper.

What is the difference for us? Looks like python-minimal-wrapper just installs additional symlinks?

fanquake force-pushed on Feb 3, 2026

fanquake marked this as ready for review on Feb 3, 2026

DrahtBot removed the label CI failed on Feb 3, 2026

fanquake renamed this:
~~guix: use osslsigncode 2.11~~
guix: use osslsigncode 2.12
on Feb 3, 2026

fanquake commented at 3:31 pm on February 3, 2026: member

Guix Build (x86_64):

 0ea0279cbef14eb1625338c209bb2c592f4f9cb7b6e079cdecdcc55fa1841f7c2  guix-build-8c0be94f41e1/output/aarch64-linux-gnu/SHA256SUMS.part
 100189711807d74b78c10f26cb3059d56ddf3f9d20efe1726a5f49475a069bb32  guix-build-8c0be94f41e1/output/aarch64-linux-gnu/bitcoin-8c0be94f41e1-aarch64-linux-gnu-debug.tar.gz
 2450fdfe6a1e11fa59d2c85950dc7954990ffe25ea2d8dc92e7dd1c46e9fbabf4  guix-build-8c0be94f41e1/output/aarch64-linux-gnu/bitcoin-8c0be94f41e1-aarch64-linux-gnu.tar.gz
 3538b929b5b87b0c0cf4c4f7915d083709382c2ef1752829be6acace7b4d459b8  guix-build-8c0be94f41e1/output/arm-linux-gnueabihf/SHA256SUMS.part
 403b3a9f73dd5e719b08715646b64759ed7dba95f559e59b4385149ab49ee056a  guix-build-8c0be94f41e1/output/arm-linux-gnueabihf/bitcoin-8c0be94f41e1-arm-linux-gnueabihf-debug.tar.gz
 53c6faea4a2f27d7bdf15c36e58cd7c58ddacb90981c718e81ac12690d2af20dc  guix-build-8c0be94f41e1/output/arm-linux-gnueabihf/bitcoin-8c0be94f41e1-arm-linux-gnueabihf.tar.gz
 68b0c65d5fb69c3ba6f5669bf5d1bd7794deadfa49a4b662212a02e22580fe9d1  guix-build-8c0be94f41e1/output/arm64-apple-darwin/SHA256SUMS.part
 7e56d938598aa4cde2ea92ca028c5d704fa300430ecc89cf1f9973dfbbf397c30  guix-build-8c0be94f41e1/output/arm64-apple-darwin/bitcoin-8c0be94f41e1-arm64-apple-darwin-codesigning.tar.gz
 80aeed57089d755a17b598584d2b17e300065e7727c5ca7ea615108dbdbd65595  guix-build-8c0be94f41e1/output/arm64-apple-darwin/bitcoin-8c0be94f41e1-arm64-apple-darwin-unsigned.tar.gz
 91d67618a7791b87fc382e8e44d3b4e962b961d93d876f115bafaaf2a8c5e28ee  guix-build-8c0be94f41e1/output/arm64-apple-darwin/bitcoin-8c0be94f41e1-arm64-apple-darwin-unsigned.zip
1086f9175676e6641c8adbe8e07b3e1edc88bcf61971d940cedfd2cbe29b06717e  guix-build-8c0be94f41e1/output/dist-archive/bitcoin-8c0be94f41e1.tar.gz
1197396313295bcfd5f8206eacde5dc6638ece4c63e9ca7ac7760d3ba842bbc4ec  guix-build-8c0be94f41e1/output/powerpc64-linux-gnu/SHA256SUMS.part
126e4112bf4008973d56fbf4b15aff3e1405d0fb24fe9520b1b2d368eb6543e27f  guix-build-8c0be94f41e1/output/powerpc64-linux-gnu/bitcoin-8c0be94f41e1-powerpc64-linux-gnu-debug.tar.gz
137df5152a20b26b6bde16f2d61b605a78f55473a993d935af90c3a217860c5ead  guix-build-8c0be94f41e1/output/powerpc64-linux-gnu/bitcoin-8c0be94f41e1-powerpc64-linux-gnu.tar.gz
1484dc9435a5b784c79e4c88aa3c8501924f4efbc5a5a067d9e3c6f07935f49e2d  guix-build-8c0be94f41e1/output/riscv64-linux-gnu/SHA256SUMS.part
1514058cb93d5c15f2c87ac4d80acfb68664b7e3d133befba4cfb78b126825f923  guix-build-8c0be94f41e1/output/riscv64-linux-gnu/bitcoin-8c0be94f41e1-riscv64-linux-gnu-debug.tar.gz
169430524dbb1a7fc21c0ecb6e7324c892a8d5bf6bcef856bd7de3574e26191af7  guix-build-8c0be94f41e1/output/riscv64-linux-gnu/bitcoin-8c0be94f41e1-riscv64-linux-gnu.tar.gz
174928aae3fc04b06da0d9f605529576410a1b2da8ab07e0be430a4d8414548f08  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/SHA256SUMS.part
181f54881cc1e97aa08f874477ed6823b29808a070f464d0d8f627a1263d1af9f5  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/bitcoin-8c0be94f41e1-x86_64-apple-darwin-codesigning.tar.gz
19a8e19680360ba177af7f549a875402fb2a0229116bb73ffa0f15222dc45447a3  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/bitcoin-8c0be94f41e1-x86_64-apple-darwin-unsigned.tar.gz
207cfcb7df0e8a399752678c496af1db63b4f22e3efe9bfe30e6451094f13cb7f0  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/bitcoin-8c0be94f41e1-x86_64-apple-darwin-unsigned.zip
216085d40a64734880424be1c4e9f5114145a04c394b8b073dd2cd73ca8aa47158  guix-build-8c0be94f41e1/output/x86_64-linux-gnu/SHA256SUMS.part
22115fba02fbe27ea535c4b69037df3e152be1b4ba4ce190f27ea2d10c8d765f33  guix-build-8c0be94f41e1/output/x86_64-linux-gnu/bitcoin-8c0be94f41e1-x86_64-linux-gnu-debug.tar.gz
23a87ac28aa53a75ec9586de6d8981feac006da50e1345f7c426c792b6fff85c8b  guix-build-8c0be94f41e1/output/x86_64-linux-gnu/bitcoin-8c0be94f41e1-x86_64-linux-gnu.tar.gz
24f834c6b504d81b5c1beab6ce30b7892f19746182d4548c3bccb6f104974b29cd  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/SHA256SUMS.part
259aff81708cf11cd4030910757254399bf98a79366afcc7c89c4e4901233752e8  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-codesigning.tar.gz
26ab3ed6b3bc90443231cfcac13b1c9e2beea269309535cf9fdf09b9708483fa3b  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-debug.zip
27bc2cdba0b906ef017749d6e65826ebe4d224676a433df1f4e2fcc51678ae24f1  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-setup-unsigned.exe
28f4aa53ba88553426812938b205fb409ef283ebbe60ae8ce1d2efa68f472b4b6a  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-unsigned.zip

willcl-ark commented at 5:38 pm on February 3, 2026: member

x64 build:

 0x86_64
 1ea0279cbef14eb1625338c209bb2c592f4f9cb7b6e079cdecdcc55fa1841f7c2  guix-build-8c0be94f41e1/output/aarch64-linux-gnu/SHA256SUMS.part
 200189711807d74b78c10f26cb3059d56ddf3f9d20efe1726a5f49475a069bb32  guix-build-8c0be94f41e1/output/aarch64-linux-gnu/bitcoin-8c0be94f41e1-aarch64-linux-gnu-debug.tar.gz
 3450fdfe6a1e11fa59d2c85950dc7954990ffe25ea2d8dc92e7dd1c46e9fbabf4  guix-build-8c0be94f41e1/output/aarch64-linux-gnu/bitcoin-8c0be94f41e1-aarch64-linux-gnu.tar.gz
 4538b929b5b87b0c0cf4c4f7915d083709382c2ef1752829be6acace7b4d459b8  guix-build-8c0be94f41e1/output/arm-linux-gnueabihf/SHA256SUMS.part
 503b3a9f73dd5e719b08715646b64759ed7dba95f559e59b4385149ab49ee056a  guix-build-8c0be94f41e1/output/arm-linux-gnueabihf/bitcoin-8c0be94f41e1-arm-linux-gnueabihf-debug.tar.gz
 63c6faea4a2f27d7bdf15c36e58cd7c58ddacb90981c718e81ac12690d2af20dc  guix-build-8c0be94f41e1/output/arm-linux-gnueabihf/bitcoin-8c0be94f41e1-arm-linux-gnueabihf.tar.gz
 78b0c65d5fb69c3ba6f5669bf5d1bd7794deadfa49a4b662212a02e22580fe9d1  guix-build-8c0be94f41e1/output/arm64-apple-darwin/SHA256SUMS.part
 8e56d938598aa4cde2ea92ca028c5d704fa300430ecc89cf1f9973dfbbf397c30  guix-build-8c0be94f41e1/output/arm64-apple-darwin/bitcoin-8c0be94f41e1-arm64-apple-darwin-codesigning.tar.gz
 90aeed57089d755a17b598584d2b17e300065e7727c5ca7ea615108dbdbd65595  guix-build-8c0be94f41e1/output/arm64-apple-darwin/bitcoin-8c0be94f41e1-arm64-apple-darwin-unsigned.tar.gz
101d67618a7791b87fc382e8e44d3b4e962b961d93d876f115bafaaf2a8c5e28ee  guix-build-8c0be94f41e1/output/arm64-apple-darwin/bitcoin-8c0be94f41e1-arm64-apple-darwin-unsigned.zip
1186f9175676e6641c8adbe8e07b3e1edc88bcf61971d940cedfd2cbe29b06717e  guix-build-8c0be94f41e1/output/dist-archive/bitcoin-8c0be94f41e1.tar.gz
1297396313295bcfd5f8206eacde5dc6638ece4c63e9ca7ac7760d3ba842bbc4ec  guix-build-8c0be94f41e1/output/powerpc64-linux-gnu/SHA256SUMS.part
136e4112bf4008973d56fbf4b15aff3e1405d0fb24fe9520b1b2d368eb6543e27f  guix-build-8c0be94f41e1/output/powerpc64-linux-gnu/bitcoin-8c0be94f41e1-powerpc64-linux-gnu-debug.tar.gz
147df5152a20b26b6bde16f2d61b605a78f55473a993d935af90c3a217860c5ead  guix-build-8c0be94f41e1/output/powerpc64-linux-gnu/bitcoin-8c0be94f41e1-powerpc64-linux-gnu.tar.gz
1584dc9435a5b784c79e4c88aa3c8501924f4efbc5a5a067d9e3c6f07935f49e2d  guix-build-8c0be94f41e1/output/riscv64-linux-gnu/SHA256SUMS.part
1614058cb93d5c15f2c87ac4d80acfb68664b7e3d133befba4cfb78b126825f923  guix-build-8c0be94f41e1/output/riscv64-linux-gnu/bitcoin-8c0be94f41e1-riscv64-linux-gnu-debug.tar.gz
179430524dbb1a7fc21c0ecb6e7324c892a8d5bf6bcef856bd7de3574e26191af7  guix-build-8c0be94f41e1/output/riscv64-linux-gnu/bitcoin-8c0be94f41e1-riscv64-linux-gnu.tar.gz
184928aae3fc04b06da0d9f605529576410a1b2da8ab07e0be430a4d8414548f08  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/SHA256SUMS.part
191f54881cc1e97aa08f874477ed6823b29808a070f464d0d8f627a1263d1af9f5  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/bitcoin-8c0be94f41e1-x86_64-apple-darwin-codesigning.tar.gz
20a8e19680360ba177af7f549a875402fb2a0229116bb73ffa0f15222dc45447a3  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/bitcoin-8c0be94f41e1-x86_64-apple-darwin-unsigned.tar.gz
217cfcb7df0e8a399752678c496af1db63b4f22e3efe9bfe30e6451094f13cb7f0  guix-build-8c0be94f41e1/output/x86_64-apple-darwin/bitcoin-8c0be94f41e1-x86_64-apple-darwin-unsigned.zip
226085d40a64734880424be1c4e9f5114145a04c394b8b073dd2cd73ca8aa47158  guix-build-8c0be94f41e1/output/x86_64-linux-gnu/SHA256SUMS.part
23115fba02fbe27ea535c4b69037df3e152be1b4ba4ce190f27ea2d10c8d765f33  guix-build-8c0be94f41e1/output/x86_64-linux-gnu/bitcoin-8c0be94f41e1-x86_64-linux-gnu-debug.tar.gz
24a87ac28aa53a75ec9586de6d8981feac006da50e1345f7c426c792b6fff85c8b  guix-build-8c0be94f41e1/output/x86_64-linux-gnu/bitcoin-8c0be94f41e1-x86_64-linux-gnu.tar.gz
25f834c6b504d81b5c1beab6ce30b7892f19746182d4548c3bccb6f104974b29cd  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/SHA256SUMS.part
269aff81708cf11cd4030910757254399bf98a79366afcc7c89c4e4901233752e8  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-codesigning.tar.gz
27ab3ed6b3bc90443231cfcac13b1c9e2beea269309535cf9fdf09b9708483fa3b  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-debug.zip
28bc2cdba0b906ef017749d6e65826ebe4d224676a433df1f4e2fcc51678ae24f1  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-setup-unsigned.exe
29f4aa53ba88553426812938b205fb409ef283ebbe60ae8ce1d2efa68f472b4b6a  guix-build-8c0be94f41e1/output/x86_64-w64-mingw32/bitcoin-8c0be94f41e1-win64-unsigned.zip

fanquake requested review from sedited on Feb 9, 2026

fanquake commented at 12:23 pm on February 9, 2026: member

cc @pinheadmz

fanquake commented at 5:21 pm on February 10, 2026: member

Rolled into #34550.

fanquake closed this on Feb 10, 2026

fanquake deleted the branch on Feb 10, 2026

guix: use osslsigncode 2.12 #34407

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]