ci: remove gnu-getopt usage #34408

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_gnu_getopt_retry changing 5 files +3 −97
  1. fanquake commented at 11:40 am on January 26, 2026: member

    This is used for argument parsing in the retry script, however we don’t use the script with any arguments. So remove the unused code, and the dependency on gnu-getopt.

    This came up in the context of adding new CI jobs, where gnu-getopt might not be available, or working properly. It seemed easier to just remove the unused code, than look for more workarounds.

  2. DrahtBot added the label Tests on Jan 26, 2026
  3. DrahtBot commented at 11:41 am on January 26, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34408.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, sedited
    Concept ACK hebasto

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34411 ([POC] Full Libevent removal by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. maflcko commented at 12:24 pm on January 26, 2026: member
    Was about to suggest to re-write this in Python or Rust at this point, but python is not installed yet, and installing it should be done with a re-try, so this is probably the only place where Bash makes sense for now.
  5. ci: remove gnu-getopt usage
    This is used for argument parsing in the retry script, however we don't
    use the script with any arguments. So remove the unused code, and the
    dependency on gnu-getopt.
    
    This came up in the context of adding new CI jobs, where gnu-getopt
    might not be available, or working properly. It seemed easier to just
    remove the unused code, than look for more workarounds.
    ddae1b4efa
  6. fanquake marked this as ready for review on Jan 27, 2026
  7. fanquake force-pushed on Jan 27, 2026
  8. fanquake commented at 4:43 pm on January 27, 2026: member
    Yea. Also happy to push more changes here, to remove more dead code, if that is preferred.
  9. hebasto commented at 5:00 pm on January 27, 2026: member
    Concept ACK.
  10. maflcko commented at 5:26 pm on January 27, 2026: member

    review ACK ddae1b4efa568b6099d5bece941f8f2733faf29e 🔀

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: review ACK ddae1b4efa568b6099d5bece941f8f2733faf29e 🔀
    37Y1j169fg1kdnOGjIDvRv7nV4+0nrQ28+mUibiB5iLxvNvSx35LU9t5WhP1FlbamndgLREEx2yn4AgUg8ByIDw==
    
  11. DrahtBot requested review from hebasto on Jan 27, 2026
  12. sedited approved
  13. sedited commented at 1:13 pm on January 28, 2026: contributor
    ACK ddae1b4efa568b6099d5bece941f8f2733faf29e
  14. sedited merged this on Jan 28, 2026
  15. sedited closed this on Jan 28, 2026

  16. fanquake deleted the branch on Jan 28, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-02-18 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me